[JBoss JIRA] Created: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
3:16 p.m.
Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357541 ]
Brian Stansberry commented on JGRP-449:
---------------------------------------
The relevant call to down is in ClusterPartition.startService():
if (this.nodeName == null || "".equals(this.nodeName))
this.nodeName = generateUniqueNodeName ();
java.util.HashMap staticNodeName = new java.util.HashMap();
staticNodeName.put("additional_data", this.nodeName.getBytes());
this.channel.down(new org.jgroups.Event(org.jgroups.Event.CONFIG, staticNodeName));
Michael, you mentioned "used in a few places" -- did you see others (save me
some search time).
For 4.2.0.GA I'll change it so it makes that call via reflection. Presuming reverting
the method signature change is not an option, I don't see how this can be handled for
earlier AS releases.
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:33 p.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357544 ]
Brian Stansberry commented on JGRP-449:
---------------------------------------
JBAS-4258 deals with JGRP-449 for AS 4.2.x.
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 a.m.
New subject: [JBoss JIRA] Updated: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=all ]
Bela Ban updated JGRP-449:
--------------------------
Fix Version/s: 2.5
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:37 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357607 ]
Michael Newcomb commented on JGRP-449:
--------------------------------------
Sorry about that, I mentioned that before I did a complete search.
That appears to be the only use of Channel.down().
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:05 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357617 ]
Michael Newcomb commented on JGRP-449:
--------------------------------------
Sorry, I misread my own comment.
There is only one use of Channel.down() inside JBoss and that is in the ClusterPartition
(as you pointed out).
There are a few uses of the return result in Channel.down() inside JGroups and they are:
JChannel.connect, line 369:
Object res=down(connect_event); // waits forever until connected (or channel is closed)
JChannel.startFlush, line 1460:
successfulFlush = (Boolean) down(new Event(Event.SUSPEND));
MessageDispatcher.ProtocolAdapter.down(), line 737:
return channel.down(evt);
MuxChannel.down(), line 204:
return ch.down(evt);
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:06 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357619 ]
Brian Stansberry commented on JGRP-449:
---------------------------------------
Bela, I made the AS 4.2 change described in JBAS-4258, dropped in JG 2.5.0.Beta1 and ran
the clustering testsuite. It ran fine. So, for 4.2 and onward, this is not an issue.
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 a.m.
New subject: [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12358052 ]
Bela Ban commented on JGRP-449:
-------------------------------
I reverted the signature of
Object Channel.down(Event evt)
to
void Channel.down(Event evt)
I also changed all uses of down() to downcall(). This method will be removed in 3.0, when
we change the signature of down() to again return an Object.
I tested this with JBoss 4.0.5, ands it works
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:30 a.m.
New subject: [JBoss JIRA] Resolved: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
[ http://jira.jboss.com/jira/browse/JGRP-449?page=all ]
Bela Ban resolved JGRP-449.
---------------------------
Resolution: Done
resolved by reverting to the old signature
Changing signature of Channel.down() breaks drop in replacement with
JGroups <= 2.4
-----------------------------------------------------------------------------------
Key: JGRP-449
URL: http://jira.jboss.com/jira/browse/JGRP-449
Project: JGroups
Issue Type: Bug
Affects Versions: 2.5
Environment: JGroups 2.5 beta-1
Reporter: Michael Newcomb
Assigned To: Bela Ban
Fix For: 2.5
Changing the signatue for Channel.down() from:
void down(Event e);
to:
Object down(Event e);
Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
This is not a super major issue (just need to recompile JBoss), but since our project
doesn't like the idea of recompiling JBoss (want to get it directly from the site) it
is a show stopper.
If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be
done but the result of Channel.down() is only used in a few places, so it shouldn't be
too much to get it to work.
It looks like it is just the JBoss HA service that uses Channel.down() explicitly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6804
days inactive
6810
days old
8 comments
3 participants
participants (3)
-
Bela Ban (JIRA) -
Brian Stansberry (JIRA)
-
Michael Newcomb (JIRA)