[JBoss JIRA] Created: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
1:48 p.m.
IdentityServiceControllerImpl : unregister existing MBean service before to re register
them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Priority: Optional
Fix For: 2.6.3 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:21 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=all ]
Thomas Heute updated JBPORTAL-1730:
-----------------------------------
Assignee: Thomas Heute
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.3 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:29 a.m.
New subject: [JBoss JIRA] Resolved: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=all ]
Thomas Heute resolved JBPORTAL-1730.
------------------------------------
Resolution: Done
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.3 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:31 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=comments#action_1238... ]
Thomas Heute commented on JBPORTAL-1730:
----------------------------------------
Thanks
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.3 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:14 p.m.
New subject: [JBoss JIRA] Reopened: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=all ]
Antoine Herzog reopened JBPORTAL-1730:
--------------------------------------
For Identity 1.0.2, the identity services have been modified.
IdentityServiceControllerImpl have been rewritten
registration of these services is done with the IdentityServiceLoader.
The new class needs also this small, usefull, test : unregister the services that are yet
on, before to ask the new registration...
in the IdentityServiceLoader, at the end of the method registerMBean() :
add the code :
ObjectName objName = new ObjectName(serviceName);
if (getServer().isRegistered(objName)) {
getServer().unregisterMBean(objName);
}
getServer().registerMBean(mbean, objName);
thanks,
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.3 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 a.m.
New subject: [JBoss JIRA] Updated: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=all ]
Thomas Heute updated JBPORTAL-1730:
-----------------------------------
Fix Version/s: 2.6.5 Final
(was: 2.6.3 Final)
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:02 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=comments#action_1240... ]
Thomas Heute commented on JBPORTAL-1730:
----------------------------------------
registerMBean is in charge of registering (and throw an exception in case it's already
registered or couldn't register). So the logic shouldn't be there.
That said, all the calls to registerMBean are previously called with unregisterMBean which
would have the same effect as what you are doing here.
So in your case what is happening ? What's calling registerMBean ? What issue do you
face, what's the stack trace ?
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 p.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=comments#action_1240... ]
Antoine Herzog commented on JBPORTAL-1730:
------------------------------------------
**********************************************************
I replace the IdentityServiceController, by another implementation and another JMX
description ... but with the same JMXService name.
The new service implementation take the place of the jboss original one (replacement).
The JBoss original JMX description is put within comment (the original service is off).
The replacement service is packaged in another proprietary sar.
In the MyIdentityServiceControllerImpl, the IdentityServiceLoader is used exactly the same
way as in the original IdentityServiceController code.
The extra code in MyIdentityServiceControllerImpl is for specific initialization of the
MBeans, not about registering them.
When I redeploy the Sar package, this exception is thrown from the IdentityServiceLoader
:
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
at org.jboss.mx.server.registry.BasicMBeanRegistry.add(BasicMBeanRegistry.java:761)
at
org.jboss.mx.server.registry.BasicMBeanRegistry.registerMBean(BasicMBeanRegistry.java:225)
at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
**********************************************************
The code I propose will unregister the MBean if needed, before to re-register it, and this
solve the problem.
**********************************************************
Note about the original portal code :
In the original code of the portal, it does not seems that the MBean are unregistered
before the call of registerMBean.
"That said, all the calls to registerMBean are previously called with unregisterMBean
" : this does not seems ok...
make a test :
- run the original JBoss Portal, out of the box
- make a touch of the jboss-service.xml files that are in the
/server/default/deploy/jboss-portal.sar/portal-identity.sar/META-INF
and
/server/default/deploy/jboss-portal.sar/META-INF
the server start redeploying ...
the exception is thrown ...
23:04:21,687 WARN [ServiceController] Problem starting service
portal:service=Module,type=IdentityServiceController
org.jboss.portal.identity.IdentityException: Cannot initiate identity modules:
at
org.jboss.portal.core.identity.service.IdentityServiceControllerImpl.startService(IdentityServiceControllerImpl.java:160)
at
org.jboss.system.ServiceMBeanSupport.jbossInternalStart(ServiceMBeanSupport.java:289)
at org.jboss.system.ServiceMBeanSupport.start(ServiceMBeanSupport.java:196)
....
Caused by: javax.management.InstanceAlreadyExistsException:
portal:service=Module,type=User already registered.
at
org.jboss.mx.server.registry.BasicMBeanRegistry.add(BasicMBeanRegistry.java:761)
at
org.jboss.mx.server.registry.BasicMBeanRegistry.registerMBean(BasicMBeanRegistry.java:225)
at sun.reflect.GeneratedMethodAccessor1.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at
org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:155)
at org.jboss.mx.server.Invocation.dispatch(Invocation.java:94)
so, I guess that the service is not unregistered before new one is registered ? or did I
missed something ?
**********************************************************
Redeploying the portal sar is not a good idea, as it breaks everything in the portal run.
but when the IdentityServiceController is "replaced" by another implementation,
that is in another .sar, then it is very usefull (for me) to be able to redeploy this
.sar.
**********************************************************
This problem is the same as the one in the former version.
the Identity services have been reprogrammed with MBean instead of JMX services.
so it is just about the same solution, that was forgotten to "move" to the new
implementation.
or I missed something big about all that MBean ?
Thanks,
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:41 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=comments#action_1240... ]
Thomas Heute commented on JBPORTAL-1730:
----------------------------------------
Now i understand better :)
When i closed the case i did add calls to unregister before registering, and applied that
to the trunk of the identity module.
http://anonsvn.jboss.org/repos/portal/modules/identity/trunk/identity/src...
I forgot to apply it on the 1.0 Branch,
http://anonsvn.jboss.org/repos/portal/modules/identity/branches/JBP_IDENT...
so it didn't get released in identity 1.0.x and JBP 2.6.x .
Sorry about that, it will be included in 2.6.5
Thanks !
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:04 a.m.
New subject: [JBoss JIRA] Commented: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=comments#action_1240... ]
Antoine Herzog commented on JBPORTAL-1730:
------------------------------------------
ok...
and thanks for the enhancement : it is even better to let this method react if the service
is registered yet... and set the proper unregistering code at the upper level....
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:26 a.m.
New subject: [JBoss JIRA] Resolved: (JBPORTAL-1730) IdentityServiceControllerImpl : unregister existing MBean service before to re register them
[ http://jira.jboss.com/jira/browse/JBPORTAL-1730?page=all ]
Thomas Heute resolved JBPORTAL-1730.
------------------------------------
Fix Version/s: Identity-1.0.3
Resolution: Done
Backported to Branch_1_0
If you want to give it a try before it becomes part of JBP 2.6.5 you can get the identity
sources here:
http://anonsvn.jboss.org/repos/portal/modules/identity/branches/JBP_IDENT...
Then replace jboss-portal.sar/lib/portal-identity-lib.jar by the new one
IdentityServiceControllerImpl : unregister existing MBean service
before to re register them
--------------------------------------------------------------------------------------------
Key: JBPORTAL-1730
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1730
Project: JBoss Portal
Issue Type: Task
Security Level: Public(Everyone can see)
Components: Portal Identity
Affects Versions: 2.6.1 Final
Reporter: Antoine Herzog
Assigned To: Thomas Heute
Priority: Optional
Fix For: 2.6.5 Final, Identity-1.0.3
In IdentityServiceControllerImpl (service
name="portal:service=Module,type=IdentityServiceController")
the Identity Beans are registered as JMX MBeans.
When redeploying the service, an exception is thrown, as the services are yet deployed.
javax.management.InstanceAlreadyExistsException: portal:service=Module,type=User already
registered.
Let's put this code before to register the bean, at line 378 of
IdentityServiceControllerImpl.java
// Unregister the former service is if it is yet there.
// This to avoid the exception when redeploying this service
if (getServer().isRegistered(
new ObjectName(module.getServiceName()))) {
getServer().unregisterMBean(
new ObjectName(module.getServiceName()));
}
Thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6487
days inactive
6673
days old
10 comments
2 participants
participants (2)
-
Antoine Herzog (JIRA) -
Thomas Heute (JIRA)