[JBoss JIRA] Created: (JBREM-785) BisocketClientInvoker.transport() inadvertently changes listenerId member variable
2:12 a.m.
BisocketClientInvoker.transport() inadvertently changes listenerId member variable
----------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 2.2.1.GA, 2.2.1.SP1, 2.2.0.SP4_CP02, 2.4.0.Beta1 (Pinto)
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.2.1.SP1, 2.2.0.SP4_CP02, 2.4.0.Beta1 (Pinto)
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 a.m.
New subject: [JBoss JIRA] Updated: (JBREM-785) BisocketClientInvoker.transport() inadvertently uses listenerId member variable
[ http://jira.jboss.com/jira/browse/JBREM-785?page=all ]
Ron Sigal updated JBREM-785:
----------------------------
Summary: BisocketClientInvoker.transport() inadvertently uses listenerId member
variable (was: BisocketClientInvoker.transport() inadvertently changes listenerId member
variable)
Description:
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
was:org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets
listenerId member variable, instead of creating a new variable on the stack.
BisocketClientInvoker.transport() inadvertently uses listenerId
member variable
-------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.1.GA, 2.2.0.SP4_CP02, 2.2.1.SP1
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 a.m.
New subject: [JBoss JIRA] Commented: (JBREM-785) BisocketClientInvoker.transport() inadvertently uses listenerId member variable
[ http://jira.jboss.com/jira/browse/JBREM-785?page=comments#action_12370835 ]
Ron Sigal commented on JBREM-785:
---------------------------------
The fix has been applied to the remoting_2_2_0_GA branch.
Unit test:
org.jboss.test.remoting.transport.bisocket.listenerID.ListenerIDonStackTestCase.
BisocketClientInvoker.transport() inadvertently uses listenerId
member variable
-------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.1.GA, 2.2.0.SP4_CP02, 2.2.1.SP1
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.4.0.Beta1 (Pinto), 2.2.0.SP4_CP02, 2.2.1.SP1
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:31 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-785) BisocketClientInvoker.transport() inadvertently uses listenerId member variable
[ http://jira.jboss.com/jira/browse/JBREM-785?page=all ]
Ron Sigal updated JBREM-785:
----------------------------
Fix Version/s: 2.2.2.GA
2.4.0.CR1 (Pinto)
(was: 2.4.0.Beta1 (Pinto))
(was: 2.2.0.SP4_CP02)
(was: 2.2.1.SP1)
Affects Version/s: 2.2.0.SP4
(was: 2.2.0.SP4_CP02)
(was: 2.2.1.SP1)
BisocketClientInvoker.transport() inadvertently uses listenerId
member variable
-------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.2.0.SP4, 2.2.1.GA, 2.4.0.Beta1 (Pinto)
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.2.2.GA, 2.4.0.CR1 (Pinto)
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:51 p.m.
New subject: [JBoss JIRA] Updated: (JBREM-785) BisocketClientInvoker.transport() inadvertently uses listenerId member variable
[ http://jira.jboss.com/jira/browse/JBREM-785?page=all ]
Ron Sigal updated JBREM-785:
----------------------------
Fix Version/s: 2.4.0.Beta1 (Pinto)
(was: 2.4.0.CR1 (Pinto))
BisocketClientInvoker.transport() inadvertently uses listenerId
member variable
-------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.1.GA
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.4.0.Beta1 (Pinto), 2.2.2.GA
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:56 p.m.
New subject: [JBoss JIRA] Closed: (JBREM-785) BisocketClientInvoker.transport() inadvertently uses listenerId member variable
[ http://jira.jboss.com/jira/browse/JBREM-785?page=all ]
Ron Sigal closed JBREM-785.
---------------------------
Resolution: Done
The fix has been applied to branch remoting_2_x, and the unit test passes on
cruisecontrol.
BisocketClientInvoker.transport() inadvertently uses listenerId
member variable
-------------------------------------------------------------------------------
Key: JBREM-785
URL: http://jira.jboss.com/jira/browse/JBREM-785
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 2.4.0.Beta1 (Pinto), 2.2.0.SP4, 2.2.1.GA
Reporter: Ron Sigal
Assigned To: Ron Sigal
Fix For: 2.2.2.GA, 2.4.0.Beta1 (Pinto)
org.jboss.remoting.transport.bisocket.BisocketClientInvoker.transport() sets listenerId
member variable, instead of creating a new variable on the stack. As a result, there is a
race condition if multiple org.jboss.remoting.Client's call addListener() on the same
server. Each entering thread would attempt to add a (listenerId, BisocketClientInvoker)
pair to listenerIdToClientInvokerMap, and under the right circumstances, one or more of
the threads could experience the overwriting of the listenerId variable, which would lead
to a missing pair in listenerIdToClientInvokerMap.
The fix is just to use a stack variable instead of the member variable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6705
days inactive
6735
days old
5 comments
1 participants
participants (1)
-
Ron Sigal (JIRA)