10:24 a.m.
-P circumvents the additional processing needed for some props
--------------------------------------------------------------
Key: JBAS-4736
URL: http://jira.jboss.com/jira/browse/JBAS-4736
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: JBossAS-4.2.0.GA
Reporter: John Mazzitelli
org.jboss.Main does some special handling for some specific system properties (see
JBAS-4181 for example).
So, when -b is passed in for example, it does some special things for UDP/JGroups stuff.
However, if I start JBossAS using the -P option (a properties file that sets things like
jboss.bind.address and a bunch of other things), none of this special processing is done.
From Main.java:
case 'P':
{
// Set system properties from url/file
URL url = makeURL(getopt.getOptarg());
Properties props = System.getProperties();
props.load(url.openConnection().getInputStream());
break;
}
I think that case statement needs to do the things that the case '-b' does and
that case 'u' does - based on what properties were loaded from that file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 p.m.
New subject: [JBoss JIRA] Commented: (JBAS-4736) -P circumvents the additional processing needed for some props
[ http://jira.jboss.com/jira/browse/JBAS-4736?page=comments#action_12378484 ]
Raja commented on JBAS-4736:
----------------------------
I think its because of this:
Properties props = System.getProperties();
You dont need this as the props variable is defined at the top of this class and
recreating a props variable here creates it in a local scope and doesnt do anything with
the global props variable.
-P circumvents the additional processing needed for some props
--------------------------------------------------------------
Key: JBAS-4736
URL: http://jira.jboss.com/jira/browse/JBAS-4736
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossAS-4.2.0.GA
Reporter: John Mazzitelli
org.jboss.Main does some special handling for some specific system properties (see
JBAS-4181 for example).
So, when -b is passed in for example, it does some special things for UDP/JGroups stuff.
However, if I start JBossAS using the -P option (a properties file that sets things like
jboss.bind.address and a bunch of other things), none of this special processing is done.
From Main.java:
case 'P':
{
// Set system properties from url/file
URL url = makeURL(getopt.getOptarg());
Properties props = System.getProperties();
props.load(url.openConnection().getInputStream());
break;
}
I think that case statement needs to do the things that the case '-b' does and
that case 'u' does - based on what properties were loaded from that file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1 a.m.
New subject: [JBoss JIRA] Updated: (JBAS-4736) -P circumvents the additional processing needed for some props
[ http://jira.jboss.com/jira/browse/JBAS-4736?page=all ]
Raja updated JBAS-4736:
-----------------------
Attachment: 4736.patch
Patch that removes the local scoped variable -- Patched against jboss_4_2_1_GA Tag.
-P circumvents the additional processing needed for some props
--------------------------------------------------------------
Key: JBAS-4736
URL: http://jira.jboss.com/jira/browse/JBAS-4736
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossAS-4.2.0.GA
Reporter: John Mazzitelli
Attachments: 4736.patch
org.jboss.Main does some special handling for some specific system properties (see
JBAS-4181 for example).
So, when -b is passed in for example, it does some special things for UDP/JGroups stuff.
However, if I start JBossAS using the -P option (a properties file that sets things like
jboss.bind.address and a bunch of other things), none of this special processing is done.
From Main.java:
case 'P':
{
// Set system properties from url/file
URL url = makeURL(getopt.getOptarg());
Properties props = System.getProperties();
props.load(url.openConnection().getInputStream());
break;
}
I think that case statement needs to do the things that the case '-b' does and
that case 'u' does - based on what properties were loaded from that file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:31 a.m.
New subject: [JBoss JIRA] Commented: (JBAS-4736) -P circumvents the additional processing needed for some props
[ http://jira.jboss.com/jira/browse/JBAS-4736?page=comments#action_12378531 ]
John Mazzitelli commented on JBAS-4736:
---------------------------------------
-1
That patch does nothing to address the problems I mention in this JIRA.
Suppose I had this in foo.properties:
jboss.bind.address=11.22.33.44
jboss.partition.udpGroup=22.33.44.55
now I start jboss-as with -P foo.properties.
I need Main.java to do the things it does in the "case -b" and "case
-u" clauses, specifically, it needs to set the "jgroups.udp.mcast_addr"
property as the case u clause does and it needs to manipulate the bind.address,
jgroups.bind_addr and java.rmi.server.hostname properties.
The proposed patch does nothing with respect to this. Do not assume the user is passing
in -b or -u either (and even if the user does, you cannot assume you know the order in
which the -b, -u and -P are specified in the command line). In my case, I'm passing
in -P and nothing else and setting all the properties that I am required to. I, however,
wasn't and won't pass in those others that Main internally sets (for one, I was
using the older JGroups properties and didn't realize about the new ones
jgroups.bind_addr and jgroups.udp.mcast_addr - Main.java is trying to be nice and set
these for me in case -b and -u clauses - this is what I want the "case -P"
clause to do also.
-P circumvents the additional processing needed for some props
--------------------------------------------------------------
Key: JBAS-4736
URL: http://jira.jboss.com/jira/browse/JBAS-4736
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: JBossAS-4.2.0.GA
Reporter: John Mazzitelli
Attachments: 4736.patch
org.jboss.Main does some special handling for some specific system properties (see
JBAS-4181 for example).
So, when -b is passed in for example, it does some special things for UDP/JGroups stuff.
However, if I start JBossAS using the -P option (a properties file that sets things like
jboss.bind.address and a bunch of other things), none of this special processing is done.
From Main.java:
case 'P':
{
// Set system properties from url/file
URL url = makeURL(getopt.getOptarg());
Properties props = System.getProperties();
props.load(url.openConnection().getInputStream());
break;
}
I think that case statement needs to do the things that the case '-b' does and
that case 'u' does - based on what properties were loaded from that file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6582
days inactive
6588
days old
3 comments
2 participants
participants (2)
-
John Mazzitelli (JIRA) -
Raja (JIRA)