[JBoss JIRA] Created: (JBRULES-1050) Extra space between variable and field name in LHS causes crash
8:05 a.m.
Extra space between variable and field name in LHS causes crash
---------------------------------------------------------------
Key: JBRULES-1050
URL: http://jira.jboss.com/jira/browse/JBRULES-1050
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.0.0.GA
Reporter: Alexandre Gattiker
Assigned To: Mark Proctor
Writing a condition as "$co:Item(attachment in ($c, $c. parent))" fails at
runtime with an uninformative exception. Removing the extra space and writing
"$c.parent" corrects the problem.
Below is the rule file, sample code and exception trace.
package com.sample
import com.sample.DroolsTest.Child;
import com.sample.DroolsTest.Parent;
import com.sample.DroolsTest.Item;
rule "My Rule"
when
$c:Child()
$co:Item(attachment in ($c, $c. parent))
then
System.out.println("wawa");
end
package com.sample;
import java.io.InputStreamReader;
import java.io.Reader;
import org.drools.RuleBase;
import org.drools.RuleBaseFactory;
import org.drools.WorkingMemory;
import org.drools.compiler.PackageBuilder;
import org.drools.event.DebugWorkingMemoryEventListener;
import org.drools.rule.Package;
/**
* This is a sample file to launch a rule package from a rule source file.
*/
public class DroolsTest {
public static final void main(String[] args) {
try {
RuleBase ruleBase = readRule();
} catch (Throwable t) {
t.printStackTrace();
}
}
private static RuleBase readRule() throws Exception {
Reader source = new InputStreamReader(DroolsTest.class
.getResourceAsStream("/Sample.drl"));
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(source);
Package pkg = builder.getPackage();
RuleBase ruleBase = RuleBaseFactory.newRuleBase();
ruleBase.addPackage(pkg);
return ruleBase;
}
public static class Parent {
}
public static class Child {
private Parent parent;
public Parent getParent() {
return parent;
}
}
public static class Item {
private Object attachment;
public Object getAttachment() {
return attachment;
}
}
}
java.lang.NullPointerException
at org.drools.reteoo.builder.PatternBuilder.createConstraints(PatternBuilder.java:128)
at org.drools.reteoo.builder.PatternBuilder.attachPattern(PatternBuilder.java:72)
at org.drools.reteoo.builder.PatternBuilder.build(PatternBuilder.java:54)
at
org.drools.reteoo.builder.GroupElementBuilder$AndBuilder.build(GroupElementBuilder.java:112)
at org.drools.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:70)
at org.drools.reteoo.builder.ReteooRuleBuilder.addSubRule(ReteooRuleBuilder.java:136)
at org.drools.reteoo.builder.ReteooRuleBuilder.addRule(ReteooRuleBuilder.java:109)
at org.drools.reteoo.ReteooBuilder.addRule(ReteooBuilder.java:116)
at org.drools.reteoo.ReteooRuleBase.addRule(ReteooRuleBase.java:262)
at org.drools.common.AbstractRuleBase.addPackage(AbstractRuleBase.java:333)
at com.sample.DroolsTest.readRule(DroolsTest.java:33)
at com.sample.DroolsTest.main(DroolsTest.java:20)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9 a.m.
New subject: [JBoss JIRA] Commented: (JBRULES-1050) Extra space between variable and field name in LHS causes crash
[ http://jira.jboss.com/jira/browse/JBRULES-1050?page=comments#action_12370567 ]
Alexandre Gattiker commented on JBRULES-1050:
---------------------------------------------
The proposed workaround actually fails upon inserting a fact. Here is an illustration,
with slightly modified code and rule:
java.lang.NullPointerException
at
org.drools.rule.AbstractCompositeRestriction$CompositeContextEntry.updateFromTuple(AbstractCompositeRestriction.java:112)
at
org.drools.common.SingleBetaConstraints.updateFromTuple(SingleBetaConstraints.java:93)
at org.drools.reteoo.JoinNode.assertTuple(JoinNode.java:115)
at
org.drools.reteoo.SingleTupleSinkAdapter.createAndPropagateAssertTuple(SingleTupleSinkAdapter.java:55)
at org.drools.reteoo.LeftInputAdapterNode.assertObject(LeftInputAdapterNode.java:131)
at
org.drools.reteoo.SingleObjectSinkAdapter.propagateAssertObject(SingleObjectSinkAdapter.java:20)
at org.drools.reteoo.ObjectTypeNode.assertObject(ObjectTypeNode.java:168)
at org.drools.reteoo.Rete.assertObject(Rete.java:168)
at org.drools.reteoo.ReteooRuleBase.assertObject(ReteooRuleBase.java:190)
at org.drools.reteoo.ReteooWorkingMemory.doInsert(ReteooWorkingMemory.java:70)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:848)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:822)
at org.drools.common.AbstractWorkingMemory.insert(AbstractWorkingMemory.java:623)
at com.sample.DroolsTest.main(DroolsTest.java:27)
package com.sample
import com.sample.DroolsTest.Child;
import com.sample.DroolsTest.Parent;
import com.sample.DroolsTest.Item;
rule "My Rule"
when
$c:Child($cparent: parent)
$co:Item(attachment in ($c, $cparent))
then
System.out.println("wawa");
end
package com.sample;
import java.io.InputStreamReader;
import java.io.Reader;
import org.drools.RuleBase;
import org.drools.RuleBaseFactory;
import org.drools.WorkingMemory;
import org.drools.compiler.PackageBuilder;
import org.drools.event.DebugWorkingMemoryEventListener;
import org.drools.rule.Package;
/**
* This is a sample file to launch a rule package from a rule source file.
*/
public class DroolsTest {
public static final void main(String[] args) {
try {
RuleBase ruleBase = readRule();
WorkingMemory workingMemory = ruleBase.newStatefulSession();
workingMemory
.addEventListener(new DebugWorkingMemoryEventListener());
// go !
Child child = new Child();
workingMemory.insert(child);
workingMemory.fireAllRules();
} catch (Throwable t) {
t.printStackTrace();
}
}
private static RuleBase readRule() throws Exception {
Reader source = new InputStreamReader(DroolsTest.class
.getResourceAsStream("/Sample.drl"));
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(source);
Package pkg = builder.getPackage();
RuleBase ruleBase = RuleBaseFactory.newRuleBase();
ruleBase.addPackage(pkg);
return ruleBase;
}
public static class Parent {
}
public static class Child {
private Parent parent;
public Parent getParent() {
return parent;
}
}
public static class Item {
private Object attachment;
public Object getAttachment() {
return attachment;
}
}
}
Extra space between variable and field name in LHS causes crash
---------------------------------------------------------------
Key: JBRULES-1050
URL: http://jira.jboss.com/jira/browse/JBRULES-1050
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.0.GA
Reporter: Alexandre Gattiker
Assigned To: Mark Proctor
Writing a condition as "$co:Item(attachment in ($c, $c. parent))" fails at
runtime with an uninformative exception. Removing the extra space and writing
"$c.parent" corrects the problem.
Below is the rule file, sample code and exception trace.
package com.sample
import com.sample.DroolsTest.Child;
import com.sample.DroolsTest.Parent;
import com.sample.DroolsTest.Item;
rule "My Rule"
when
$c:Child()
$co:Item(attachment in ($c, $c. parent))
then
System.out.println("wawa");
end
package com.sample;
import java.io.InputStreamReader;
import java.io.Reader;
import org.drools.RuleBase;
import org.drools.RuleBaseFactory;
import org.drools.WorkingMemory;
import org.drools.compiler.PackageBuilder;
import org.drools.event.DebugWorkingMemoryEventListener;
import org.drools.rule.Package;
/**
* This is a sample file to launch a rule package from a rule source file.
*/
public class DroolsTest {
public static final void main(String[] args) {
try {
RuleBase ruleBase = readRule();
} catch (Throwable t) {
t.printStackTrace();
}
}
private static RuleBase readRule() throws Exception {
Reader source = new InputStreamReader(DroolsTest.class
.getResourceAsStream("/Sample.drl"));
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(source);
Package pkg = builder.getPackage();
RuleBase ruleBase = RuleBaseFactory.newRuleBase();
ruleBase.addPackage(pkg);
return ruleBase;
}
public static class Parent {
}
public static class Child {
private Parent parent;
public Parent getParent() {
return parent;
}
}
public static class Item {
private Object attachment;
public Object getAttachment() {
return attachment;
}
}
}
java.lang.NullPointerException
at org.drools.reteoo.builder.PatternBuilder.createConstraints(PatternBuilder.java:128)
at org.drools.reteoo.builder.PatternBuilder.attachPattern(PatternBuilder.java:72)
at org.drools.reteoo.builder.PatternBuilder.build(PatternBuilder.java:54)
at
org.drools.reteoo.builder.GroupElementBuilder$AndBuilder.build(GroupElementBuilder.java:112)
at org.drools.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:70)
at org.drools.reteoo.builder.ReteooRuleBuilder.addSubRule(ReteooRuleBuilder.java:136)
at org.drools.reteoo.builder.ReteooRuleBuilder.addRule(ReteooRuleBuilder.java:109)
at org.drools.reteoo.ReteooBuilder.addRule(ReteooBuilder.java:116)
at org.drools.reteoo.ReteooRuleBase.addRule(ReteooRuleBase.java:262)
at org.drools.common.AbstractRuleBase.addPackage(AbstractRuleBase.java:333)
at com.sample.DroolsTest.readRule(DroolsTest.java:33)
at com.sample.DroolsTest.main(DroolsTest.java:20)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:23 p.m.
New subject: [JBoss JIRA] Assigned: (JBRULES-1050) Extra space between variable and field name in LHS causes crash
[ http://jira.jboss.com/jira/browse/JBRULES-1050?page=all ]
Edson Tirelli reassigned JBRULES-1050:
--------------------------------------
Assignee: Edson Tirelli (was: Mark Proctor)
Extra space between variable and field name in LHS causes crash
---------------------------------------------------------------
Key: JBRULES-1050
URL: http://jira.jboss.com/jira/browse/JBRULES-1050
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.0.GA
Reporter: Alexandre Gattiker
Assigned To: Edson Tirelli
Writing a condition as "$co:Item(attachment in ($c, $c. parent))" fails at
runtime with an uninformative exception. Removing the extra space and writing
"$c.parent" corrects the problem.
Below is the rule file, sample code and exception trace.
package com.sample
import com.sample.DroolsTest.Child;
import com.sample.DroolsTest.Parent;
import com.sample.DroolsTest.Item;
rule "My Rule"
when
$c:Child()
$co:Item(attachment in ($c, $c. parent))
then
System.out.println("wawa");
end
package com.sample;
import java.io.InputStreamReader;
import java.io.Reader;
import org.drools.RuleBase;
import org.drools.RuleBaseFactory;
import org.drools.WorkingMemory;
import org.drools.compiler.PackageBuilder;
import org.drools.event.DebugWorkingMemoryEventListener;
import org.drools.rule.Package;
/**
* This is a sample file to launch a rule package from a rule source file.
*/
public class DroolsTest {
public static final void main(String[] args) {
try {
RuleBase ruleBase = readRule();
} catch (Throwable t) {
t.printStackTrace();
}
}
private static RuleBase readRule() throws Exception {
Reader source = new InputStreamReader(DroolsTest.class
.getResourceAsStream("/Sample.drl"));
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(source);
Package pkg = builder.getPackage();
RuleBase ruleBase = RuleBaseFactory.newRuleBase();
ruleBase.addPackage(pkg);
return ruleBase;
}
public static class Parent {
}
public static class Child {
private Parent parent;
public Parent getParent() {
return parent;
}
}
public static class Item {
private Object attachment;
public Object getAttachment() {
return attachment;
}
}
}
java.lang.NullPointerException
at org.drools.reteoo.builder.PatternBuilder.createConstraints(PatternBuilder.java:128)
at org.drools.reteoo.builder.PatternBuilder.attachPattern(PatternBuilder.java:72)
at org.drools.reteoo.builder.PatternBuilder.build(PatternBuilder.java:54)
at
org.drools.reteoo.builder.GroupElementBuilder$AndBuilder.build(GroupElementBuilder.java:112)
at org.drools.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:70)
at org.drools.reteoo.builder.ReteooRuleBuilder.addSubRule(ReteooRuleBuilder.java:136)
at org.drools.reteoo.builder.ReteooRuleBuilder.addRule(ReteooRuleBuilder.java:109)
at org.drools.reteoo.ReteooBuilder.addRule(ReteooBuilder.java:116)
at org.drools.reteoo.ReteooRuleBase.addRule(ReteooRuleBase.java:262)
at org.drools.common.AbstractRuleBase.addPackage(AbstractRuleBase.java:333)
at com.sample.DroolsTest.readRule(DroolsTest.java:33)
at com.sample.DroolsTest.main(DroolsTest.java:20)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:25 p.m.
New subject: [JBoss JIRA] Resolved: (JBRULES-1050) Extra space between variable and field name in LHS causes crash
[ http://jira.jboss.com/jira/browse/JBRULES-1050?page=all ]
Edson Tirelli resolved JBRULES-1050.
------------------------------------
Fix Version/s: 4.0.1
Resolution: Done
Fixed.
Changed parser to ignore comments and white spaces when parsing nested accessors paths and
qualified identifiers. Unit test added. Following expression is correctly parsed:
"org . drools/*comment*/\t .Message( text not matches $c#comment\n. property
)\n";
assertEquals( "org.drools.Message",
pat.getObjectType() );
assertEquals( "not matches",
restr.getEvaluator() );
assertEquals( "$c.property",
restr.getText() );
Thanks for reporting and providing test case. Fix will be included in 4.0.1.
Extra space between variable and field name in LHS causes crash
---------------------------------------------------------------
Key: JBRULES-1050
URL: http://jira.jboss.com/jira/browse/JBRULES-1050
Project: JBoss Rules
Issue Type: Bug
Security Level: Public(Everyone can see)
Affects Versions: 4.0.0.GA
Reporter: Alexandre Gattiker
Assigned To: Edson Tirelli
Fix For: 4.0.1
Writing a condition as "$co:Item(attachment in ($c, $c. parent))" fails at
runtime with an uninformative exception. Removing the extra space and writing
"$c.parent" corrects the problem.
Below is the rule file, sample code and exception trace.
package com.sample
import com.sample.DroolsTest.Child;
import com.sample.DroolsTest.Parent;
import com.sample.DroolsTest.Item;
rule "My Rule"
when
$c:Child()
$co:Item(attachment in ($c, $c. parent))
then
System.out.println("wawa");
end
package com.sample;
import java.io.InputStreamReader;
import java.io.Reader;
import org.drools.RuleBase;
import org.drools.RuleBaseFactory;
import org.drools.WorkingMemory;
import org.drools.compiler.PackageBuilder;
import org.drools.event.DebugWorkingMemoryEventListener;
import org.drools.rule.Package;
/**
* This is a sample file to launch a rule package from a rule source file.
*/
public class DroolsTest {
public static final void main(String[] args) {
try {
RuleBase ruleBase = readRule();
} catch (Throwable t) {
t.printStackTrace();
}
}
private static RuleBase readRule() throws Exception {
Reader source = new InputStreamReader(DroolsTest.class
.getResourceAsStream("/Sample.drl"));
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl(source);
Package pkg = builder.getPackage();
RuleBase ruleBase = RuleBaseFactory.newRuleBase();
ruleBase.addPackage(pkg);
return ruleBase;
}
public static class Parent {
}
public static class Child {
private Parent parent;
public Parent getParent() {
return parent;
}
}
public static class Item {
private Object attachment;
public Object getAttachment() {
return attachment;
}
}
}
java.lang.NullPointerException
at org.drools.reteoo.builder.PatternBuilder.createConstraints(PatternBuilder.java:128)
at org.drools.reteoo.builder.PatternBuilder.attachPattern(PatternBuilder.java:72)
at org.drools.reteoo.builder.PatternBuilder.build(PatternBuilder.java:54)
at
org.drools.reteoo.builder.GroupElementBuilder$AndBuilder.build(GroupElementBuilder.java:112)
at org.drools.reteoo.builder.GroupElementBuilder.build(GroupElementBuilder.java:70)
at org.drools.reteoo.builder.ReteooRuleBuilder.addSubRule(ReteooRuleBuilder.java:136)
at org.drools.reteoo.builder.ReteooRuleBuilder.addRule(ReteooRuleBuilder.java:109)
at org.drools.reteoo.ReteooBuilder.addRule(ReteooBuilder.java:116)
at org.drools.reteoo.ReteooRuleBase.addRule(ReteooRuleBase.java:262)
at org.drools.common.AbstractRuleBase.addPackage(AbstractRuleBase.java:333)
at com.sample.DroolsTest.readRule(DroolsTest.java:33)
at com.sample.DroolsTest.main(DroolsTest.java:20)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6733
days inactive
6734
days old
3 comments
2 participants
participants (2)
-
Alexandre Gattiker (JIRA) -
Edson Tirelli (JIRA)