[jbosstools-commits] JBoss Tools SVN: r43076 - trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console.

Author: dgeraskov Date: 2012-08-16 11:00:33 -0400 (Thu, 16 Aug 2012) New Revision: 43076 Modified: trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConfigurationFactory.java trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConnectionProfileUtil.java Log: https://issues.jboss.org/browse/JBIDE-8192 Added information to dead code Modified: trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConfigurationFactory.java =================================================================== --- trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConfigurationFactory.java 2012-08-16 14:46:02 UTC (rev 43075) +++ trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConfigurationFactory.java 2012-08-16 15:00:33 UTC (rev 43076) @@ -131,6 +131,8 @@ } @SuppressWarnings("unused") + // autoConfigureDialect(localCfg); Disabled for now since it causes very looong timeouts for + // non-running databases + i havent been needed until now... private void autoConfigureDialect(Configuration localCfg) { if (localCfg.getProperty(Environment.DIALECT) == null) { String dialect = ConnectionProfileUtil.autoDetectDialect(localCfg.getProperties()); Modified: trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConnectionProfileUtil.java =================================================================== --- trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConnectionProfileUtil.java 2012-08-16 14:46:02 UTC (rev 43075) +++ trunk/hibernatetools/plugins/org.hibernate.eclipse/src/org/hibernate/console/ConnectionProfileUtil.java 2012-08-16 15:00:33 UTC (rev 43076) @@ -115,6 +115,9 @@ try { connection = DriverManager.getConnection(url, user, pass); // SQL Dialect: + //note this code potentially could throw class cast exception + //see https://issues.jboss.org/browse/JBIDE-8192 + //probably when not Hiberante3.5 is used Dialect dialect = DialectFactory.buildDialect(properties, connection); return dialect.toString(); } catch (SQLException e) {