Author: adietish Date: 2010-11-25 14:07:21 -0500 (Thu, 25 Nov 2010) New Revision: 26954 Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/ChangeLog trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/ErrorUtils.java trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVCategoryElement.java trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVImagesCategoryElement.java Log: [JBIDE-7694] revamped synchronization in DeltaCloud Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/ChangeLog =================================================================== --- trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/ChangeLog 2010-11-25 19:06:43 UTC (rev 26953) +++ trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/ChangeLog 2010-11-25 19:07:21 UTC (rev 26954) @@ -1,3 +1,15 @@ +2010-11-25 André Dietisheim <adietish(a)redhat.com&gt; + + * src/org/jboss/tools/internal/deltacloud/ui/wizards/EditCloudConnectionWizard.java (performTest): + fixed NPE + +2010-11-24 adietisheim <adietisheim@adietisheim-thinkpad> + + * src/org/jboss/tools/deltacloud/ui/views/InstanceView.java (.modifyText): + [JBIDE-7694] removed refresh(es) of tableViewer (setInput should be enough), + moved set of current cloud to central method with null-check, + removed clouds collection & replaced by fresh fetch in DeltaCloudManager + 2010-11-23 André Dietisheim <adietish(a)redhat.com&gt; * src/org/jboss/tools/internal/deltacloud/ui/wizards/NewCloudConnectionWizard.java Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/ErrorUtils.java =================================================================== --- trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/ErrorUtils.java 2010-11-25 19:06:43 UTC (rev 26953) +++ trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/ErrorUtils.java 2010-11-25 19:07:21 UTC (rev 26954) @@ -15,7 +15,6 @@ import org.eclipse.core.runtime.IStatus; import org.eclipse.jface.dialogs.ErrorDialog; -import org.eclipse.swt.widgets.Display; import org.eclipse.swt.widgets.Shell; import org.jboss.tools.common.log.StatusFactory; import org.jboss.tools.deltacloud.core.DeltaCloudMultiException; @@ -38,13 +37,13 @@ } } - private static IStatus openErrorDialog(final String title, final IStatus status, final Shell shell) { - Display.getDefault().syncExec(new Runnable() { - public void run() { - ErrorDialog.openError(shell, title, status.getMessage(), status); - } - }); - return status; + private static void openErrorDialog(final String title, final IStatus status, final Shell shell) { +// Display.getDefault().syncExec(new Runnable() { +// public void run() { +// ErrorDialog.openError(shell, title, status.getMessage(), status); +// } +// }); + ErrorDialog.openError(shell, title, status.getMessage(), status); } public static IStatus createMultiStatus(DeltaCloudMultiException throwable) { Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVCategoryElement.java =================================================================== --- trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVCategoryElement.java 2010-11-25 19:06:43 UTC (rev 26953) +++ trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVCategoryElement.java 2010-11-25 19:07:21 UTC (rev 26954) @@ -59,7 +59,7 @@ } protected void refresh() { - Display.getDefault().asyncExec(new Runnable() { + Display.getDefault().syncExec(new Runnable() { @Override public void run() { IStructuredSelection oldSelection = (IStructuredSelection) viewer.getSelection(); Modified: trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVImagesCategoryElement.java =================================================================== --- trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVImagesCategoryElement.java 2010-11-25 19:06:43 UTC (rev 26953) +++ trunk/deltacloud/plugins/org.jboss.tools.deltacloud.ui/src/org/jboss/tools/deltacloud/ui/views/CVImagesCategoryElement.java 2010-11-25 19:07:21 UTC (rev 26954) @@ -13,7 +13,6 @@ import java.util.ArrayList; import org.eclipse.jface.viewers.TreeViewer; -import org.eclipse.swt.widgets.Display; import org.jboss.tools.deltacloud.core.DeltaCloud; import org.jboss.tools.deltacloud.core.DeltaCloudImage; import org.jboss.tools.deltacloud.core.IImageFilter; @@ -79,7 +78,7 @@ ErrorUtils.handleError( "Error", "Colud not get images from cloud " + cloud.getName(), - e, Display.getDefault().getActiveShell()); + e, getViewer().getControl().getShell()); } } return super.getChildren();