JBoss Rich Faces SVN: r7880 - in trunk/ui: inplaceSelect/src/main/config/component and 1 other directory.
by richfaces-svn-commits@lists.jboss.org
Author: artdaw
Date: 2008-04-16 12:58:13 -0400 (Wed, 16 Apr 2008)
New Revision: 7880
Modified:
trunk/ui/inplaceInput/src/main/config/component/inplaceinput.xml
trunk/ui/inplaceSelect/src/main/config/component/inplaceselect.xml
Log:
http://jira.jboss.com/jira/browse/RF-1226 - "value" attribute description was rewritten
Modified: trunk/ui/inplaceInput/src/main/config/component/inplaceinput.xml
===================================================================
--- trunk/ui/inplaceInput/src/main/config/component/inplaceinput.xml 2008-04-16 16:57:27 UTC (rev 7879)
+++ trunk/ui/inplaceInput/src/main/config/component/inplaceinput.xml 2008-04-16 16:58:13 UTC (rev 7880)
@@ -269,11 +269,6 @@
</property>
&html_events;
&ui_input_attributes;
- <property>
- <name>value</name>
- <classname>java.lang.Object</classname>
- <description>A value-binding expression for the current value of the component</description>
- </property>
<property hidden="true">
<name>localValueSet</name>
<classname>boolean</classname>
Modified: trunk/ui/inplaceSelect/src/main/config/component/inplaceselect.xml
===================================================================
--- trunk/ui/inplaceSelect/src/main/config/component/inplaceselect.xml 2008-04-16 16:57:27 UTC (rev 7879)
+++ trunk/ui/inplaceSelect/src/main/config/component/inplaceselect.xml 2008-04-16 16:58:13 UTC (rev 7880)
@@ -297,7 +297,6 @@
&html_events;
&ui_component_attributes;
&ui_input_attributes;
-
<property hidden="true" existintag="false" exist="false" >
<name>localValueSet</name>
<classname>boolean</classname>
16 years, 9 months
JBoss Rich Faces SVN: r7879 - trunk/ui/inplaceInput/src/main/resources/org/richfaces/renderkit/html/scripts.
by richfaces-svn-commits@lists.jboss.org
Author: abelevich
Date: 2008-04-16 12:57:27 -0400 (Wed, 16 Apr 2008)
New Revision: 7879
Modified:
trunk/ui/inplaceInput/src/main/resources/org/richfaces/renderkit/html/scripts/inplaceinput.js
Log:
http://jira.jboss.com/jira/browse/RF-3072
Modified: trunk/ui/inplaceInput/src/main/resources/org/richfaces/renderkit/html/scripts/inplaceinput.js
===================================================================
--- trunk/ui/inplaceInput/src/main/resources/org/richfaces/renderkit/html/scripts/inplaceinput.js 2008-04-16 16:56:30 UTC (rev 7878)
+++ trunk/ui/inplaceInput/src/main/resources/org/richfaces/renderkit/html/scripts/inplaceinput.js 2008-04-16 16:57:27 UTC (rev 7879)
@@ -475,6 +475,9 @@
case "right" :
bs.left = inpWidth + "px";
break;
+ case "center" :
+ bs.left = inpWidth + "px";
+ break;
}
}
}
16 years, 9 months
JBoss Rich Faces SVN: r7878 - trunk/ui/componentControl/src/main/config/component.
by richfaces-svn-commits@lists.jboss.org
Author: artdaw
Date: 2008-04-16 12:56:30 -0400 (Wed, 16 Apr 2008)
New Revision: 7878
Modified:
trunk/ui/componentControl/src/main/config/component/componentControl.xml
Log:
http://jira.jboss.com/jira/browse/RF-3100 - "attachTiming" attribute description was rewritten
Modified: trunk/ui/componentControl/src/main/config/component/componentControl.xml
===================================================================
--- trunk/ui/componentControl/src/main/config/component/componentControl.xml 2008-04-16 16:54:23 UTC (rev 7877)
+++ trunk/ui/componentControl/src/main/config/component/componentControl.xml 2008-04-16 16:56:30 UTC (rev 7878)
@@ -103,7 +103,7 @@
<name>attachTiming</name>
<classname>java.lang.String</classname>
<description>
- Defines an Id of a component or HTML element listened by the control component
+ Defines the page loading phase when componentControl is attached to another component
</description>
<defaultvalue>"onavailable"</defaultvalue>
</property>
16 years, 9 months
JBoss Rich Faces SVN: r7877 - in trunk/docs/migrationguide/en/src/main/docbook: included and 1 other directories.
by richfaces-svn-commits@lists.jboss.org
Author: artdaw
Date: 2008-04-16 12:54:23 -0400 (Wed, 16 Apr 2008)
New Revision: 7877
Added:
trunk/docs/migrationguide/en/src/main/docbook/included/
trunk/docs/migrationguide/en/src/main/docbook/included/i18n.xml
trunk/docs/migrationguide/en/src/main/docbook/modules/req.xml
trunk/docs/migrationguide/en/src/main/docbook/modules/scope.xml
Modified:
trunk/docs/migrationguide/en/src/main/docbook/master.xml
Log:
http://jira.jboss.com/jira/browse/RF-3048 - Scope of the document, Minimum requirements for the project with RichFaces 3.2.0, The RichFaces Migration Issues and 'non-ASCII characters in application with i18n' sections were added
Added: trunk/docs/migrationguide/en/src/main/docbook/included/i18n.xml
===================================================================
--- trunk/docs/migrationguide/en/src/main/docbook/included/i18n.xml (rev 0)
+++ trunk/docs/migrationguide/en/src/main/docbook/included/i18n.xml 2008-04-16 16:54:23 UTC (rev 7877)
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<section>
+ <sectioninfo>
+ <keywordset>
+ <keyword>i18n</keyword>
+ <keyword>internationalization</keyword>
+ </keywordset>
+ </sectioninfo>
+ <title>non-ASCII characters in application with i18n</title>
+ <section>
+ <title>Description</title>
+ <para>
+ Application with i18n does not work correctly caused by the validation error when non-ASCII characters is used
+ </para>
+ </section>
+ <section>
+ <title>Links</title>
+ <itemizedlist>
+ <listitem>
+ <para>
+ <ulink url="http://jira.jboss.com/jira/browse/RF-2962 ">Jira</ulink>
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <ulink url="http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4141302#...">RichFaces Forum</ulink>
+ </para>
+ </listitem>
+ </itemizedlist>
+ </section>
+ <section>
+ <title>How to reproduce</title>
+ <programlisting role="XML"><![CDATA[...
+<select id="j_id27:cbxUser" name="j_id27:cbxUser" size="1" style="width:120px">
+ <option value="Al Korbeli& #269;o">Al Korbeli& #269;o</option>
+ <option value="Al Nagyov& aacute;">Al Nagyov& aacute;</option>
+ <option value="Al Tothov& aacute;">Al Tothov& aacute;</option>
+ <option value="An Gajdov& aacute;">An Gajdov& aacute;</option>
+ ...
+</select>
+]]></programlisting>
+ </section>
+ <section>
+ <title>Causes</title>
+ <para>
+ Bug (came with <emphasis role="bold"><property><rich:fileUpload></property></emphasis> component)
+ </para>
+ </section>
+
+ <section>
+ <title>Workarounds</title>
+ <para>
+ The decision is to upgrade to <ulink url=" http://www.jboss.org/jbossrichfaces/downloads/">RichFaces 3.2.0 SP1</ulink>
+ </para>
+ </section>
+
+</section>
\ No newline at end of file
Modified: trunk/docs/migrationguide/en/src/main/docbook/master.xml
===================================================================
--- trunk/docs/migrationguide/en/src/main/docbook/master.xml 2008-04-16 16:21:07 UTC (rev 7876)
+++ trunk/docs/migrationguide/en/src/main/docbook/master.xml 2008-04-16 16:54:23 UTC (rev 7877)
@@ -3,6 +3,9 @@
"http://www.oasis-open.org/docbook/xml/4.3CR3/docbookx.dtd" [
<!ENTITY intro SYSTEM "modules/intro.xml">
<!ENTITY scope SYSTEM "modules/scope.xml">
+ <!ENTITY req SYSTEM "modules/req.xml">
+
+ <!ENTITY i18n SYSTEM "included/i18n.xml">
]>
<book>
<bookinfo>
@@ -12,9 +15,22 @@
<holder>Red Hat</holder>
</copyright>
</bookinfo>
+
<toc/>
- &intro;
- &scope;
-
+ &intro;
+ &scope;
+ &req;
+ <chapter role="NotInToc" id="RichFacesMigrationIssues" xreflabel="RichFacesMigrationIssues">
+ <?dbhtml filename="RichFacesMigrationIssues.html"?>
+
+ <title>The RichFaces Migration Issues</title>
+ <para>
+ This chapter includes only the issue with migration from previous versions to 3.2.0.
+ Issues with new components and other problems are not included.
+ The <ulink url="http://jira.jboss.com/jira/browse/RF">Jira</ulink> contains everything.
+ </para>
+
+ &i18n;
+ </chapter>
</book>
Added: trunk/docs/migrationguide/en/src/main/docbook/modules/req.xml
===================================================================
--- trunk/docs/migrationguide/en/src/main/docbook/modules/req.xml (rev 0)
+++ trunk/docs/migrationguide/en/src/main/docbook/modules/req.xml 2008-04-16 16:54:23 UTC (rev 7877)
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<chapter id="req" xreflabel="req">
+ <?dbhtml filename="scope.html"?>
+ <chapterinfo>
+ <keywordset>
+ <keyword>RichFaces</keyword>
+ <keyword>Migration Guide</keyword>
+ <keyword>requirements</keyword>
+ </keywordset>
+ </chapterinfo>
+
+ <title>Minimum requirements for the project with RichFaces 3.2.0</title>
+ <para>
+ You can find all technical requirements to start working with <property>RichFaces 3.2.0</property>
+ in the <ulink url="http://www.jboss.org/jbossrichfaces/docs/index.html">Developer Guide</ulink>.
+ </para>
+
+</chapter>
+
Added: trunk/docs/migrationguide/en/src/main/docbook/modules/scope.xml
===================================================================
--- trunk/docs/migrationguide/en/src/main/docbook/modules/scope.xml (rev 0)
+++ trunk/docs/migrationguide/en/src/main/docbook/modules/scope.xml 2008-04-16 16:54:23 UTC (rev 7877)
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<chapter id="scope" xreflabel="scope">
+ <?dbhtml filename="scope.html"?>
+ <chapterinfo>
+ <keywordset>
+ <keyword>RichFaces</keyword>
+ <keyword>Migration Guide</keyword>
+ <keyword>scope</keyword>
+ </keywordset>
+ </chapterinfo>
+
+ <title>Scope of the document</title>
+
+ <itemizedlist>
+ <listitem>
+ <para>
+ This document should not be used as a tutorial for <property>RichFaces</property> framework
+ since it is created to describe the issues caused by migration process
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ It is assumed that you are familiar with basic tenets of <property>RichFaces</property> framework.
+ If you are newbie in <property>RichFaces</property> you can find
+ <property>RichFaces</property> documentation <ulink url="http://www.jboss.org/jbossrichfaces/docs/index.html">here</ulink>.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ Concepts related to Web or application servers configuration is beyond the scope of this document
+ </para>
+ </listitem>
+ </itemizedlist>
+
+</chapter>
16 years, 9 months
JBoss Rich Faces SVN: r7876 - in trunk/ui/combobox/src/main: resources/org/richfaces/renderkit/html/scripts and 1 other directories.
by richfaces-svn-commits@lists.jboss.org
Author: abelevich
Date: 2008-04-16 12:21:07 -0400 (Wed, 16 Apr 2008)
New Revision: 7876
Modified:
trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java
trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/combobox.js
trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js
trunk/ui/combobox/src/main/templates/combobox.jspx
Log:
http://jira.jboss.com/jira/browse/RF-2956
Modified: trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java
===================================================================
--- trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2008-04-16 15:27:42 UTC (rev 7875)
+++ trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2008-04-16 16:21:07 UTC (rev 7876)
@@ -15,7 +15,6 @@
import org.ajax4jsf.javascript.JSFunctionDefinition;
import org.ajax4jsf.javascript.ScriptUtils;
import org.ajax4jsf.renderkit.HeaderResourcesRendererBase;
-import org.ajax4jsf.renderkit.RendererUtils;
import org.ajax4jsf.renderkit.RendererUtils.HTML;
import org.ajax4jsf.util.InputUtils;
import org.ajax4jsf.util.SelectUtils;
Modified: trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/combobox.js
===================================================================
--- trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/combobox.js 2008-04-16 15:27:42 UTC (rev 7875)
+++ trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/combobox.js 2008-04-16 16:21:07 UTC (rev 7876)
@@ -31,13 +31,12 @@
this.comboList = new Richfaces.ComboBoxList(listId, parentListId, selectFirstOnUpdate, classes.COMBO_LIST, listWidth,
listHeight, itemsText, onlistcall, fieldId, shadowId, showDelay, hideDelay);
this.defaultMessage = defaultMessage;
- // TODO: should we move this logic to the template?
- // http://jira.jboss.com/jira/browse/RF-2956
if (value) {
var item = this.comboList.findItemBySubstr(value);
if (item) {
this.comboList.doSelectItem(item);
- this.comboValue.value = item.innerHTML.unescapeHTML();
+// initialize moved to the template http://jira.jboss.com/jira/browse/RF-2956
+// this.comboValue.value = item.innerHTML.unescapeHTML();
}
} else {
if (this.defaultMessage) {
Modified: trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js
===================================================================
--- trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js 2008-04-16 15:27:42 UTC (rev 7875)
+++ trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js 2008-04-16 16:21:07 UTC (rev 7876)
@@ -1,9 +1,33 @@
if (!window.Richfaces) window.Richfaces = {};
+if (!window.RichComboUtils) window.RichComboUtils = {};
Richfaces.defined = function(o) {
return (typeof(o)!="undefined");
};
+RichComboUtils.execOnLoad = function(func, condition, timeout) {
+
+ if (condition()) {
+ func();
+ } else {
+ window.setTimeout(
+ function() {
+ RichComboUtils.execOnLoad(func, condition, timeout);
+ },
+ timeout
+ );
+ }
+};
+
+RichComboUtils.Condition = {
+ ElementPresent : function(element) {
+ return function () {
+ var el = $(element);
+ return el && el.offsetHeight > 0;
+ };
+ }
+};
+
Richfaces.getBody = function() {
if (document.body) {
return document.body;
Modified: trunk/ui/combobox/src/main/templates/combobox.jspx
===================================================================
--- trunk/ui/combobox/src/main/templates/combobox.jspx 2008-04-16 15:27:42 UTC (rev 7875)
+++ trunk/ui/combobox/src/main/templates/combobox.jspx 2008-04-16 16:21:07 UTC (rev 7876)
@@ -205,7 +205,7 @@
<div id="#{clientId}">
<div id="#{clientId}combobox" class="rich-combobox-font rich-combobox #{styleClass}" style="width:#{listWidth};#{style}"
x:passThruWithExclusions="value,name,type,id,styleClass,class,style,size,autocomplete,disabled,onchange">
- <input id="#{clientId}comboboxValue" name="#{clientId}" type="hidden"/>
+
<div class="rich-combobox-list-cord"></div>
<div class="rich-combobox-font rich-combobox-shell" style="width:#{width};z-index:1;">
<input id="#{clientId}comboboxField"
@@ -258,9 +258,25 @@
</div>
</div>
</div>
+ <jsp:scriptlet>
+ <![CDATA[
+
+ String hiddenValue = null;
+ if (items.contains(value)) {
+ variables.setVariable("hiddenValue", value);
+ }
+
+ ]]>
+ </jsp:scriptlet>
+ <input id="#{clientId}comboboxValue" name="#{clientId}" type="hidden" value="#{hiddenValue}"/>
+
+
</div>
<script type="text/javascript">
+
+ var clientId = '#{clientId}';
+ RichComboUtils.execOnLoad( function(){
Richfaces.ComboBox.CLASSES = {
BUTTON : {CLASSES :
{NORMAL : "rich-combobox-font-inactive rich-combobox-button-icon-inactive rich-combobox-button-inactive #{buttonInactiveClass}",
@@ -320,6 +336,7 @@
"#{defaultLabel}",
#{disabled}, #{convertedValue},
#{component.attributes["showDelay"]}, #{component.attributes["hideDelay"]});
+ }, RichComboUtils.Condition.ElementPresent("#{clientId}"), 100);
</script>
</div>
</f:root>
\ No newline at end of file
16 years, 9 months
JBoss Rich Faces SVN: r7875 - branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts.
by richfaces-svn-commits@lists.jboss.org
Author: pyaschenko
Date: 2008-04-16 11:27:42 -0400 (Wed, 16 Apr 2008)
New Revision: 7875
Modified:
branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
Log:
http://jira.jboss.com/jira/browse/RF-3090
Modified: branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
===================================================================
--- branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 15:24:09 UTC (rev 7874)
+++ branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 15:27:42 UTC (rev 7875)
@@ -866,6 +866,9 @@
},
isWithin : function(event){
+ //RF-2745 explicitly extend event to make DOM methods work
+ event = Event.extend(event);
+
var within = true;
var targetElement = event.relatedTarget;
16 years, 9 months
JBoss Rich Faces SVN: r7874 - branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts.
by richfaces-svn-commits@lists.jboss.org
Author: pyaschenko
Date: 2008-04-16 11:24:09 -0400 (Wed, 16 Apr 2008)
New Revision: 7874
Modified:
branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
Log:
http://jira.jboss.com/jira/browse/RF-3071
Modified: branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
===================================================================
--- branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 14:07:45 UTC (rev 7873)
+++ branches/3.1.x/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 15:24:09 UTC (rev 7874)
@@ -868,7 +868,9 @@
isWithin : function(event){
var within = true;
var targetElement = event.relatedTarget;
- while (targetElement.nodeType!=1) targetElement = targetElement.parentNode;
+
+ while (targetElement && targetElement.nodeType!=1) targetElement = targetElement.parentNode;
+
var srcElement = event.target;
var layer = $(this.id);
if (targetElement) {
@@ -1201,7 +1203,7 @@
var within = false;
Event.extend(event);
var targetElement = event.relatedTarget;
- while (targetElement.nodeType!=1) targetElement = targetElement.parentNode;
+ while (targetElement && targetElement.nodeType!=1) targetElement = targetElement.parentNode;
if (targetElement) {
within = targetElement == element ||
16 years, 9 months
JBoss Rich Faces SVN: r7873 - trunk/ui/progressBAR/src/main/java/org/richfaces/renderkit.
by richfaces-svn-commits@lists.jboss.org
Author: andrei_exadel
Date: 2008-04-16 10:07:45 -0400 (Wed, 16 Apr 2008)
New Revision: 7873
Modified:
trunk/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java
Log:
fix component
Modified: trunk/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java
===================================================================
--- trunk/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java 2008-04-16 13:19:45 UTC (rev 7872)
+++ trunk/ui/progressBAR/src/main/java/org/richfaces/renderkit/AbstractProgressBarRenderer.java 2008-04-16 14:07:45 UTC (rev 7873)
@@ -84,11 +84,10 @@
*/
public String getForcedState(FacesContext context, UIComponent component) {
String forcedState = null;
- Map params = context.getExternalContext().getRequestParameterMap();
+ Map<String, String> params = context.getExternalContext()
+ .getRequestParameterMap();
if (params.containsKey(UIProgressBar.FORCE_PERCENT_PARAM)) {
- String[] str = (String[]) params
- .get(UIProgressBar.FORCE_PERCENT_PARAM);
- forcedState = str[0];
+ forcedState = params.get(UIProgressBar.FORCE_PERCENT_PARAM);
}
return forcedState;
}
16 years, 9 months
JBoss Rich Faces SVN: r7872 - trunk/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts.
by richfaces-svn-commits@lists.jboss.org
Author: pyaschenko
Date: 2008-04-16 09:19:45 -0400 (Wed, 16 Apr 2008)
New Revision: 7872
Modified:
trunk/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
Log:
http://jira.jboss.com/jira/browse/RF-3071
Modified: trunk/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js
===================================================================
--- trunk/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 12:43:36 UTC (rev 7871)
+++ trunk/ui/menu-components/src/main/resources/org/richfaces/renderkit/html/scripts/menu.js 2008-04-16 13:19:45 UTC (rev 7872)
@@ -1203,7 +1203,7 @@
Event.extend(event);
var targetElement = event.relatedTarget;
- while (targetElement.nodeType!=1) targetElement = targetElement.parentNode;
+ while (targetElement && targetElement.nodeType!=1) targetElement = targetElement.parentNode;
if (targetElement) {
within = targetElement == element ||
16 years, 9 months
JBoss Rich Faces SVN: r7871 - trunk/ui/inplaceSelect/src/main/java/org/richfaces/renderkit.
by richfaces-svn-commits@lists.jboss.org
Author: abelevich
Date: 2008-04-16 08:43:36 -0400 (Wed, 16 Apr 2008)
New Revision: 7871
Modified:
trunk/ui/inplaceSelect/src/main/java/org/richfaces/renderkit/InplaceSelectBaseRenderer.java
Log:
http://jira.jboss.com/jira/browse/RF-3069
Modified: trunk/ui/inplaceSelect/src/main/java/org/richfaces/renderkit/InplaceSelectBaseRenderer.java
===================================================================
--- trunk/ui/inplaceSelect/src/main/java/org/richfaces/renderkit/InplaceSelectBaseRenderer.java 2008-04-16 12:39:18 UTC (rev 7870)
+++ trunk/ui/inplaceSelect/src/main/java/org/richfaces/renderkit/InplaceSelectBaseRenderer.java 2008-04-16 12:43:36 UTC (rev 7871)
@@ -120,8 +120,7 @@
protected String getItemLabel(FacesContext context, UIComponent component, Object value) {
String itemLabel = null;
- // TODO: SelectUtils.getSelectItems is called minimum twice during
- // encode
+ // TODO: SelectUtils.getSelectItems is called minimum twice during encode
List<SelectItem> selectItems = SelectUtils.getSelectItems(context, component);
if (!selectItems.isEmpty()) {
for (SelectItem item : selectItems) {
@@ -133,7 +132,7 @@
}
if (itemLabel == null) {
- throw new IllegalArgumentException("passed value is incorrect");
+ itemLabel = createDefaultLabel(component);
}
return itemLabel;
16 years, 9 months