Author: maksimkaszynski Date: 2008-04-10 05:00:00 -0400 (Thu, 10 Apr 2008) New Revision: 7728 Modified: trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js Log: code reviewed Modified: trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java =================================================================== --- trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2008-04-10 08:58:09 UTC (rev 7727) +++ trunk/ui/combobox/src/main/java/org/richfaces/renderkit/ComboBoxBaseRenderer.java 2008-04-10 09:00:00 UTC (rev 7728) @@ -131,10 +131,7 @@ } protected boolean isAcceptableComponent(UIComponent component) { - if (component instanceof UIComboBox) { - return true; - } - return false; + return component != null && this.getComponentClass().isAssignableFrom(component.getClass()); } public String getItemsTextAsJSArray(FacesContext context, UIComponent component, List items) { Modified: trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js =================================================================== --- trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js 2008-04-10 08:58:09 UTC (rev 7727) +++ trunk/ui/combobox/src/main/resources/org/richfaces/renderkit/html/scripts/comboboxUtils.js 2008-04-10 09:00:00 UTC (rev 7728) @@ -68,7 +68,7 @@ } return val; } - +//TODO: jsDoc this Satanism Richfaces.borders = {l: 'border-left-width', r: 'border-right-width', t: 'border-top-width', b: 'border-bottom-width'}, Richfaces.paddings = {l: 'padding-left', r: 'padding-right', t: 'padding-top', b: 'padding-bottom'}, Richfaces.margins = {l: 'margin-left', r: 'margin-right', t: 'margin-top', b: 'margin-bottom'} \ No newline at end of file