[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4203) Interpolator swallows all exceptions
by Yuriy Lazarev (JIRA)
Interpolator swallows all exceptions
------------------------------------
Key: JBSEAM-4203
URL: https://jira.jboss.org/jira/browse/JBSEAM-4203
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.1.2.CR1
Environment: Any
Reporter: Yuriy Lazarev
org.jboss.seam.core.Interpolator swallows all exceptions, so if I have #{entityHome.instance.name} somewere in the page, and entityHome has id which is missed from database - I expect that org.jboss.seam.framework.EntityNotFoundException will be handled by this block in pages.xml
<exception class = "org.jboss.seam.framework.EntityNotFoundException">
<redirect view-id = "/error.xhtml">
<message severity = "warn">#{messages['org.jboss.seam.framework.EntityNotFoundException']}</message>
</redirect>
</exception>
but, instead I got
[WARN] exception interpolating string: #{entityHome.instance.name}
This is due
Interpolator.java:131
} catch (Exception e) {
log.warn("exception interpolating string: " + string, e);
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 10 months
[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4413) Date format error in .page.xml params when having custom date pattern
by Julien Kronegg (JIRA)
Date format error in .page.xml params when having custom date pattern
---------------------------------------------------------------------
Key: JBSEAM-4413
URL: https://jira.jboss.org/jira/browse/JBSEAM-4413
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.GA
Environment: Seam 2.1.2.GA, DB2
http://fisheye.jboss.org/browse/Seam/branches/community/Seam_2_1/src/main...
Reporter: Julien Kronegg
Priority: Minor
The java.util.Date passed by <param> tags in the .page.xml file are converted from Date to String for the GET request, using the date format defined in the last used rich:calendar. Then, the GET parameters are converted back from String to Date using the default date format which may not be the same as the one defined in the rich:calendar. This results in date conversion errors such as "value must be a date, eg. 10/13/2008".
The issue is fully described with an example in http://seamframework.org/Community/DateFormatErrorInPagexmlParamsASeamIssue
To correct this issue, the org.jboss.seam.navigation.Param should use its own date converter instead of sharing the converter with other JSF components (in other words, the Param class should use a technical date converter). This requires the following steps:
1) define a org.jboss.seam.faces.DateParamConverter date converter with a selectable date format defaulted to "yyyyMMddHHmmssSSS"
2) change the org.jboss.seam.navigation.Param class to use a the DateParamConverter converter if the param value is java.util.Date, else, use the converters registered in JSF. This is done by changing:
Class<?> type = valueExpression.getType();
if (type==null)
{
return null;
}
return FacesContext.getCurrentInstance().getApplication().createConverter(type);
by
Class<?> type = valueExpression.getType();
if (type==null)
{
return null;
}
+ if (type.equals(Date.class)) {
+ return org.jboss.seam.faces.DateParamConverter.getInstance(); // return an instance of the technical converter, to be created
+ } else {
return FacesContext.getCurrentInstance().getApplication().createConverter(type);
+ }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 10 months
[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4325) ResourceLoader, moving from JBoss 4 to JBoss 5, page level messages.properties not workin any more.
by Riccardo Serafin (JIRA)
ResourceLoader, moving from JBoss 4 to JBoss 5, page level messages.properties not workin any more.
---------------------------------------------------------------------------------------------------
Key: JBSEAM-4325
URL: https://jira.jboss.org/jira/browse/JBSEAM-4325
Project: Seam
Issue Type: Feature Request
Components: Core, Documentation Issues
Reporter: Riccardo Serafin
Fix For: 2.2.1.CR1
We have moved our app from JBoss 4.2.3 to 5.1 and our page level messages.properties stopped to work correctly. After analyzing the issue, we traced the problem to the ResourceLoader loadBundle method which uses the getContextClassloader to load the bundles. In out app, the .properties files where located in the WAR root along with the faceltes .xhtml and the .page.xml, which use to work fine on 4.2.3. It is my understanding that with 5.1 the classloader has changed, and the one retrieved via getContextClassloader does not have access to the ServletContext anymore, hence our properties file are not found any more.
So, I suggest two things:
1) The documentation makes it explicit that the messages.properties file should be localed in WEB-INF/classes. The explanation for the page level messages.properties is instead a bit more open to interpretation. It could be good to reiterate there that also page level files need to go into WEB-INF/classes
2) Or, modify ResourceLoader to scan also the ServletContext for bundle files, which would make it compatible with apps that used to work on JBoss 4.2.3. Notice that the other ResourceLoader methods already use ServletLifecycle.getServletContext(), that is why .page.xml files can be nicely placed along .xhtml file in the context root.
Thanks,
Riccardo.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 10 months