[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4190) RewriteFilter is Non-deterministic
by John Gilbert (JIRA)
RewriteFilter is Non-deterministic
----------------------------------
Key: JBSEAM-4190
URL: https://jira.jboss.org/jira/browse/JBSEAM-4190
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.1.GA
Reporter: John Gilbert
The RewriteFilter is non-deterministic in some cases. An example serves best.
Here are the rewrite rules I would like:
/Customer/edit/{id} -> /jsf/Customer/Edit.xhtml
/Customer/create -> /jsf/Customer/Edit.xhtml
/Customer/{id} -> /jsf/Customer/View.xhtml
When debugging the value of RewriteFilter.getAllPatterns(), the order of the two rules for /jsf/Customer/Edit.xhtml are always preserved.
However, because Pages.getKnownViewIds() returns a HashSet there is no guarantee that the rules for /jsf/Customer/View.xhtml will come after the rules for /jsf/Customer/Edit.xhtml. As a result, /Customer/create sometimes translates to /jsf/Customer/View.xhtml when /jsf/Customer/View.xhtml is returned first in the set.
There are several possible solutions:
1) Change /Customer/{id} to /Customer/view/{id}. However, this is not the best url for a View.
2) Change Pages.pagesByViewId to a TreeMap. This is the patch I am currently using, but it is only guaranteed for my patterns.
3) Change RewriteFilter.getAllPatterns() to returns a TreeSet sorted from longest to shortest. This is similar to the way Pages.wildcardViewIds works.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 11 months
[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4209) StringIndexOutOfBoundsException in RedirectHandler
by Nicko Cadell (JIRA)
StringIndexOutOfBoundsException in RedirectHandler
--------------------------------------------------
Key: JBSEAM-4209
URL: https://jira.jboss.org/jira/browse/JBSEAM-4209
Project: Seam
Issue Type: Bug
Affects Versions: 2.1.2.CR2
Reporter: Nicko Cadell
StringIndexOutOfBoundsException in RedirectHandler
This exception is thrown if ViewExpiredException is thown and I'm hndling this with a redirect back to the same page: i.e. my exception config looks like:
{code}
<exception class="javax.faces.application.ViewExpiredException">
<redirect />
</exception>
{code}
AND I am using the <web:rewrite-filter /> to rewrite the URLs.
The code in RedirectHandler assumes that the request servlet path will contain a URL that matches up to one of the view by changing the file extension. This is not always the case. In this case the RewriteFilter is intercepting the path, which does not contain a .seam extension.
The following exception is thrown:
{code}
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1938)
at org.jboss.seam.exception.RedirectHandler.handle(RedirectHandler.java:39)
at org.jboss.seam.exception.Exceptions.handle(Exceptions.java:76)
at org.jboss.seam.web.ExceptionFilter.endWebRequestAfterException(ExceptionFilter.java:114)
at org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:70)
at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
at org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:178)
at org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:290)
at org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:368)
at org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:495)
at org.jboss.seam.web.Ajax4jsfFilter.doFilter(Ajax4jsfFilter.java:56)
at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
at org.jboss.seam.web.LoggingFilter.doFilter(LoggingFilter.java:60)
at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
at org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:73)
at org.jboss.seam.servlet.SeamFilter.doFilter(SeamFilter.java:158)
{code}
It looks like the RewriteFilter process() method does have some commented out code to wrap the request so that the call to getServletPath() would return the rewritten URL (i.e. something that could be converted to a view id by the RedirectHandler). I assume that the wrapped request was commented out to resolve some other issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 11 months
[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1841) Need examples/documentation for how to use seamgen generated EntityHome interefaces and related functionality
by steve tynor (JIRA)
Need examples/documentation for how to use seamgen generated EntityHome interefaces and related functionality
-------------------------------------------------------------------------------------------------------------
Key: JBSEAM-1841
URL: http://jira.jboss.com/jira/browse/JBSEAM-1841
Project: JBoss Seam
Issue Type: Feature Request
Components: Documentation
Affects Versions: 2.0.0.BETA1
Reporter: steve tynor
Please add some documentation, perhaps an example project, that uses seamgen-generated EntityHome classes in order to demonstrate the intended use of the wire(), isWired(), createInstance(), getDefinedInstance(), setId(), etc. functions. Some discussion on how these related to <param> and <f:param> in XHTML is also needed.
As it stands, these are completely undocumented without any explanation of their intended use, so those of us that have boostrapped a project with seamgen, have no guidance on how to maintian these classes as our application changes (new properties added to entities, etc.)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years, 11 months