3:18 p.m.
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:20 p.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-51:
---------------------------------
I really like the idea of using the binding annotations for service handlers...that makes
them just like interceptor bindings, so that should be easier for people to understand in
the long run.
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Stuart Douglas commented on SOLDER-51:
--------------------------------------
If we used the binding approach it would also open up the possibility of a chain of
servicehandlers. Not sure how ordering would work though.
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:14 p.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-51:
---------------------------------
For ordering, I'd use the same approach as with interceptors, you order them in XML
(via Seam Config). Unlike interceptors, though, I like the idea of enabling them by
default and only if you order them, do you control them enabled or not (empty element
disables all).
<service-handlers>
<class>...</class>
</service-handlers>
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:05 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-51:
---------------------------------
I would suggest we just do what interceptors do here. I know that the interceptors
enabling/ordering problem is a major one, however given that we intend to fix this in CDI
1.1, anything we do here will likely have to be aligned to that later on. IOW consistency
is most important here.
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:45 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-51:
---------------------------------
Got it, makes sense.
What's interesting is that CDI made a point about introducing a new type of
interceptor, a decorator. We'll, thanks to you guys, we've got a second type that
was previously missing :)
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 a.m.
New subject: [JBoss JIRA] Updated: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Dan Allen updated SOLDER-51:
----------------------------
Priority: Critical (was: Major)
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Priority: Critical
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:37 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-51) Decouple service handler annotation from implementation class
[
https://issues.jboss.org/browse/SOLDER-51?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-51:
---------------------------------
The service handler should get "bound" to the type using the same strategy as is
used for interceptor binding.
Binding type:
{code:java}
@Target({ METHOD, TYPE })
@Retention(RetentionPolicy.RUNTIME)
@ServiceHandlerBindingType
public @interface EchoService {}
{code}
Invocation handler:
{code:java}
@ServiceHandlerBindingType
@EchoService
public class EchoServiceHandler {
@AroundInvoke
public Object invoke(InvocationContext ctx) {
return ctx.getMethod().getName().toString();
}
}
{code}
Usage:
{code:java}
@EchoService
public interface HelloWorld {
String helloWorld();
}
{code}
Decouple service handler annotation from implementation class
-------------------------------------------------------------
Key: SOLDER-51
URL: https://issues.jboss.org/browse/SOLDER-51
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
The current design of the service handler configuration prevents modules from being able
to deliver a service annotation in the api since it requires a direct reference to the
implementation class.
@ServiceHandler(MyServiceHandler.class)
Switch to either a string or adopt the annotation binding concept from CDI (like
interceptors)
Also, support the use of the service handler annotation on stereotypes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4979
days inactive
5082
days old
7 comments
3 participants
participants (3)
-
Dan Allen (JIRA) -
Pete Muir (JIRA)
-
Stuart Douglas (JIRA)