3:13 a.m.
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:27 a.m.
New subject: [JBoss JIRA] Work started: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Work on SEAMVALIDATE-7 started by Gunnar Morling.
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:39 p.m.
New subject: [JBoss JIRA] Commented: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling commented on SEAMVALIDATE-7:
-------------------------------------------
I'm not sure I understand what you mean by "it is not possible for a thirdparty
extension to wrap these metadata during container startup". Could you give an
example/scenario for this? Would the current approach make certain use cases impossible,
or is this more a performance related issue (repeated retrieval of meta data etc.)?
I already tested the suggested version and it works as expected, I just want to make sure
I know what's going on :-)
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:04 a.m.
New subject: [JBoss JIRA] Commented: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Jozef Hartinger commented on SEAMVALIDATE-7:
--------------------------------------------
Gunnar,
the ConstraintValidators deployed in a Bean Deployment Archive (BDA) that fulfill CDI
constraints (not final classes, appropriate constructor, etc...) are CDI beans. The
container scans for these during bootstrap, creates the AnnotatedType and InjectionTarget
metadata for each found CDI bean and lets CDI extensions manipulate these metadata by
observing and manipulating bootstrap events (e.g. ProcessAnnotatedType,
ProcessInjectionTarget, etc...)
Example usecases:
* An extension may for example want to add a qualifier to the bean (i.e. configuring the
ConstraintValidator via the Seam Config extension). = wrapping AnnotatedType
* An extension may want to provide additional dependency injection options (i.e. besides
support for @Inject, an extension may provide JAX-RS injection which is triggered by
@Context) - this would be implemented by listening to the ProcessInjectionTarget of every
bean and wrapping this InjectionTarget instance that contains the dependency injection
logic implemented in the inject() method
* others...
The result of extension's metadata manipulation stays stored within the container and
influences how the beans behave. Therefore, if you extract the bean metadata from scratch
(the ConstraintValidator class only) on every instance creation, the metadata created
during container bootstrap is never used and the bean can no longer be manipulated by CDI
extensions.
Besides, performance is probably also an issue since you force the container to create the
AnnotatedType and InjectionTarget every time.
So instead of creating bean metadata every time, simpy ask the container for an instance
of a particular type as shown above.
Hope this makes sense. Should you have further questions don't hesitate to ask.
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:41 a.m.
New subject: [JBoss JIRA] Commented: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling commented on SEAMVALIDATE-7:
-------------------------------------------
Jozef,
thanks for your clear explanation, that definitly makes sense. I tried out your approach
and saw that it only works for constraint validator types defined in a BDA (which is to be
expected of course as types not defined in a BDA won't be processed by the CDI
container).
So for other constraint validators (for example the ones defined by Hibernate Validator
itself which does not come in form of a BDA) I'll fall back to the standard factory.
That means that for validators not defined in a BDA injection won't work (opposed to
the current implementation where this is possible as the meta data is retrieved locally in
the factory), but this just seems logical to me. WDYT?
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 a.m.
New subject: [JBoss JIRA] Commented: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Jozef Hartinger commented on SEAMVALIDATE-7:
--------------------------------------------
That's a good point which I missed completely. You should check with the BeanManager
to see if it is able to provide an instance of a particular type. If it's not, the
instance creation should be delegated to the default factory. This is how we do in the
resteasy-cdi module
http://resteasy.svn.sourceforge.net/viewvc/resteasy/trunk/jaxrs/resteasy-...
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
New subject: [JBoss JIRA] Commented: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling commented on SEAMVALIDATE-7:
-------------------------------------------
Right, that's exactly the way I've implemented it now
(https://github.com/gunnarmorling/validation/commit/a000e11626983bad27eafa...).
Thanks again for pointing out that issue.
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:26 p.m.
New subject: [JBoss JIRA] Updated: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling updated SEAMVALIDATE-7:
--------------------------------------
Status: Resolved (was: Pull Request Sent)
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:26 p.m.
New subject: [JBoss JIRA] Updated: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling updated SEAMVALIDATE-7:
--------------------------------------
Status: Pull Request Sent (was: Coding In Progress)
Git Pull Request: https://github.com/seam/validation/pull/9
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:28 p.m.
New subject: [JBoss JIRA] Closed: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling closed SEAMVALIDATE-7.
-------------------------------------
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
New subject: [JBoss JIRA] Closed: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling closed SEAMVALIDATE-7.
-------------------------------------
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
New subject: [JBoss JIRA] Reopened: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling reopened SEAMVALIDATE-7:
---------------------------------------
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
New subject: [JBoss JIRA] Resolved: (SEAMVALIDATE-7) ConstraintValidator instances created incorrectly
[
https://issues.jboss.org/browse/SEAMVALIDATE-7?page=com.atlassian.jira.pl...
]
Gunnar Morling resolved SEAMVALIDATE-7.
---------------------------------------
Resolution: Done
ConstraintValidator instances created incorrectly
-------------------------------------------------
Key: SEAMVALIDATE-7
URL: https://issues.jboss.org/browse/SEAMVALIDATE-7
Project: Seam Validation
Issue Type: Bug
Affects Versions: 3.0.0.CR1
Reporter: Jozef Hartinger
Assignee: Gunnar Morling
Priority: Critical
Fix For: 3.0.0.Final
The current way of creating a ConstraintValidator instance is not correct:
{code}
AnnotatedType<T> type = beanManager.createAnnotatedType(key);
InjectionTarget<T> it = beanManager.createInjectionTarget(type);
CreationalContext<T> ctx = beanManager.createCreationalContext(null);
T instance = it.produce(ctx);
it.inject(instance, ctx);
it.postConstruct(instance);
return instance;
{code}
Since an AnnotatedType and InjectionTarget are created for every ConstraintValidator
creation, it is not possible for a thirdparty extension to wrap these metadata during
container startup. The correct way of creating a ConstraintValidator instance would be:
{code}
Set<Bean<?>> beans = beanManager.getBeans(key);
Bean<?> bean = beanManager.resolve(beans);
CreationalContext<?> ctx = beanManager.createCreationalContext(bean);
return (T) beanManager.getReference(bean, key, ctx);
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
5545
days inactive
5556
days old
12 comments
2 participants
participants (2)
-
Gunnar Morling (JIRA) -
Jozef Hartinger (JIRA)