January 2012 - seam-issues - Jboss List Archives

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-4487) Concurrent requests; one invalidates the session, results in recursive loop of session creation

by dave atkins (JIRA)

Concurrent requests; one invalidates the session, results in recursive loop of session creation ----------------------------------------------------------------------------------------------- Key: JBSEAM-4487 URL: https://jira.jboss.org/jira/browse/JBSEAM-4487 Project: Seam Issue Type: Bug Components: Core Affects Versions: 2.2.0.GA, 2.2.0.CR1, 2.1.2.GA, 2.1.2.CR2, 2.1.2.CR1, 2.1.1.GA Environment: Jboss 4.2.2 with shipped Tomcat on Linux. Reporter: dave atkins I noticed that we had an massive number of sessions on one of our tomcat nodes that hosts our modest Seam app. After some investigation I discovered this in the log 2009-11-25 17:38:02,521 INFO [org.jboss.seam.contexts.Contexts] starting up: org.jboss.seam.web.session 2009-11-25 17:38:02,522 INFO [org.jboss.seam.contexts.Contexts] starting up: org.jboss.seam.security.identity 2009-11-25 17:38:02,522 INFO [org.jboss.seam.contexts.Contexts] starting up: org.jboss.seam.web.session 2009-11-25 17:38:02,522 INFO [org.jboss.seam.contexts.Contexts] starting up: org.jboss.seam.security.identity 2009-11-25 17:38:02,522 INFO [org.jboss.seam.contexts.Contexts] starting up: org.jboss.seam.web.session This is repeated for thousands of lines. After digging around the seam code I realised that if you have two concurrent requests and one invalidates the session before the other is finished, seam goes into an recursive loop of session creation (normally ended by stack overflow). Here's a stack trace showing two recursions. at org.jboss.seam.Component.newInstance(Component.java:2094) at org.jboss.seam.contexts.Contexts.startup(Contexts.java:304) at org.jboss.seam.contexts.Contexts.startup(Contexts.java:278) at org.jboss.seam.contexts.Lifecycle.beginSession(Lifecycle.java:209) at org.jboss.seam.contexts.ServletLifecycle.beginSession(ServletLifecycle.java:141) at org.jboss.seam.servlet.SeamListener.sessionCreated(SeamListener.java:45) at org.apache.catalina.session.StandardSession.tellNew(StandardSession.java:397) at org.apache.catalina.session.StandardSession.setId(StandardSession.java:369) at org.apache.catalina.session.ManagerBase.createSession(ManagerBase.java:828) at org.apache.catalina.session.StandardManager.createSession(StandardManager.java:291) at org.apache.catalina.connector.Request.doGetSession(Request.java:2312) at org.apache.catalina.connector.Request.getSession(Request.java:2075) at org.apache.catalina.connector.RequestFacade.getSession(RequestFacade.java:833) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at org.apache.catalina.core.ApplicationHttpRequest.getSession(ApplicationHttpRequest.java:545) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at com.sun.faces.context.SessionMap.getSession(ExternalContextImpl.java:1002) at com.sun.faces.context.SessionMap.get(ExternalContextImpl.java:962) at org.jboss.seam.contexts.ServerConversationContext.get(ServerConversationContext.java:110) at org.jboss.seam.contexts.Contexts.lookupInStatefulContexts(Contexts.java:189) at org.jboss.seam.Component.getInstance(Component.java:1949) at org.jboss.seam.Component.getInstance(Component.java:1944) at org.jboss.seam.Component.getInstance(Component.java:1924) at org.jboss.seam.Component.getInstance(Component.java:1919) at org.jboss.seam.security.Identity.create(Identity.java:101) at sun.reflect.GeneratedMethodAccessor2896.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.seam.util.Reflections.invoke(Reflections.java:22) at org.jboss.seam.util.Reflections.invokeAndWrap(Reflections.java:144) at org.jboss.seam.Component.callComponentMethod(Component.java:2211) at org.jboss.seam.Component.callCreateMethod(Component.java:2134) at org.jboss.seam.Component.newInstance(Component.java:2094) at org.jboss.seam.contexts.Contexts.startup(Contexts.java:304) at org.jboss.seam.contexts.Contexts.startup(Contexts.java:278) at org.jboss.seam.contexts.Lifecycle.beginSession(Lifecycle.java:209) at org.jboss.seam.contexts.ServletLifecycle.beginSession(ServletLifecycle.java:141) at org.jboss.seam.servlet.SeamListener.sessionCreated(SeamListener.java:45) at org.apache.catalina.session.StandardSession.tellNew(StandardSession.java:397) at org.apache.catalina.session.StandardSession.setId(StandardSession.java:369) at org.apache.catalina.session.ManagerBase.createSession(ManagerBase.java:828) at org.apache.catalina.session.StandardManager.createSession(StandardManager.java:291) at org.apache.catalina.connector.Request.doGetSession(Request.java:2312) at org.apache.catalina.connector.Request.getSession(Request.java:2075) at org.apache.catalina.connector.RequestFacade.getSession(RequestFacade.java:833) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at org.apache.catalina.core.ApplicationHttpRequest.getSession(ApplicationHttpRequest.java:545) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:216) at com.sun.faces.context.SessionMap.getSession(ExternalContextImpl.java:1002) at com.sun.faces.context.SessionMap.get(ExternalContextImpl.java:962) at org.jboss.seam.contexts.ServerConversationContext.get(ServerConversationContext.java:110) at org.jboss.seam.contexts.Contexts.lookupInStatefulContexts(Contexts.java:189) at org.jboss.seam.Component.getInstance(Component.java:1949) at org.jboss.seam.Component.getInstance(Component.java:1944) at org.jboss.seam.Component.getInstance(Component.java:1924) at org.jboss.seam.Component.getInstance(Component.java:1919) at org.jboss.seam.security.Identity.create(Identity.java:101) at sun.reflect.GeneratedMethodAccessor2896.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.seam.util.Reflections.invoke(Reflections.java:22) at org.jboss.seam.util.Reflections.invokeAndWrap(Reflections.java:144) at org.jboss.seam.Component.callComponentMethod(Component.java:2211) at org.jboss.seam.Component.callCreateMethod(Component.java:2134) at org.jboss.seam.Component.newInstance(Component.java:2094) This problem is partially documented here - https://jira.jboss.org/jira/browse/JBSEAM-2888, unfortunately this bugfix didn't solve the root cause of the problem. The problem is caused by the SessionMap used by ServerConversationContext. Internally the session map uses HttpServletRequest.getSession(true) to retrieve the session, which creates a new session if the one defined on the HttpServletRequest is invalid or null. Unfortunately, when the new session is created session listeners are informed before the session has been set on the HttpServletRequest. Seam is one of these session listeners and creates a new Identity on session creation, which in turn accesses the SessionMap, still before the new Session has been set on the request. This leads to an infinite recursive loop. The SessionMap used is returned by externalContext.getSessionMap(). One solution could be to implement our own SessionMap that doesn't attempt to create a new session if the current session is invalid or null, although I've no idea how this would impact on other Seam code. The problem is relatively easy to create. In our application we have a search page that can take quite a while to complete a request. If we log out of the application in another tab before the search has completed the problem arises. We are using seam 2.1.1.GA. I've looked at the source code for the latest release and it appears that the problem will still occur due to use of SessionMap. Out current workaround is to add a ThreadLocal to Identity.create that counts recursive calls. If more then two recursive calls are detected an IllegalProcessState exception is thrown. This isn't definitely isn't a permanent solution, but stops our server creating 100,000 sessions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

7
18
0 / 0

[JBoss JIRA] (JBSEAM-4876) Use JPA 2 API

by Pete Muir (JIRA)

Pete Muir created JBSEAM-4876: --------------------------------- Summary: Use JPA 2 API Key: JBSEAM-4876 URL: https://issues.jboss.org/browse/JBSEAM-4876 Project: Seam 2 Issue Type: Sub-task Reporter: Pete Muir Fix For: 2.3.0.Final -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

2
3
0 / 0

[JBoss JIRA] (JBSEAM-4872) Support JBoss AS 7.1

by Pete Muir (JIRA)

Pete Muir created JBSEAM-4872: --------------------------------- Summary: Support JBoss AS 7.1 Key: JBSEAM-4872 URL: https://issues.jboss.org/browse/JBSEAM-4872 Project: Seam 2 Issue Type: Sub-task Reporter: Pete Muir Fix For: 2.3.0.Final There is no requirement to support older JBoss AS releases -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

2
2
0 / 0

[JBoss JIRA] (JBSEAM-4879) Verify Seam 2.3 works in JBDS 5

by Pete Muir (JIRA)

Pete Muir created JBSEAM-4879: --------------------------------- Summary: Verify Seam 2.3 works in JBDS 5 Key: JBSEAM-4879 URL: https://issues.jboss.org/browse/JBSEAM-4879 Project: Seam 2 Issue Type: Sub-task Reporter: Pete Muir Co-ordinate with JBDS to assist with testing and reporting issues. JBDS team will do fixes to JBDS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

2
4
0 / 0

[JBoss JIRA] (JBSEAM-4886) Non Java EE 6 / JBoss AS 7 critical issues

by Pete Muir (JIRA)

Pete Muir created JBSEAM-4886: --------------------------------- Summary: Non Java EE 6 / JBoss AS 7 critical issues Key: JBSEAM-4886 URL: https://issues.jboss.org/browse/JBSEAM-4886 Project: Seam 2 Issue Type: Sub-task Reporter: Pete Muir Fix For: 2.3.0.Final -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

2
2
0 / 0

[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3857) Include in docs a entity manager transaction flush behavior

by Rodrigo Souto (JIRA)

Include in docs a entity manager transaction flush behavior ----------------------------------------------------------- Key: JBSEAM-3857 URL: https://jira.jboss.org/jira/browse/JBSEAM-3857 Project: Seam Issue Type: Task Components: Documentation Issues, EJB3 Affects Versions: 2.1.1.CR1 Environment: documentation Reporter: Rodrigo Souto Priority: Optional Explain on reference doc (chapter 9.3. Seam-managed persistence contexts) that even if you are using a manual flush mode in your session bean, a transaction is flushed before any query. http://www.seamframework.org/Community/WhyEjbFunctionIsTryingToFlush -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

2
6
0 / 0

[JBoss JIRA] (JBSEAM-4862) Seam Remoting GWT support not being skipped in AS 7.0.2

by Joshua Davis (Created) (JIRA)

Seam Remoting GWT support not being skipped in AS 7.0.2 ------------------------------------------------------- Key: JBSEAM-4862 URL: https://issues.jboss.org/browse/JBSEAM-4862 Project: Seam 2 Issue Type: Bug Environment: JBoss AS 7.0.2.Final EAR deployment of Seam 2.2.0 Reporter: Joshua Davis When deploying a Seam 2.2.0 EAR in JBoss AS 7.0.2.Final, the Seam Remoting GWT support components are not disabled in a nice way. Seam's scanner is trying to instantiate these components, even though the GWT classes are not available, resulting in a {{java.lang.LinkageError}}. * The application is deployed as an EAR. * {{jboss-seam.jar}} is in the root directory of the EAR, and is declared as an EJB module in {{META-INF/application.xml}}. * {{jboss-seam-remoting.jar}} is in the {{lib}} directory of the EAR, along with all the other Seam 2 jars. When JBoss AS 7 is deploying the application, the Seam 2 scanner is looking for components in {{lib/jboss-seam-remoting.jar}}. It finds {{GWT14Service}} and {{GWTToSeamAdapter}}, _even though_ these two components are declared with {{@Install(..., classDependencies= ...)}}. Removing the the {{org.jboss.seam.remoting.gwt}} package from {{jboss-seam-remoting.jar}} made the problem go away. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

6
15
0 / 0

[JBoss JIRA] (JBSEAM-4865) Upgrade Richfaces to 4.1.0.Final for JSF2 support

by Marek Novotny (JIRA)

Marek Novotny created JBSEAM-4865: ------------------------------------- Summary: Upgrade Richfaces to 4.1.0.Final for JSF2 support Key: JBSEAM-4865 URL: https://issues.jboss.org/browse/JBSEAM-4865 Project: Seam 2 Issue Type: Task Reporter: Marek Novotny JSF 2 support requires higher version of RIchfaces than 3.3.3.Final. Even it supports JSF2, this is only with jsf-facelets, and JSF2 VDL turn off. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

3
11
0 / 0

[JBoss JIRA] (JBSEAM-4858) Migrate integration testsuite to Arquillian from JBoss Embedded

by Marek Novotny (Created) (JIRA)

Migrate integration testsuite to Arquillian from JBoss Embedded --------------------------------------------------------------- Key: JBSEAM-4858 URL: https://issues.jboss.org/browse/JBSEAM-4858 Project: Seam 2 Issue Type: Task Components: Test Harness Reporter: Marek Novotny We need to provide flexible and modern test suite. JBoss Embedded Legacy is very old project and not maintained now. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

4
4
0 / 0

[JBoss JIRA] (JBSEAM-4859) Create Arquillian integration

by Marek Novotny (Created) (JIRA)

Create Arquillian integration ----------------------------- Key: JBSEAM-4859 URL: https://issues.jboss.org/browse/JBSEAM-4859 Project: Seam 2 Issue Type: Feature Request Reporter: Marek Novotny Provide at least the same integration like JBoss Embedded has got for fast and flexible testing of Seam 2 components. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 3 months

4
3
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

seam-issues January 2012