[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2982) Give MultipartRequest constructor to support unit testing
[ http://jira.jboss.com/jira/browse/JBSEAM-2982?page=comments#action_12412533 ]
Shane Bryzak commented on JBSEAM-2982:
--------------------------------------
The constructor for MultipartRequest shouldn't do any parsing at all. The request
content is only parsed when you call one of the getParam*() methods. I don't see how
adding another constructor will help here (and the super constructor, which requires an
HttpServletRequest parameter must still be invoked anyway).
Give MultipartRequest constructor to support unit testing
---------------------------------------------------------
Key: JBSEAM-2982
URL: http://jira.jboss.com/jira/browse/JBSEAM-2982
Project: Seam
Issue Type: Feature Request
Components: Core
Affects Versions: 2.1.0.A1, 2.0.1.GA
Environment: N/A
Reporter: Tom N
Assigned To: Shane Bryzak
Fix For: 2.1.0.BETA1
MultipartRequest cannot easily be mocked for unit testing. This could be solved by (1)
making that type into an interface, or (2) changing the constructor so that the wrapped
HttpServletRequest body is not parsed when the constructor is invoked. See the forum link
for more details.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira