[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1719) UrlBuilder doesnt construct a correct url when the base url already has request params in place.

UrlBuilder doesnt construct a correct url when the base url already has request params in place. ------------------------------------------------------------------------------------------------ Key: JBSEAM-1719 URL: http://jira.jboss.com/jira/browse/JBSEAM-1719 Project: JBoss Seam Issue Type: Bug Components: Core Affects Versions: 2.0.0.BETA1 Reporter: Chris Rudd Assigned To: Pete Muir Fix For: 2.0.0.CR1 Given the following test case : @Test public void testBaseUrlAlreadyHasParams() { UrlBuilder url = new UrlBuilder("/someurl?arg1=a", ""); url.addParameter("foo", "bar"); String encodedUrl = url.getEncodedUrl(); Assert.assertEqual( encodedUrl, "/someurl?arg1=a&foo=bar" ); } The following patch fixes the issue. UrlBuilder.java line 62 protected String getParametersAsString() { String params = ""; for (String key : parameters.keySet()) { params += "&" + key + "=" + parameters.get(key); } - if (!"".equals(params)) + // repace the first "&" with a "?" if there are parameters and the url doesnt already contain a "?" + if (!".equals(params) && (url!=null && !url.contains("?"))) { params = "?" + params.substring(1); } return params; } NOTE: This condition occurs when using <s:link/> in a portlet, as the portlet returns a url with parameters already added to the url.