[jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3729) Recognize HotDeployFilter as a configurable filter in web.xsd
[
https://jira.jboss.org/jira/browse/JBSEAM-3729?page=com.atlassian.jira.pl...
]
Dan Allen commented on JBSEAM-3729:
-----------------------------------
Btw, we might as well wrap up another task into this issue. That is that the
Init#isHotDeployEnabled() should absolutely be checking the value of Init#isDebug() rather
than looking for the resource META-INF/debug.xhtml. The hot deployment has nothing to do
with the presence of the debug.xhtml page. In fact, only the exception handler in Seam
should be looking for debug.xhtml since it actually needs that file to render the page.
This all needs to be made consistent.
Recognize HotDeployFilter as a configurable filter in web.xsd
-------------------------------------------------------------
Key: JBSEAM-3729
URL: https://jira.jboss.org/jira/browse/JBSEAM-3729
Project: Seam
Issue Type: Feature Request
Components: Hot Deploy
Affects Versions: 2.1.0.SP1
Reporter: Dan Allen
Fix For: 2.1.1.CR2
Original Estimate: 1 hour
Remaining Estimate: 1 hour
It's absolutely critical that the HotDeployFilter only be applied to JSF requests or
else the scanning that it does occurs for every related requested by the page. However,
currently none of the XML schemas for the component descriptor recognize this filter as a
configurable element. Here is how it has to be configured now:
<component name="org.jboss.seam.debug.hotDeployFilter">
<property name="urlPattern">*.seam</property>
</component>
I would like to do one of two things.
#1
Change the component name from org.jboss.seam.debug.hotDeployFilter to
org.jboss.seam.web.hotDeployFilter (but still keep it in jboss-seam-debug.jar), then add
the hot-deploy-filter element to web.xsd. We would get this:
<web:hot-deploy-filter url-pattern="*.seam"/>
We could even consider moving this filter into jboss-seam.jar because honestly it is so
lightweight and really has everything to do with the core and is already controlled by the
debug mode flag in Seam.
#2
Keep the component name as is and introduce a new namespace
http://jboss.org/products/seam/debug and a corresponding package-info.java and debug.xsd.
Then add the hot-deploy-filter to debug.xsd. We would get this:
<debug:hot-deploy-filter url-pattern="*.seam"/>
I really hate solution #2. The only redeeming quality is that it doesn't break
applications that might rely on this component name. But then again, it would only affect
debug mode, not production apps.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira