11:55 p.m.
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:55 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347852 ]
Norman Richards commented on JBSEAM-537:
----------------------------------------
Here is a sample stack trace from where a page action fails: (this page action is just an
s:link action)
23:40:58,844 ERROR [PhaseListenerManager] Exception in PhaseListener RENDER_RESPONSE(6)
beforePhase.
javax.faces.el.EvaluationException: Exception while invoking expression
#{out.doSomething}
at org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:153)
at
org.jboss.seam.actionparam.ActionParamBindingHelper.invokeTheExpression(ActionParamBindingHelper.java:59)
at
org.jboss.seam.actionparam.ActionParamMethodBinding.invoke(ActionParamMethodBinding.java:71)
at org.jboss.seam.core.Expressions$2.invoke(Expressions.java:98)
at org.jboss.seam.core.Pages.callAction(Pages.java:394)
at
org.jboss.seam.jsf.AbstractSeamPhaseListener.callPageActions(AbstractSeamPhaseListener.java:253)
at
org.jboss.seam.jsf.AbstractSeamPhaseListener.beforeRender(AbstractSeamPhaseListener.java:201)
at org.jboss.seam.jsf.SeamPhaseListener.beforePhase(SeamPhaseListener.java:51)
at
org.apache.myfaces.lifecycle.PhaseListenerManager.informPhaseListenersBefore(PhaseListenerManager.java:70)
at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:373)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:138)
...
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=all ]
Norman Richards updated JBSEAM-537:
-----------------------------------
Fix Version/s: 1.1.0.CR2
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:10 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347862 ]
Norman Richards commented on JBSEAM-537:
----------------------------------------
I've fixed the immediate problem in AbstractSeamPhaseListener.java by checking to see
if the exception is a handled exception. If it is handled, we don't need to worry
about it. The code rethrows unhandled exceptions, which still will result in the
conversation lock not being released. Gavin - you'll have too look at that condition
and decide how you want to handle it, if you think it is a problem.
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=all ]
Norman Richards reassigned JBSEAM-537:
--------------------------------------
Assignee: Gavin King
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Assigned To: Gavin King
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:15 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347870 ]
Gavin King commented on JBSEAM-537:
-----------------------------------
Are you *sure* this problem occurs when you have SeamExceptionFilter installed?
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Assigned To: Gavin King
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:33 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347873 ]
Gavin King commented on JBSEAM-537:
-----------------------------------
WTF! So you realize you committed some code that just randomly swallows exceptions!? Have
you gone totally crazy, Norm?
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Assigned To: Gavin King
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:40 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=comments#action_12347882 ]
Norman Richards commented on JBSEAM-537:
----------------------------------------
07:37:46,842 ERROR [PhaseListenerManager] Exception in PhaseListener RENDER_RESPONSE(6)
beforePhase.
javax.faces.el.EvaluationException: Exception while invoking expression
#{out.doSomething}
at org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:153)
at
org.jboss.seam.actionparam.ActionParamBindingHelper.invokeTheExpression(ActionParamBindingHelper.java:59)
at
org.jboss.seam.actionparam.ActionParamMethodBinding.invoke(ActionParamMethodBinding.java:71)
at org.jboss.seam.core.Expressions$2.invoke(Expressions.java:98)
at org.jboss.seam.core.Pages.callAction(Pages.java:394)
at
org.jboss.seam.jsf.AbstractSeamPhaseListener.callPageActions(AbstractSeamPhaseListener.java:259)
at
org.jboss.seam.jsf.AbstractSeamPhaseListener.beforeRender(AbstractSeamPhaseListener.java:202)
at org.jboss.seam.jsf.SeamPhaseListener.beforePhase(SeamPhaseListener.java:51)
at
org.apache.myfaces.lifecycle.PhaseListenerManager.informPhaseListenersBefore(PhaseListenerManager.java:70)
at org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:373)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:138)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at org.jboss.seam.servlet.SeamRedirectFilter.doFilter(SeamRedirectFilter.java:32)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.jboss.seam.servlet.SeamExceptionFilter.doFilter(SeamExceptionFilter.java:47)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:175)
at
org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:74)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.jboss.web.tomcat.tc5.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:156)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.MasterSlaveWorkerThread.run(MasterSlaveWorkerThread.java:112)
at java.lang.Thread.run(Thread.java:613)
Caused by: org.jboss.seam.example.seampay.FooException
at org.jboss.seam.example.seampay.Outer.doSomething(Outer.java:18)
at
org.jboss.seam.example.seampay.Outer$$FastClassByCGLIB$$3060f124.invoke(<generated>)
at net.sf.cglib.proxy.MethodProxy.invoke(MethodProxy.java:149)
at
org.jboss.seam.intercept.RootInvocationContext.proceed(RootInvocationContext.java:45)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:55)
at
org.jboss.seam.interceptors.OutcomeInterceptor.interceptOutcome(OutcomeInterceptor.java:23)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.seam.util.Reflections.invoke(Reflections.java:18)
at org.jboss.seam.intercept.Interceptor.aroundInvoke(Interceptor.java:169)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:64)
at
org.jboss.seam.interceptors.RollbackInterceptor.rollbackIfNecessary(RollbackInterceptor.java:33)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.seam.util.Reflections.invoke(Reflections.java:18)
at org.jboss.seam.intercept.Interceptor.aroundInvoke(Interceptor.java:169)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:64)
at
org.jboss.seam.interceptors.BijectionInterceptor.bijectTargetComponent(BijectionInterceptor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.seam.util.Reflections.invoke(Reflections.java:18)
at org.jboss.seam.intercept.Interceptor.aroundInvoke(Interceptor.java:169)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:64)
at
org.jboss.seam.interceptors.ConversationInterceptor.endOrBeginLongRunningConversation(ConversationInterceptor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.seam.util.Reflections.invoke(Reflections.java:18)
at org.jboss.seam.intercept.Interceptor.aroundInvoke(Interceptor.java:169)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:64)
at
org.jboss.seam.interceptors.ExceptionInterceptor.handleExceptions(ExceptionInterceptor.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.seam.util.Reflections.invoke(Reflections.java:18)
at org.jboss.seam.intercept.Interceptor.aroundInvoke(Interceptor.java:169)
at
org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:64)
at
org.jboss.seam.intercept.RootInterceptor.createSeamInvocationContext(RootInterceptor.java:144)
at
org.jboss.seam.intercept.RootInterceptor.invokeInContexts(RootInterceptor.java:129)
at org.jboss.seam.intercept.RootInterceptor.invoke(RootInterceptor.java:102)
at
org.jboss.seam.intercept.JavaBeanInterceptor.interceptInvocation(JavaBeanInterceptor.java:140)
at
org.jboss.seam.intercept.JavaBeanInterceptor.intercept(JavaBeanInterceptor.java:75)
at
org.jboss.seam.example.seampay.Outer$$EnhancerByCGLIB$$e60199b4.doSomething(<generated>)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.apache.myfaces.el.MethodBindingImpl.invoke(MethodBindingImpl.java:129)
... 35 more
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Assigned To: Gavin King
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:29 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-537) conversation lock not unlocked
[ http://jira.jboss.com/jira/browse/JBSEAM-537?page=all ]
Gavin King closed JBSEAM-537.
-----------------------------
Resolution: Done
OK, so exceptions thrown by page actions are *deeply* problematic due to the PhaseListener
exception handling defined by JSF spec. Log and swallow.
conversation lock not unlocked
------------------------------
Key: JBSEAM-537
URL: http://jira.jboss.com/jira/browse/JBSEAM-537
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.1.0.CR2
Reporter: Norman Richards
Assigned To: Gavin King
Fix For: 1.1.0.CR2
If a page action results in an exception, the lock on the ConversationEntry is never
unlocked. If the debug page is called after that, the conversation can only be restored
if the request happens to be on the same thread as the original request. If the
conversation cannot be restored, the conversation state and the last exception will not be
displayed.
Refreshing the page a few times may help because JBoss is likely to cycle through the
threads, ultimately landing the request back on the original thread, allowing the
reentrant lock to be acquired and the conversation restored. I don't entirely
understand the conversation locking strategy, so I can't suggest a fix.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6980
days inactive
6980
days old
8 comments
2 participants
participants (2)
-
Gavin King (JIRA) -
Norman Richards (JIRA)