[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=all ] Pete Muir updated JBSEAM-2148: ------------------------------ Fix Version/s: 2.1.0.GA (was: 2.0.2.GA) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=all ] Norman Richards updated JBSEAM-2148: ------------------------------------ Fix Version/s: 2.1.0.GA (was: 2.1.0.A1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=all ] Pete Muir updated JBSEAM-2148: ------------------------------ Fix Version/s: 2.1.0.GA (was: 2.1.0.BETA1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=comments#action_12413105 ] Pete Muir commented on JBSEAM-2148: ----------------------------------- An alternative syntax could be <s:selectItems value="#{engineTypes}" var="engine" label="#{engine.name}" groupBy="#{engine.manufacturer}" groupByVar="manufacturer" groupByLabel="#{manufacturer.name}"/> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=comments#action_12419321 ] Pete Muir commented on JBSEAM-2148: ----------------------------------- Attribute names: use whatever makes the most sense natural language - the current attribute names aren't very consistent. You probably can just use the existing var object as you say, but make sure it is useable e.g. for Map based data sets. If group takes disabled and escaped, we should support them. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=comments#action_12419902 ] Stephen Friedrich commented on JBSEAM-2148: ------------------------------------------- Oh my, after a good night's sleep: Besides being a little too complex, that solution has a specific issue: You can't easily use <s:selectItems group="Foo" .../> like Pete said in the issue description. Only this would work <s:selectItems group="Foo" groupLabel="Foo" .../> Hm, either make group default to the groupLabel (and vice versa). Or simply remove both "group" and "groupVar" and simply only ever group the items using the label. That would maybe make groupDisabled and groupEscape EL expressions more complex (because they can't refer to the groupVar), but those attributes will probably be used very rarely. I think I'll rework the patch to the latter alternative. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=comments#action_12419910 ] Pete Muir commented on JBSEAM-2148: ----------------------------------- Maybe you can support using both groupVar and var in groupEscape/groupDisabled and hence make groupVar optional? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2148?page=comments#action_12419959 ] Stephen Friedrich commented on JBSEAM-2148: ------------------------------------------- groupVar is already optional, you can use both groupVar and var in groupEscape and groupDisabled (see tag docs). However both "group" and "groupLabel" are required (if you want grouping), which is a little silly when you just want a single, fixed label for all the select items. One possibility would be to make group optional, too. I think it would be simpler to remove both group and groupVar and have only attributes for group label, escape and disabled. (The number of attributes already is a little confusing for the user.) As for the internal structure: Sorry if the code looks somewhat unfamiliar. At first I tried to make do with very little changes only, but it evolved into the current form. The basics and quite a lot of code are still the same, though (converting the value to an Iterable, for each one setting var/groupVar and creating the SelectItem). The main change was caused by the need to create an intermediate representation of each SelectItemGroup (so that SelectItems can be dynamically added to each group) and only convert that to a real SelectItemGroup after iteration is done. I tried to keep the ContextualSelectItem, but that was a problem because the varValue was set/removed only for the creation of the item itself (and wasn't available for the group), and the code was becoming a little convoluted. Plus I found ContextualSelectItem to be unnecessary: Rather than creating an abstract base class, plus a concrete anonymous subclass that overrides accessors to initialize each instance field, you can simply pass the field values to the constructor. When you do that you can just as well use the SelectItem class itself. Well, and honestly speaking, I did not understand the code then as well as I do now... So, please bear with me. I can create a new patch and keep the changes as small as possible at all. I would then create a ContextualSelectItemGroup as a subclass of ContextualSelectItem (like SelectItemGroup is a subclass of SelectItem). The only question then is whether to keep all of "group", "groupVar" and "groupLabel" or only have a single "group" attribute that is used for both logical grouping and as the label (that would also remove the strange (if improbable) edge case where the same group object would give different labels (for example because the groupLabel EL expression accidentally uses the var attribute)). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira