[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=all ] Guy Veraghtert updated JBSEAM-880: ---------------------------------- Attachment: patch-880.txt added described patch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=comments#action_12353486 ] Peter Muir commented on JBSEAM-880: ----------------------------------- I agree an NPE should not be thrown BUT I do think an exception should be thrown if value is null (IllegalArguementException with a decent message). I'm assuming your NPE was off line 155) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=all ] Guy Veraghtert reopened JBSEAM-880: ----------------------------------- I can confirm that an IllegalArgumentException is thrown now. However, I'm reopening this issue, because I don't agree with the choice of throwing an exception, unless this is clearly specified. A production system can "crash" because the flow followed made the value(binding)expression evaluate to null, this may have been overlooked while testing/implementing (question: how can a programmer know that he must check for null-values before returning the value?). This situation is not that severe and a quality component can deal with this easily by rendering, for example, an empty dropdown menu. This is much more informative to an end user than a standard error-page (maybe the user has a screen in which he can enter the data for the dropdown menu). Moverover, complex components like h:dataTable deal with null-values, why shouldn't s:selectItems do that? In my opinion, framework or component classes must prefer a defensive (total) approach and try to recover from (minor) exceptional cases OR/AND specify a clear contract ("analyze the source code" is unacceptable) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=comments#action_12353520 ] Guy Veraghtert commented on JBSEAM-880: --------------------------------------- Interesting discussion. How about following case ? (details left out) <h:selectOneMenu value="#{bean.parent}" valueChangeListener="#{...}"> <s:selectItems value="#{allParents}" noSelectionLabel="[Please select]"/> </h:selectOneMenu> <h:selectOneMenu value="#{bean.child}" disabled="#{empty bean.parent}"> <s:selectItems value="#{bean.parent.children}" noSelectionLabel="[Please select]"/> </h:selectOneMenu> You have a screen with two dropdowns, the second isn't enabled until a selection is made in the first one and allows you to choose one of the selected parent's children. With the current implementation of UISelectItems, a dummy Parent must be returned by the getParent() method on bean, not an existing one, otherwise that parent will be pre-selected in the first dropdown, which we don't want. If we don't provide this dummy parent, an exception will occur, because bean.parent evaluates to null and hence also bean.parent.children, although a parent instance getChildren() method always returns a non-null value. When adding an empty list the user woudn't see an empty dropdown, but a disabled one, with [Please Select] as the first value. So, I would opt for the alternative with the empty list and a WARN message ;-), as you could have guessed. (However, be careful that the log statement doesn't cause another exception) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=all ] Peter Muir updated JBSEAM-880: ------------------------------ Fix Version/s: 1.2.0.BETA1 (was: 1.1.7.GA) Ok, thanks for the use case - I *think* it should be possible to get it working without a empty list. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=all ] Peter Muir updated JBSEAM-880: ------------------------------ Fix Version/s: 1.1.8.GA (was: 1.2.0.BETA1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=comments#action_12354227 ] Peter Muir commented on JBSEAM-880: ----------------------------------- Guy, please test the changes, and close the issue if you are happy that we have the issues discussed above resolved. As this is in so close to a release date can you create another issue if there are other use cases we need to address. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-880?page=all ] Guy Veraghtert closed JBSEAM-880. --------------------------------- Resolution: Done Pete, things work fine now when adding a noSelectionLabel. FYI, if NO noSelectionLabel is added, Sun RI 1.2 generates following stacktrace: java.lang.IllegalArgumentException: Expected a child component type of UISelectItem/UISelectItems for component type javax.faces.SelectOne(projectMenu). Found null. at com.sun.faces.renderkit.RenderKitUtils.getSelectItems(RenderKitUtils.java:357) at com.sun.faces.renderkit.html_basic.MenuRenderer.getOptionNumber(MenuRenderer.java:675) at com.sun.faces.renderkit.html_basic.MenuRenderer.renderSelect(MenuRenderer.java:793) at com.sun.faces.renderkit.html_basic.MenuRenderer.encodeEnd(MenuRenderer.java:335) at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:833) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira