[JBoss JIRA] Created: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
11:16 a.m.
Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [JBoss JIRA] Work started: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Work on SOLDER-50 started by Lincoln Baxter III.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Stuart Douglas commented on SOLDER-50:
--------------------------------------
I don't think that this should be a checked exception, as IMHO in most cases this is
not recoverable. I am in favour of a BeanManagerNotAvailible unchecked exception
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:21 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-50:
---------------------------------
Agreed with Stuart. The correct pattern to use here is:
if (isBeanManagerAvailable()) {
doX();
}
Flow control via exceptions is extremely evil and must be avoided at all costs.
We can make this a more specialized exception.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-50:
---------------------------------
BTW I assume you meant ISE not IAE?
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:23 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-50:
---------------------------------
This unchecked exception should extend ISE.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Stuart Douglas commented on SOLDER-50:
--------------------------------------
If this returns false it means that you are not in a CDI environment or you are in some
new environment that has not been encountered before (e.g. if OWB decided to release a
owb-servlet module).
I think we should get rid of the 'Do not use this under any circumstances' warning
in the javadoc of this class for a number of reasons:
1) It is standards compliant: In an ee environment it will always get the BM from JNDI
2) It is the only portable way to get the BM
3) It is not tied to any implementation, so future CDI impls can implement the SPI to
maintain compatibility
4) 'the do not use this' comment in the javadoc is just plain wrong (there are no
risks associated with using it, and it is more portable than looking up the BM in JNDI),
it is actually the complete opposite of what the javadoc says, and portable code should
use it where possible to get the BM instead on JNDI lookups.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-50:
---------------------------------
The comment is there to try to make people pass the BM reference around explicitly, not
rely on lookup. We can reword it.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:31 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-50:
---------------------------------
The issue that I have with isBeanManagerAvailable() is that when I call getBeanManager(),
I pay the tax of looking it up again (when using the static BeanManagerAccessor). I have
to use that in cases where extension isn't an option. Though, I could instead do:
BeanManagerAware locator = new BeanManagerAware();
if (locator.isBeanManagerAvailable())
{
BeanManager beanManager = locator.getBeanManager();
beanManager.fireEvent(payload);
}
In this context, the name of the class seems silly. It should probably be
BeanManagerLocator. In fact, maybe we just do away with the static methods.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-50:
---------------------------------
(The reason it looks it up twice is because the static methods on BeanManagerAccessor
don't hold state, obviously).
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:33 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-50:
---------------------------------
So can we just make it this?
BeanManagerLocator locator = new BeanManagerLocator();
if (locator.isBeanManagerAvailable())
{
BeanManager beanManager = locator.getBeanManager();
beanManager.fireEvent(payload);
}
And still have a specialized unchecked exception that extends IllegalStateException when
the getter fails.
public class BeanManagerNotAvailable extends IllegalStateException {}
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:35 a.m.
New subject: [JBoss JIRA] Issue Comment Edited: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen edited comment on SOLDER-50 at 12/10/10 9:34 AM:
-----------------------------------------------------------
The issue that I have with isBeanManagerAvailable() is that when I call getBeanManager(),
I pay the tax of looking it up again (when using the static BeanManagerAccessor). I have
to use that in cases where class extension (w/ BeanManagerAware) isn't an option.
Though, I could instead do:
BeanManagerAware locator = new BeanManagerAware();
if (locator.isBeanManagerAvailable())
{
BeanManager beanManager = locator.getBeanManager();
beanManager.fireEvent(payload);
}
In this context, the name of the class seems silly. It should probably be
BeanManagerLocator. In fact, maybe we just do away with the static methods.
was (Author: dan.j.allen):
The issue that I have with isBeanManagerAvailable() is that when I call
getBeanManager(), I pay the tax of looking it up again (when using the static
BeanManagerAccessor). I have to use that in cases where extension isn't an option.
Though, I could instead do:
BeanManagerAware locator = new BeanManagerAware();
if (locator.isBeanManagerAvailable())
{
BeanManager beanManager = locator.getBeanManager();
beanManager.fireEvent(payload);
}
In this context, the name of the class seems silly. It should probably be
BeanManagerLocator. In fact, maybe we just do away with the static methods.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:37 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen commented on SOLDER-50:
---------------------------------
We also need to reword because EE simply has missing areas of coverage for CDI. So for
instance, w/o Seam Faces, people have no choice but to use
BeanManagerAware/Accessor/Locator to do any sort of CDI tie-in.
The way I like to put it is "you should be using this to provide CDI integration, not
spreading it all over application code. The goal is to shift into a managed environment so
you can leverage the CDI programming model in a native way."
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:03 a.m.
New subject: [JBoss JIRA] Commented: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Pete Muir commented on SOLDER-50:
---------------------------------
Locator sounds good. There are cases when you shouldn't use it for integration. For
example if you can place the BM in a context in a location where can inject it, do it.
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:15 p.m.
New subject: [JBoss JIRA] Updated: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen updated SOLDER-50:
----------------------------
Fix Version/s: 3.0.0.Beta1
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Lincoln Baxter III
Priority: Minor
Fix For: 3.0.0.Beta1
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 p.m.
New subject: [JBoss JIRA] Resolved: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen resolved SOLDER-50.
-----------------------------
Assignee: Dan Allen (was: Lincoln Baxter III)
Resolution: Done
https://github.com/seam/solder/pull/8
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Dan Allen
Priority: Minor
Fix For: 3.0.0.Beta1
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:38 p.m.
New subject: [JBoss JIRA] Closed: (SOLDER-50) Throw a specialized exception when BeanManagerAware cannot resolve BeanManager
[
https://issues.jboss.org/browse/SOLDER-50?page=com.atlassian.jira.plugin....
]
Dan Allen closed SOLDER-50.
---------------------------
Throw a specialized exception when BeanManagerAware cannot resolve
BeanManager
------------------------------------------------------------------------------
Key: SOLDER-50
URL: https://issues.jboss.org/browse/SOLDER-50
Project: Seam Solder
Issue Type: Feature Request
Components: Core
Reporter: Dan Allen
Assignee: Dan Allen
Priority: Minor
Fix For: 3.0.0.Beta1
The BeanManagerAware#getBeanManager() method currently throws an IllegalArgumentException
when the BeanManager cannot be found by any provider. Because this exception is so
generic, it's dangerous to bundle the lookup with other code because you aren't
sure whether the IllegalArgumentException came from the BeanManager lookup or from a
subsequent call, as in:
try {
BeanManager beanManager = BeanManagerAccessor.getBeanManager();
beanManager.fireEvent(payload);
}
catch (IllegalArgumentException e) {
// what caused this?
}
Introduce a specialized checked exception for this unique failure. The proposed name is
BeanManagerNotAvailable (or BeanManagerNotFound)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5611
days inactive
5621
days old
16 comments
4 participants
participants (4)
-
Dan Allen (JIRA) -
Lincoln Baxter III (JIRA)
-
Pete Muir (JIRA)
-
Stuart Douglas (JIRA)