[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3658) Wicket components with children that don't implement virtual methods fail to instrument
2:39 p.m.
Wicket components with children that don't implement virtual methods fail to
instrument
---------------------------------------------------------------------------------------
Key: JBSEAM-3658
URL: https://jira.jboss.org/jira/browse/JBSEAM-3658
Project: Seam
Issue Type: Bug
Reporter: Clint Popetz
Because the instrumentor makes the preamble loup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared foo().
The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:41 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3658) Wicket components with children that don't implement virtual methods fail to instrument
[
https://jira.jboss.org/jira/browse/JBSEAM-3658?page=com.atlassian.jira.pl...
]
Clint Popetz updated JBSEAM-3658:
---------------------------------
Description:
Because the instrumentor makes the preamble lookup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared foo().
The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
was:
Because the instrumentor makes the preamble loup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared foo().
The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
Wicket components with children that don't implement virtual
methods fail to instrument
---------------------------------------------------------------------------------------
Key: JBSEAM-3658
URL: https://jira.jboss.org/jira/browse/JBSEAM-3658
Project: Seam
Issue Type: Bug
Reporter: Clint Popetz
Attachments: seam-patch-for-missing-inherited-methods.diff
Because the instrumentor makes the preamble lookup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared
foo(). The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:41 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3658) Wicket components with children that don't implement virtual methods fail to instrument
[
https://jira.jboss.org/jira/browse/JBSEAM-3658?page=com.atlassian.jira.pl...
]
Clint Popetz updated JBSEAM-3658:
---------------------------------
Attachment: seam-patch-for-missing-inherited-methods.diff
A patch against the current trunk to fix this.
Wicket components with children that don't implement virtual
methods fail to instrument
---------------------------------------------------------------------------------------
Key: JBSEAM-3658
URL: https://jira.jboss.org/jira/browse/JBSEAM-3658
Project: Seam
Issue Type: Bug
Reporter: Clint Popetz
Attachments: seam-patch-for-missing-inherited-methods.diff
Because the instrumentor makes the preamble loup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared
foo(). The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3658) Wicket components with children that don't implement virtual methods fail to instrument
[
https://jira.jboss.org/jira/browse/JBSEAM-3658?page=com.atlassian.jira.pl...
]
Pete Muir closed JBSEAM-3658.
-----------------------------
Fix Version/s: 2.1.1.CR1
Resolution: Done
Assignee: Pete Muir
Wicket components with children that don't implement virtual
methods fail to instrument
---------------------------------------------------------------------------------------
Key: JBSEAM-3658
URL: https://jira.jboss.org/jira/browse/JBSEAM-3658
Project: Seam
Issue Type: Bug
Reporter: Clint Popetz
Assignee: Pete Muir
Fix For: 2.1.1.CR1
Attachments: seam-patch-for-missing-inherited-methods.diff
Because the instrumentor makes the preamble lookup its own method with
getClass().getDeclaredMethod, it creates broken instrumentations of:
class base {
void method foo();
}
class subclass extends base { }
because foo's preamble will get base as its Class object, which has no declared
foo(). The preamble with the attached patch is now generated as:
base.class.getDeclaredMethod(...)
rather than
getClass().getDeclaredMethod()
This was exposed in the wicket booking example because SimpleDataProvider was not
previously instrumented, as it was abstract, but
https://jira.jboss.org/jira/browse/JBSEAM-3594 caused us to start instrumenting abstract
classes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6376
days inactive
6376
days old
3 comments
2 participants
participants (2)
-
Clint Popetz (JIRA) -
Pete Muir (JIRA)