[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
12:52 p.m.
In specific cases, a closed entitymanager is injected by seam, resulting in
illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:22 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12405989 ]
Pete Muir commented on JBSEAM-2803:
-----------------------------------
So, you mean you are putting the SMPC into EVENT scope?
like
<persistence:managed-persistence-context name="entityManager"
scope="EVENT" />
?
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:13 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406003 ]
Indrek Altpere commented on JBSEAM-2803:
----------------------------------------
components.xml
<persistence:entity-manager-factory name="entityManagerFactory"
persistence-unit-name="soovPU"/>
<persistence:managed-persistence-context name="em"
auto-create="true" scope="EVENT"
entity-manager-factory="#{entityManagerFactory}"/>
<transaction:entity-transaction entity-manager="#{em}"/>
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:27 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=all ]
Pete Muir closed JBSEAM-2803.
-----------------------------
Resolution: Rejected
Using an SMPC not in the CONVERSATION scope is not supported. Use @PersistenceContext
instead.
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406014 ]
Indrek Altpere commented on JBSEAM-2803:
----------------------------------------
We use pojos because of deployment to non ejb compliant weblogic appserver.
At http://www.infoq.com/articles/jboss-seam it states:
The @PersistenceContext injection no longer works in POJOs. In order to obtain an
EntityManager in a Seam POJO, you have to initialize the EntityManager in Seam
configuration file and then use the Seam @In annotation to inject it into the POJO.
In event scope, everything else worked fined except the usage of em in conversation scope
after session scope activity.
And that fix for entityManager=null; after the closing fixed that part too.
Reason for event scope is optimization for less memory usage, using em in event scope
allows memory to be gc'able quite soon after request and memory consumption does not
buld up so much as when in conversation scope.
Is there any specific reason for not using em in event scope or some tips/tricks/known
facks on how to impove em performance and making the memory GC'able sooner ?
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:01 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406021 ]
Pete Muir commented on JBSEAM-2803:
-----------------------------------
You can write an extended version of ManagedPersistenceContext to handle this if you want,
but we're not altering it in Seam core.
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406024 ]
Indrek Altpere commented on JBSEAM-2803:
----------------------------------------
So keeping the closed entitymanager around is meant to be feature ?
Doesn't it possibly break things in other occasions also ?
The icefaces file upload and event scoped entitymanager is currently just one way this
thing surfaced.
Are you 100% sure it is meant to be like that as it is currently ?
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:09 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406043 ]
Pete Muir commented on JBSEAM-2803:
-----------------------------------
"Doesn't it possibly break things in other occasions also?"
Not AFAIK. Like what?
"The icefaces file upload and event scoped entitymanager is currently just one way
this thing surfaced. Are you 100% sure it is meant to be like that as it is currently
?"
Of course it is - look at the evidence - it can only be called after the component's
@Destroy method is called.
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:11 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406087 ]
Indrek Altpere commented on JBSEAM-2803:
----------------------------------------
You didn't answer my first question :P Is it meant to be like that ?
Keeping a reference to already closed em, thus letting it keep reference to other objects
and in total, keeping bunch of memory non GC'able.
Results of a stress test (3 threads, total of 100 request per thread constantly bombing
application):
Memory usage after stress test completed:
Em in PAGE scope without entityManager = null fix: 800MB+ memory usage
Em in PAGE scope with entityManager = null fix ~590MB memory usage
Em in EVENT scope without fix ~410M
Em in EVENT scope with fix ~410M
So, in some odd cases it causes closed em to stay around, throwin exceptions, PLUS memory
leakage in amount of 110MB !!!!
Perhaps you could do some your side testing also to verify that the memory leakage is
there before closing this thing off as "won't fix".
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:11 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=all ]
Indrek Altpere reopened JBSEAM-2803:
------------------------------------
This behavior is also directly related to memory usage/leakage.
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:33 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=all ]
Pete Muir closed JBSEAM-2803.
-----------------------------
Resolution: Rejected
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2803) In specific cases, a closed entitymanager is injected by seam, resulting in illegalstateexceptions
[ http://jira.jboss.com/jira/browse/JBSEAM-2803?page=comments#action_12406105 ]
Pete Muir commented on JBSEAM-2803:
-----------------------------------
"You didn't answer my first question :P Is it meant to be like that ? "
Err, yes I did, please READ my answer:
""...Are you 100% sure it is meant to be like that as it is currently ?"
Of course it is"
If you use the entityManager component in the designed way (conversation scope) the
close() method will only be called when the component is being destroyed. All your results
are using the entityManager in an illegal way.
In specific cases, a closed entitymanager is injected by seam,
resulting in illegalstateexceptions
--------------------------------------------------------------------------------------------------
Key: JBSEAM-2803
URL: http://jira.jboss.com/jira/browse/JBSEAM-2803
Project: JBoss Seam
Issue Type: Bug
Components: Framework
Affects Versions: 2.1.0.A1
Environment: Glassfish v2ur1, Icefaces 1.7.0
Reporter: Indrek Altpere
Original Estimate: 4 hours
Remaining Estimate: 4 hours
EntityManager is put to event Scope for better memory usage and GC.
Class that tries to use the entitymanager is itself in conversation scope, and this
specific behavior occurs after icefaces file upload.
Injected em is closed and throws IllegalStateException for every function used (as it
should when it's closed).
I dug around the persistence namespace/package and found once place that could explain
it.
src/main/org/jboss/seam/persistence/ManagedPersistenceContext.java
line 225 to 229
if (entityManager!=null)
{
entityManager.close();
}
As seen, entityManager is closed but since getEntityManager() function only creates new
entitymanager when entityMAnager is null and does not check for entityManager being
closed, the closed entitymanager gets passed around.
I added entityManager = null; after the entityManager.close(); line so that the
getEntityManager() would correctly return new entitymanager after old one was closed and
recompiled the latest sources.
It seemed to fix this issue, no more errors, em injected to the conversation scope class
is not closed one anymore :)
There may be some other things related to this like JBSEAM-2666 but I'm not entirely
sure about it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6493
days inactive
6494
days old
11 comments
2 participants
participants (2)
-
Indrek Altpere (JIRA) -
Pete Muir (JIRA)