[ http://jira.jboss.com/jira/browse/JBSEAM-2419?page=comments#action_12415676 ] Christian Bauer commented on JBSEAM-2419: ----------------------------------------- Now thrown in other places as well after a simplification: Caused by: java.lang.IllegalArgumentException: factory method with defined scope outjected a value: currentAccessLevel at org.jboss.seam.Component.handleFactoryMethodResult(Component.java:2054) at org.jboss.seam.Component.getInstanceFromFactory(Component.java:2028) at org.jboss.seam.Component.getInstance(Component.java:1962) at org.jboss.seam.Component.getInstance(Component.java:1939) at org.jboss.seam.Namespace.getComponentInstance(Namespace.java:55) at org.jboss.seam.Namespace.getComponentInstance(Namespace.java:50) at org.jboss.seam.el.SeamELResolver.resolveBase(SeamELResolver.java:166) at org.jboss.seam.el.SeamELResolver.getValue(SeamELResolver.java:53) at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:53) at com.sun.faces.el.FacesCompositeELResolver.getValue(FacesCompositeELResolver.java:64) at org.jboss.el.parser.AstIdentifier.getValue(AstIdentifier.java:44) at org.jboss.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:186) at org.jboss.seam.core.Expressions$1.getValue(Expressions.java:112) at org.jboss.seam.persistence.HibernatePersistenceProvider.enableFilter(HibernatePersistenceProvider.java:175) at org.jboss.seam.persistence.PersistenceProvider.enableFilter(PersistenceProvider.java:99) at org.jboss.seam.persistence.ManagedPersistenceContext.initEntityManager(ManagedPersistenceContext.java:88) at org.jboss.seam.persistence.ManagedPersistenceContext.getEntityManager(ManagedPersistenceContext.java:108) at sun.reflect.GeneratedMethodAccessor6249.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.seam.util.Reflections.invoke(Reflections.java:21) at org.jboss.seam.intercept.RootInvocationContext.proceed(RootInvocationContext.java:31) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:56) at org.jboss.seam.persistence.ManagedEntityIdentityInterceptor.aroundInvoke(ManagedEntityIdentityInterceptor.java:48) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.transaction.RollbackInterceptor.aroundInvoke(RollbackInterceptor.java:31) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.core.MethodContextInterceptor.aroundInvoke(MethodContextInterceptor.java:42) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.intercept.RootInterceptor.invoke(RootInterceptor.java:107) at org.jboss.seam.intercept.JavaBeanInterceptor.interceptInvocation(JavaBeanInterceptor.java:166) at org.jboss.seam.intercept.JavaBeanInterceptor.invoke(JavaBeanInterceptor.java:102) at org.jboss.seam.wiki.core.dao.WikiManagedPersistenceContext_$$_javassist_10.getEntityManager(WikiManagedPersistenceContext_$$_javassist_10.java) at sun.reflect.GeneratedMethodAccessor6248.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.seam.util.Reflections.invoke(Reflections.java:21) at org.jboss.seam.util.Reflections.invokeAndWrap(Reflections.java:125) at org.jboss.seam.Component.callComponentMethod(Component.java:2195) at org.jboss.seam.Component.unwrap(Component.java:2221) at org.jboss.seam.Component.getInstance(Component.java:1988) at org.jboss.seam.Component.getInstance(Component.java:1939) at org.jboss.seam.Component.getInstanceInAllNamespaces(Component.java:2295) at org.jboss.seam.Component.getValueToInject(Component.java:2247) at org.jboss.seam.Component.injectAttributes(Component.java:1697) at org.jboss.seam.Component.inject(Component.java:1515) at org.jboss.seam.core.BijectionInterceptor.aroundInvoke(BijectionInterceptor.java:45) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.core.MethodContextInterceptor.aroundInvoke(MethodContextInterceptor.java:42) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.intercept.RootInterceptor.invoke(RootInterceptor.java:107) at org.jboss.seam.intercept.JavaBeanInterceptor.interceptInvocation(JavaBeanInterceptor.java:166) at org.jboss.seam.intercept.JavaBeanInterceptor.invoke(JavaBeanInterceptor.java:102) at org.jboss.seam.wiki.core.dao.WikiNodeDAO_$$_javassist_9.findArea(WikiNodeDAO_$$_javassist_9.java) at org.jboss.seam.wiki.core.action.WikiRequestResolver.resolve(WikiRequestResolver.java:143) at sun.reflect.GeneratedMethodAccessor6763.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.seam.util.Reflections.invoke(Reflections.java:21) at org.jboss.seam.intercept.RootInvocationContext.proceed(RootInvocationContext.java:31) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:56) at org.jboss.seam.transaction.RollbackInterceptor.aroundInvoke(RollbackInterceptor.java:31) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.core.BijectionInterceptor.aroundInvoke(BijectionInterceptor.java:46) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.core.MethodContextInterceptor.aroundInvoke(MethodContextInterceptor.java:42) at org.jboss.seam.intercept.SeamInvocationContext.proceed(SeamInvocationContext.java:68) at org.jboss.seam.intercept.RootInterceptor.invoke(RootInterceptor.java:107) at org.jboss.seam.intercept.JavaBeanInterceptor.interceptInvocation(JavaBeanInterceptor.java:166) at org.jboss.seam.intercept.JavaBeanInterceptor.invoke(JavaBeanInterceptor.java:102) at org.jboss.seam.wiki.core.action.WikiRequestResolver_$$_javassist_8.resolve(WikiRequestResolver_$$_javassist_8.java) at sun.reflect.GeneratedMethodAccessor6762.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.jboss.el.util.ReflectionUtil.invokeMethod(ReflectionUtil.java:329) ... 61 more @Name("guestFactory") public class GuestFactory { /** * Assigns the context variable 'currentAccessLevel' when no user is logged in. */ @Factory(value = "currentAccessLevel", scope = ScopeType.SESSION, autoCreate = true) public Integer getGuestAccessLevel() { return Role.GUESTROLE_ACCESSLEVEL; } } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Devon Hillard commented on JBSEAM-2419: --------------------------------------- I also think it is a concurrency issue. I have the same error from my application. I have a rich:column which is filtered based on user input. If I type too quickly in the filter box I get the error: java.lang.IllegalArgumentException: factory method with defined scope outjected a value: If I type slowly, I do not get the error. The only difference is how rapidly the AJAX requests are made to the server. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Clement Denis commented on JBSEAM-2419: --------------------------------------- I'm getting this error too, and it is indeed a concurrency issue. It can happen with a component that injects another component created from a @Factory with a defined scope and a return value. It happened for me when I called this compoennt twice at the exact same time with two simultaneous REST calls. The concurrency issue starts when calling org.jboss.seam.Component.getComponent (at line 1982) : for both calls, the "Contexts.lookupInStatefulContexts(name)" returns null. (line numbers refer to version 2.2.0.GA) So, both calls try to produce a value from the factory method (wich is wrong because the factory should be called only once for the defined scope). If the first call outjects the value at a wrong time, the method handleFactoryMethodResult throws an exception for the second call, because "Contexts.lookupInStatefulContexts(name);" at the beginning of the method returns the value outjected by the first call, and this is considered wrong if the @Factory defines a scope. A quick fix would be to check the actual return type of the factory method and throw the exception only if the factory returns void. The best solution would be to avoid duplicate calls to a factory method, but I presume it would require major changes to the org.jboss.seam.Component.getComponent methods (maybe synchronization ...) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Christian Bauer commented on JBSEAM-2419: ----------------------------------------- Thanks for digging into this, Clement. Do you by any chance have a reproducible test case? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Work on JBSEAM-2419 started by Christian Bauer. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Pete Muir updated JBSEAM-2419: ------------------------------ Fix Version/s: 2.2.1.CR1 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Ondrej Skutka reassigned JBSEAM-2419: ------------------------------------- Assignee: Ondrej Skutka -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-2419?page=com.atlassian.jira.pl... ] Ondrej Skutka resolved JBSEAM-2419. ----------------------------------- Resolution: Done -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBSEAM-2419?page=com.atlassian.jira.plugin.... ] Ondrej Skutka reopened JBSEAM-2419: ----------------------------------- Reopened due to JBSEAM-4669 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBSEAM-2419?page=com.atlassian.jira.plugin.... ] Denis Forveille commented on JBSEAM-2419: ----------------------------------------- Not sure that this will solve the deadlock in all situation. if 2 threads create 2 components that need to have 2 different factories injected , one factory referencing the other... In your patch, line 2081 of Component.java, that is outside the lock will provoke deadlock IMHO... I have the feeling that managing the serialization in COmponent.java is not the way to go but don't have anything better to propose -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBSEAM-2419?page=com.atlassian.jira.plugin.... ] Ondrej Skutka resolved JBSEAM-2419. ----------------------------------- Fix Version/s: 2.2.1.CR2 (was: 2.2.1.CR1) Resolution: Done I've commited the proposed patch. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/JBSEAM-2419?page=com.atlassian.jira.plugin.... ] Denis Forveille commented on JBSEAM-2419: ----------------------------------------- Ondrej, Sorry but I'm not in position to perform such a test as we need to setup a stress test and that takes time and resources to do that. We do this from time to time when a new version of one of our app is about to be pushed in production but it will not be the case in the coming months. As what you say about deadlock, it is true if you take into account only the lock in Component If some thread takes a reentrant lock in the BI associated with a component "A" then take another reentrant lock in Component to instantiate ANY factory, and another thread do it in the reverse order, ie ake a lock in Component to instantiate ANY factory and to do that tries to go through the lock in Bi associated with Component "A", you're done And I'm 90%sure that it is quite easy to have this kind of components So, I continue to think that the path may correct JBSEAM-4669 but is causing much more harm. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira