[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
4:39 a.m.
@Providers not working - ResteasyDispatcher registers components and providers in wrong
order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
While using the latest nightly build (from 2009.02.19) I found that my @Provider annotated
class is not used by Seam+RESTEasy. It seemed to be loaded but not used by injection
mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java
2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:01 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Jozef Hartinger reassigned JBSEAM-3965:
---------------------------------------
Assignee: Jozef Hartinger
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:36 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Balazs Pataki commented on JBSEAM-3965:
---------------------------------------
Maybe it is a different issue, but it seems to be impossible to register a class as both
as @Provider and a Seam component (with @Name).
In ResteasyBootstrap there's this warning:
log.warn("not registering as provider Seam component, must be
APPLICATION or STATELESS scoped: "
+ seamComponent.getName());
however in ResteasyDispatcher i says:
throw new RuntimeException(
"Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
);
This means that at the end only Scope.APPLICATION is allowed. However if I annotate my
StringConverter subclass like this:
@Name("MyConverterComponent")
@Scope(ScopeType.APPLICATION)
@Provider
it won't get registered or won't be invoked at all when marshalling the method
parameters of my REST calls.
---
balazs
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:53 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Jozef Hartinger commented on JBSEAM-3965:
-----------------------------------------
Yes, if a provider is also a Seam component it can be in stateless or application scope.
However, there is currently now way how to register stateless provider to resteasy -
that's why the exception is thrown when you try to register one.
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:32 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Balazs Pataki commented on JBSEAM-3965:
---------------------------------------
Jozef,
thanks for the clarification! Hope I not bother you too much, however I have a developing
story. :-)
It seems to me that one cannot register a provider which is also a Seam component.
I have this converter:
@Name("TaskConverter")
@Provider
@Scope(ScopeType.APPLICATION)
public class TaskConverter implements StringConverter<Task>{
@Logger private Log log;
@In EntityManager entityManager;
public Task fromString(String id) {
Task obj = entityManager.find(Task.class, id);
return obj;
}
public String toString(Task obj) {
return String.valueOf(obj.getId());
}
}
Basically, when I get an ID ina REST call I want to transparently convert it to the
matching Task object with this ID.
It is registered by ResteasyDispatcher like this:
public void onStartup()
...
else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
{
Object providerInstance =
Component.getInstance(seamComponent.getName());
providerFactory.registerProviderInstance(providerInstance);
}
...
Then ResteasyProviderFactory is called and in effect its addStringConverter() gets
invoked:
public void addStringConverter(StringConverter provider)
{
providers.put(provider.getClass(), provider);
PropertyInjectorImpl injector = new PropertyInjectorImpl(provider.getClass(),
this);
injector.inject(provider);
Type[] intfs = provider.getClass().getGenericInterfaces();
for (Type type : intfs)
{
if (type instanceof ParameterizedType)
{
ParameterizedType pt = (ParameterizedType) type;
if (pt.getRawType().equals(StringConverter.class))
{
Class<?> aClass = Types.getRawType(pt.getActualTypeArguments()[0]);
stringConverters.put(aClass, provider);
}
}
}
}
Now, when I debug addStringConverter I can see the following:
provider is of type TaskConverter_$$_javassist_seam_3
intfs is Class<T>[5] = [interface org.jboss.seam.Instance, interface
org.jboss.seam.intercept.Proxy, interface
javax.servlet.http.HttpSessionActivationListener, interface org.jboss.seam.core.Mutable,
interface javassist.util.proxy.ProxyObject]
Now, there should probably be there a StringConverter<Task> interface as well so
that the "if (type instanceof ParameterizedType)" evaluate to true and so my
TaskConverter to be registered. However there's no StringConverter<Task>
interface in the "intfs" list (although the provider parameter at the source
code level is of type StringConverter). Maybe javassist screws up something ...
Nevertheless, the current situation seems to be that one cannot register a provider which
is also a Seam component.
Could you please confirm that this is actually the case, or should I do some other
configuration or annotation to have an object act both as a provider and a Seam
component?
Thanks,
---
balazs
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:46 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Jozef Hartinger commented on JBSEAM-3965:
-----------------------------------------
"Nevertheless, the current situation seems to be that one cannot register a provider
which is also a Seam component."
I don't think this is true in general. Before commiting resteasy upgrade I verified
that providers work (several ExceptionMappers and MessageBodyReaders/Writers). I, however
did not test StringCoverters so I believe only these have problem.
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:40 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Balazs Pataki commented on JBSEAM-3965:
---------------------------------------
You're maybe right that it only effects StringConverters. I now tried with an EAR
project instead of WAR project, so that my TaskConverter is an EJB and looks like this:
@Name("TaskConverter")
@Provider
@Scope(ScopeType.APPLICATION)
@Stateful
public class TaskConverter<T> implements StringConverter<Task>{
...
}
So, it is Stateful and APPLICATION scoped. Now in
ResteasyProviderFactory#addStringConverter() the "intfs" contains this for teh
TaskConverter's javassist proxy object:
[interface org.jboss.seam.Instance, interface org.jboss.seam.intercept.Proxy, interface
org.jboss.resteasy.spi.StringConverter, interface javassist.util.proxy.ProxyObject]
The org.jboss.resteasy.spi.StringConverter interface is now there, however it is not what
actually is expected by this method: it needs a ParameterizedType where the raw type is
the StringConverter.class. So, it really seems to me that when the javassist proxy is
created it gets wrong types, namely, a StringConverter instead of a ParameterizedType with
a StringConverter as its raw type.
Could you Jozef maybe take a look at this issue and try to create a StringConverter which
also acts a Seam component? It would be good to know whether the problem is with me or
with Seam (or javassist or RESTEasy. ;-) )
Thanks,
---
balazs
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Jozef Hartinger
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:03 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Christian Bauer reassigned JBSEAM-3965:
---------------------------------------
Assignee: Christian Bauer (was: Jozef Hartinger)
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Christian Bauer
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:54 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3965) @Providers not working - ResteasyDispatcher registers components and providers in wrong order
[
https://jira.jboss.org/jira/browse/JBSEAM-3965?page=com.atlassian.jira.pl...
]
Christian Bauer closed JBSEAM-3965.
-----------------------------------
Fix Version/s: 2.1.2.CR1
Resolution: Done
I've fixed the ordering of registration, providers need to come before resources. The
second issue is with the StringConverter extension of Resteasy, these currently can not be
Seam components: https://jira.jboss.org/jira/browse/JBSEAM-4020
@Providers not working - ResteasyDispatcher registers components and
providers in wrong order
---------------------------------------------------------------------------------------------
Key: JBSEAM-3965
URL: https://jira.jboss.org/jira/browse/JBSEAM-3965
Project: Seam
Issue Type: Bug
Components: WS
Affects Versions: 2.1.1.CR1
Reporter: Balazs Pataki
Assignee: Christian Bauer
Fix For: 2.1.2.CR1
While using the latest nightly build (from 2009.02.19) I found that my @Provider
annotated class is not used by Seam+RESTEasy. It seemed to be loaded but not used by
injection mechanism. By debugging the code I found out that it is not used because
org.jboss.seam.resteasy.ResteasyDispatcher#onStartup() first registers the resources and
after that the providers. However, as part of the resource registration the injection
mechanism including the converters are set up, however at this point the converters
(providers) have not been loaded.
It seems to first load the providers and then the resources.
This is my patch that worked in my setup:
> diff -c ResteasyDispatcher.java ResteasyDispatcher_orig.java
*** ResteasyDispatcher.java 2009-02-20 11:10:35.000000000 +0100
--- ResteasyDispatcher_orig.java 2009-02-19 00:18:26.000000000 +0100
***************
*** 56,91 ****
getDispatcher().setLanguageMappings(application.getLanguageMappings());
getDispatcher().setMediaTypeMappings(application.getMediaTypeMappings());
- // Provider registration
- if (application.isUseBuiltinProviders())
- {
- log.info("registering built-in RESTEasy providers");
- RegisterBuiltin.register(providerFactory);
- }
- for (Class providerClass : application.getProviderClasses())
- {
- Component seamComponent =
application.getProviderClassComponent(providerClass);
- if (seamComponent != null)
- {
- if (ScopeType.STATELESS.equals(seamComponent.getScope()))
- {
- throw new RuntimeException(
- "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
- );
- }
- else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
- {
- Object providerInstance =
Component.getInstance(seamComponent.getName());
- providerFactory.registerProviderInstance(providerInstance);
- }
- }
- else
- {
- // Just plain RESTEasy, no Seam component lookup or lifecycle
- providerFactory.registerProvider(providerClass);
- }
- }
-
// Resource registration
Registry registry = getDispatcher().getRegistry();
for (final Class resourceClass : application.getClasses())
--- 56,61 ----
***************
*** 133,137 ****
--- 103,138 ----
registry.addResourceFactory(new POJOResourceFactory(resourceClass));
}
}
+
+ // Provider registration
+ if (application.isUseBuiltinProviders())
+ {
+ log.info("registering built-in RESTEasy providers");
+ RegisterBuiltin.register(providerFactory);
+ }
+ for (Class providerClass : application.getProviderClasses())
+ {
+ Component seamComponent =
application.getProviderClassComponent(providerClass);
+ if (seamComponent != null)
+ {
+ if (ScopeType.STATELESS.equals(seamComponent.getScope()))
+ {
+ throw new RuntimeException(
+ "Registration of STATELESS Seam components as RESTEasy
providers not implemented!"
+ );
+ }
+ else if (ScopeType.APPLICATION.equals(seamComponent.getScope()))
+ {
+ Object providerInstance =
Component.getInstance(seamComponent.getName());
+ providerFactory.registerProviderInstance(providerInstance);
+ }
+ }
+ else
+ {
+ // Just plain RESTEasy, no Seam component lookup or lifecycle
+ providerFactory.registerProvider(providerClass);
+ }
+ }
+
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5592
days inactive
5616
days old
8 comments
3 participants
participants (3)
-
Balazs Pataki (JIRA) -
Christian Bauer (JIRA)
-
Jozef Hartinger (JIRA)