[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis updated JBSEAM-3225: --------------------------------- Attachment: ie6leak-example.zip Attatched is an example Facelets view and Seam component. The fix is in the .xhtml file, and with the fix IE6 is able to handle over 500K requests without any issues. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Shane Bryzak commented on JBSEAM-3225: -------------------------------------- I've made some changes to remote.js, hopefully fixing the garbage collection issues. Could you please try the latest SVN version and let me know if it works. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis commented on JBSEAM-3225: -------------------------------------- After 5000 iterations IE6 is using over 165K of memory. It started with about 30K. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis commented on JBSEAM-3225: -------------------------------------- jscript.dll File Version: 5.7.0.18066 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis updated JBSEAM-3225: --------------------------------- Attachment: JBSEAM-3225_fix_IE6_memory_leak.patch Here's a cleaner version of the patch, for Seam 2.1.1.GA, maybe you'll like this one better. :) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis commented on JBSEAM-3225: -------------------------------------- Argh... that one has a bug. I'll make another. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3225?page=com.atlassian.jira.pl... ] Joshua Davis updated JBSEAM-3225: --------------------------------- Description: Issuing many Seam Remoting calls can cause IE6 to fail with an 'out of memory' error. The problem seems to be related to the fact that the AJAX request object is a COM object in IE, so it doesn't get garbage collected in the same way. On a P3 machine with 512M of RAM, IE6 can handle about 30k calls before failing. Here is one way to fix it using Prototype: Seam.Remoting.sendAjaxRequest = function(envelope, path, callback, silent) { Seam.Remoting.log("Request packet:\n" + envelope); if (!silent) Seam.Remoting.displayLoadingMessage(); if (Seam.Remoting.encodedSessionId) { path += ';jsessionid=' + Seam.Remoting.encodedSessionId; } var req = new Ajax.Request( Seam.Remoting.resourcePath + path, { method: 'post', postBody: envelope, contentType: 'text/xml', evalJS: false, evalJSON: false, onSuccess: function(transport) { Seam.Remoting.requestCallback(transport,callback); }, onFailure: function(transport) { } }); }; Seam.Remoting.requestCallback = function(req,callback) { if (callback) { // The following code deals with a Firefox security issue. It reparses the XML // response if accessing the documentElement throws an exception try { req.responseXML.documentElement; callback(req.responseXML); } catch (ex) { try { // Try it the IE way first... var doc = new ActiveXObject("Microsoft.XMLDOM"); doc.async = "false"; doc.loadXML(req.responseText); callback(doc); } catch (e) { // If that fails, use standards var parser = new DOMParser(); callback(parser.parseFromString(req.responseText, "text/xml")); } } } }; was: Issuing many Seam Remoting calls can cause IE6 to fail with an 'out of memory' error. The problem seems to be related to the fact that the AJAX request object is a COM object in IE, so it doesn't get garbage collected in the same way. On a P3 machine with 512M of RAM, IE6 can handle about 30k calls before failing. Here is one way to fix it using Prototype: {code} Seam.Remoting.sendAjaxRequest = function(envelope, path, callback, silent) { Seam.Remoting.log("Request packet:\n" + envelope); if (!silent) Seam.Remoting.displayLoadingMessage(); if (Seam.Remoting.encodedSessionId) { path += ';jsessionid=' + Seam.Remoting.encodedSessionId; } var req = new Ajax.Request( Seam.Remoting.resourcePath + path, { method: 'post', postBody: envelope, contentType: 'text/xml', evalJS: false, evalJSON: false, onSuccess: function(transport) { Seam.Remoting.requestCallback(transport,callback); }, onFailure: function(transport) { } }); }; Seam.Remoting.requestCallback = function(req,callback) { if (callback) { // The following code deals with a Firefox security issue. It reparses the XML // response if accessing the documentElement throws an exception try { req.responseXML.documentElement; callback(req.responseXML); } catch (ex) { try { // Try it the IE way first... var doc = new ActiveXObject("Microsoft.XMLDOM"); doc.async = "false"; doc.loadXML(req.responseText); callback(doc); } catch (e) { // If that fails, use standards var parser = new DOMParser(); callback(parser.parseFromString(req.responseText, "text/xml")); } } } }; {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira