[ https://issues.jboss.org/browse/SEAMFACES-232?page=com.atlassian.jira.plu... ] Cody Lerum commented on SEAMFACES-232: -------------------------------------- Jason has done one commit on this - https://github.com/seam/faces/commit/3e2806d96f345d24e4860c267f5cba181a31... I'm thinking we may need to check to see if the exception should rollback the tx based on - https://github.com/seam/transaction/blob/develop/impl/src/main/java/org/j... to be consistent with the behavior of seam transaction -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-232?page=com.atlassian.jira.plu... ] Cody Lerum commented on SEAMFACES-232: -------------------------------------- This would mirror the functionality of Seam Transaction and since we are saying that If you use faces you don't have to worry about Annotating your methods - https://github.com/seam/transaction/blob/develop/docs/src/main/docbook/en... I think we should stick with that behavior That is the EE way and it's what is currently done in Seam Transaction. We could expose a config option in the future to do rollback on any Exception, but I don't think we should deviate from that as the default. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-232?page=com.atlassian.jira.plu... ] Cody Lerum commented on SEAMFACES-232: -------------------------------------- Shall I create a pull req or do you want to just fix it? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/SEAMFACES-232?page=com.atlassian.jira.plu... ] Cody Lerum commented on SEAMFACES-232: -------------------------------------- So in reality when we pickup the exception event there are two exceptions on top of our thrown exception (throwing just a standard java.lang.Exception) javax.faces.FacesException -javax.faces.el.EvaluationException --java.lang.Exception Both the faces exceptions are RuntimeExceptions. So maybe it is just best to say if you let a exception bubble up to the faces level then we are going to act on the exception chain as we see it. If so there is no need to pass it through the ExecptionUtil class as the top of the Exception chain is always going to be a javax.faces.FacesException (RuntimeException) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira