[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=all ] Norman Richards reassigned JBSEAM-763: -------------------------------------- Assignee: Norman Richards -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12352793 ] Norman Richards commented on JBSEAM-763: ---------------------------------------- I've added an attempt at this based on the code Shane submitted. I'm obviously not a javascript master, so I couldn't quite duplicate the effect. I'll leave this open because it needs some browser testing and because I'm hoping someone else might take the opportunity to spice up the javascript a bit. I'd love to use more of the code submitted here because it is a lot neater than what we are doing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12352863 ] Norman Richards commented on JBSEAM-763: ---------------------------------------- Yes, it just needs some CSS. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12352927 ] Shane Bryzak commented on JBSEAM-763: ------------------------------------- I've looked through the Javascript code for the date picker - Norman, do you mind if I rewrite it from scratch? I'll probably reuse bits from what's already there and the code I attached earlier. I won't start this until JBSEAM-819 is done, because I'd like to also separate the Javascript out of the page itself and also add some default images/css style. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12352993 ] Shane Bryzak commented on JBSEAM-763: ------------------------------------- Yes, this is no problem. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=all ] Shane Bryzak closed JBSEAM-763. ------------------------------- Resolution: Done I've hacked the date picker to a point now where it is "good enough". I ended up throwing away the javascript that we were using and used a greatly trimmed version of the sample I posted earlier. It would be easy to spend a week on this stuff, there's so many features that it could include - maybe in the future I'll get round to them. I included a default CSS stylesheet which can be easily included by specifying defaultCss="true" in the selectDate tag. A cool thing I discovered about CSS tonight - it seems that you can include it anywhere in your page, not just in the header. You learn something new every day :). The stylesheet and the images it uses are now served by the resource servlet, along with the javascript (which makes debugging nicer). Only the booking and seamspace examples have been updated, if other examples use selectDate they need to be updated also. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=all ] Gavin King reopened JBSEAM-763: ------------------------------- OK, so the look and feel of the date picker is now broken in the booking demo, seam-gen, and presumably in user's applications. If there was a compelling reason to change the names of the css classes, then the examples and seam-gen need to be updated. If not, then the names of the css classes should be rolled back, to allow backward compatibility. (It's not reasonable to just arbitrarily make breaking changes like this in a point release.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12353596 ] Shane Bryzak commented on JBSEAM-763: ------------------------------------- The old css styles are not compatible with the new script, which has finer-grained control over the style of the calendar. I updated the booking demo, and the new styles all seemed to look fine - I tested in FF and IE, is it broken in Safari? I'll go through the other examples and update them if they use the selectDate control, and I guess it should be an easy matter to update seam-gen. I'll look at it ASAP. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12353599 ] Gavin King commented on JBSEAM-763: ----------------------------------- Oh, and it doesn't work at all in other examples like jpa. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12353602 ] Gavin King commented on JBSEAM-763: ----------------------------------- I am using firefox. The select date dropdown used to be pretty, with the look and feel of the rest of the app, the same size as the inputtext, nice brown matching colors, not ugly shades of grey, nice left and right arrows, not the ugly triangles that are there now, etc. Please fix it to look like it used to look. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12353607 ] Shane Bryzak commented on JBSEAM-763: ------------------------------------- Ok, I'll have to check 1.1.6 because the last version in cvs before I made the changes was totally broken.. the calendar stretched to the bottom of the screen and it was not what you could call pretty. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=comments#action_12353888 ] Gavin King commented on JBSEAM-763: ----------------------------------- SelectDate now throws NPEs in my seam-gen app. Also, the booking demo and seam-gen now no longer show the user how to override the look and feel of the calendar. If this doesn't get fixed by Thurs, I will roll back all changes since 1.1.6. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-763?page=all ] Gavin King closed JBSEAM-763. ----------------------------- Resolution: Done Back to normal now. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira