[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille updated JBSEAM-3726: ------------------------------------ Description: When starting our app in WebSphere v7.0 with seam v2.1.0.SP1, we receive the exception below Is it possible that annotation "javax.ejb.PostActivate" is used instead of "org.jboss.seam.annotations.intercept.PostActivate" annotation and that the former does not accept any parameter for the annotated method (At least in WebSphere v7.0) and the latter does... The method in question is declared as @PostActivate public void postActivate(InvocationContext invocation) throws Exception This method signature is present in classes SessionBeanInterceptor, EntityManagerProxyInterceptor and HibernateSessionProxyInterceptor Exception: [18/11/08 16:17:51:537 EST] 0000001a annotations E AnnotativeMetadataManagerImpl merge Caught exception while merging com.ibm.wsspi.amm.validate.ValidationException: For method, org.jboss.seam.persistence.EntityManagerProxyInterceptor.postActivate(Lorg/jboss/seam/intercept/InvocationContext;)V\[com.ibm.ws.amm.scan.util.info.impl.MethodInfoImpl@1b8e1b8e\], parameters were specified, but null was the expected comparison was: When starting our app in WebSphere v7.0 with seam v2.1.0.SP1, we receive the exception below Is it possible that annotation "javax.ejb.PostActivate" is used instead of "org.jboss.seam.annotations.intercept.PostActivate" annotation and that the former does not accept any parameter for the annotated method (At least in WebSphere v7.0) and the latter does... The method in question is declared as @PostActivate public void postActivate(InvocationContext invocation) throws Exception This method siganture is present in classes SessionBeanInterceptor, EntityManagerProxyInterceptor and HibernateSessionProxyInterceptor Exception: [18/11/08 16:17:51:537 EST] 0000001a annotations E AnnotativeMetadataManagerImpl merge Caught exception while merging com.ibm.wsspi.amm.validate.ValidationException: For method, org.jboss.seam.persistence.EntityManagerProxyInterceptor.postActivate(Lorg/jboss/seam/intercept/InvocationContext;)V[com.ibm.ws.amm.scan.util.info.impl.MethodInfoImpl@1b8e1b8e], parameters were specified, but null was the expected comparison -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Pete Muir updated JBSEAM-3726: ------------------------------ Component/s: Platform interoperability (was: EJB3) Fix Version/s: 2.1.1.CR2 Please give the full stack trace. N.B. This should not be a problem, as this interceptor isn't used if EJB isn't in use. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Pete Muir reassigned JBSEAM-3726: --------------------------------- Assignee: Marek Novotny Weird, Marek, please investigate... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Dan Allen commented on JBSEAM-3726: ----------------------------------- Sorry, WebSphere 7 is wrong. Section 3.1.4 of the EJB 3 spec (simplified) states the following: "Lifecycle callback methods defined on a bean class have the following signature: void <METHOD>() Lifecycle callback methods defined on an interceptor class have the following signature: void <METHOD>(InvocationContext) Lifecycle callback interceptor methods can have public, private, protected, or package level access." Of course, the lifecycle callback methods being referred to are annotated with @PrePassivate, @PostActivate, @PreDestroy, or @PostConstruct. Btw, EntityManagerProxyInterceptor and HibernateSessionProxyInterceptor are a relevant for discuss here because they are Seam interceptors, so the EJB container isn't calling them. The only interceptor relevant for this discussion is SessionBeanInterceptor. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille commented on JBSEAM-3726: ----------------------------------------- Thx PMR 92594 077 649 filled at IBM Will keep you informed of the correction from their side -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille reopened JBSEAM-3726: ------------------------------------- I'm still talking to IBM on this problem, but I think the problem is in seam The signature of the EJB3 callback methods is : void <METHOD>(javax.interceptor.InvocationContext) not void <METHOD>(org.jboss.seam.intercept.InvocationContext) as it is in EntityManagerProxyInterceptor -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille updated JBSEAM-3726: ------------------------------------ Affects Version/s: 2.1.1.GA (was: 2.1.1.CR2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille commented on JBSEAM-3726: ----------------------------------------- This is definitively a seam problem (Confirmed by IBM) The "javax.ejb.PostActivate" annotation needs methods with a signature of "void <METHOD>(javax.interceptor.InvocationContext)" which is not the case in "EntityManagerProxyInterceptor" where the "javax.ejb.PostActivate" annotation is used with a method of signature "void <METHOD>(org.jboss.seam.intercept.InvocationContext) " So i think that in EntityManagerProxyInterceptor and in HibernateSessionProxyInterceptor , the "javax.ejb.PostActivate" and "javax.annotation.PostConstruct;" annotations should be replaced by seam equivalents -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille commented on JBSEAM-3726: ----------------------------------------- Sorry to read that... So we'll have to wait for v2.1.2 in order to use seam with WebSphere v7 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille updated JBSEAM-3726: ------------------------------------ Attachment: jbseam-3726.patch I uploaded a patch that works for us. Basically what I did: - added a "org.jboss.seam.annotations.intercept.PostConstruct" annotation (based on "org.jboss.seam.annotations.intercept.PostActivate") - changed "org.jboss.seam.intercept.Interceptor" to scan for seam PostConstruct and PostActivate annotations instead of javax.* ones - changed "org.jboss.seam.persistence.EntityManagerProxyInterceptor" and "org.jboss.seam.persistence.HibernateSessionProxyInterceptor" to use the seam annotations instead of the javax ones. Seems to work for us, but the tests we did are very limited (WebSphere v7.0.0.1 in EJB 3.0 mode only for a small project) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Norman Richards commented on JBSEAM-3726: ----------------------------------------- Dan - did you look into this? Is websphere mistakenly applying annotation validation rules to non-EJB3 components or are we doing things in an EJB3 context that websphere doesn't like? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Julien Kronegg commented on JBSEAM-3726: ---------------------------------------- I applied Denis patch with success. BTW, thanks for that Denis, you've got eagle eyes :-) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Norman Richards updated JBSEAM-3726: ------------------------------------ Fix Version/s: 2.1.2.CR1 (was: 2.2.0.CR1) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Norman Richards commented on JBSEAM-3726: ----------------------------------------- These aren't EJB3 components/interceptors, so any any app server should definitely ignore these annotations. That's the whole point of annotations. As I said, I'd like to avoid duplicating any more annotations. Where we do further duplicate annotations, we should have a clear understanding of why we are doing it. Right now, this appears to simply be a websphere bug, a rather large one at that. Can you confirm that it is indeed the case that they are scanning things they shouldn't and not that we are introducing incorrectly methods on EJB3 components? If that's the case, then I think we can move these new annotations in as a workaround. It would also be helpful if you (or another websphere user) could engage the developers to get them to fix this. The whole purpose of standardizing these annotations is so that they can be reused in other contexts. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Pete Muir commented on JBSEAM-3726: ----------------------------------- Denis, I'm happy to apply your patch, but we do need to check for both EE and our synonym in the Interceptor. If you can update for this (as PostActivate used to do) I will apply. Also, are you interested in taking over responsiblity for the Seam/WebSphere integration? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Norman Richards commented on JBSEAM-3726: ----------------------------------------- If JSR 250 says that ALL uses of the annotation must be associated with that method signature then this is our mistake and we should make the change and look to phasing out our incorrect usage. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBSEAM-3726?page=com.atlassian.jira.pl... ] Denis Forveille updated JBSEAM-3726: ------------------------------------ Attachment: jbseam-3726_2.patch New version of patch with re-introduction of the scan of EJB 3.0 annotations s requested by Pete -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira