[ http://jira.jboss.com/jira/browse/JBSEAM-2982?page=all ] Shane Bryzak reassigned JBSEAM-2982: ------------------------------------ Assignee: Shane Bryzak -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2982?page=comments#action_12412606 ] Tom N commented on JBSEAM-2982: ------------------------------- Hi Shane, You're right, after looking through things again, the errors were occurring when the first getParameter method was called -- it looks like it internally calls getHeader, getContentType, and begins parsing the request body for the mime boundary. This is what was causing me problems -- because I was putting the mock getParameter() calls on my inner HttpServletRequest, but the MultipartRequest was still trying to parse a MIME request body. I was able to get around it by putting the mock behavior back on the MultipartRequest like so: {{{ Properties requestProperties = ... byte[] uploadFile = ... HttpServletRequest req = createMock( HttpServletRequest.class ); MultipartRequest mpRequest = new MultipartRequest( req, false, Integer.MAX_VALUE ) { @Override public String getParameter(String name) { return requestProperties.getProperty(name); } @Override public byte[] getFileBytes(String name) { if ( name == "LOGFILE" ) return uploadFile; throw new IllegalArgumentException( "Unepected file request: " + name ); } }; }}} ...Apologies if the code is all inline -- JIRA is not giving me a preview button for my comment. So is this the best way to mock a MultipartRequest? It would still be nice if the inner mock HttpServletRequest was not necessary. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2982?page=comments#action_12412645 ] Tom N commented on JBSEAM-2982: ------------------------------- Would it be possible to simply create an interface for MultipartRequest's methods? That would be the most straightforward method. I'm not sure what other solutions there might be since it looks like the only HttpServletRequestWrapper constructor requires a non-null request instance. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBSEAM-2982?page=comments#action_12412790 ] Tom N commented on JBSEAM-2982: ------------------------------- Right. I can mock a HttpServletRequest now. The problem is when my servlet uses a MultipartRequest, and I need to mock the getFile* methods that are part of MultipartRequest. See Spring's MultipartHttpServletRequest (Note that it is an interface): http://static.springframework.org/spring/docs/2.0.2/api/index.html?org/sp... -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira