[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
4:15 p.m.
Entity component doesnt ensure that the the identifier field is accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that could
be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=comments#action_12361537 ]
Pete Muir commented on JBSEAM-1295:
-----------------------------------
What JPA implementation are you using?
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:59 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=comments#action_12361592 ]
Chris Rudd commented on JBSEAM-1295:
------------------------------------
I am using Hibernate.
But the Entity component doesnt care about that, its just using the @Entity annotated
class and processing the @Id annotation to find which getter or field represents the id.
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:45 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=comments#action_12361598 ]
Pete Muir commented on JBSEAM-1295:
-----------------------------------
Yes, it needs fixing. Where are coming across this problem? Are you calling
Entity.getIdentifier or is Seam? As calls should be to
PersistenceProvider.instance().getId() not to Entity directly
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:26 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=comments#action_12361654 ]
Chris Rudd commented on JBSEAM-1295:
------------------------------------
PersistenceProvider.getId, called from EntiyHome.persist.
I am using the EntityHome component and the PersitenceProvider component.
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:34 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=comments#action_12361656 ]
Chris Rudd commented on JBSEAM-1295:
------------------------------------
I altered Entity.java :
public Entity(Class<?> beanClass)
{
super(beanClass);
for ( Class<?> clazz=beanClass; clazz!=Object.class; clazz =
clazz.getSuperclass() )
{
for ( Method method: getBeanClass().getDeclaredMethods() )
{
//TODO: does the spec allow multiple lifecycle method
// in the entity class heirarchy?
if ( method.isAnnotationPresent(PreRemove.class) )
{
preRemoveMethod = method;
preRemoveMethod.setAccessible(true);
}
if ( method.isAnnotationPresent(PrePersist.class) )
{
prePersistMethod = method;
prePersistMehod.setAccessible(true);
}
if ( method.isAnnotationPresent(PreUpdate.class) )
{
preUpdateMethod = method;
preUpdateMethod.setAccessible(true);
}
if ( method.isAnnotationPresent(PostLoad.class) )
{
postLoadMethod = method;
postLoadMethod.setAccessible(true);
}
if ( method.isAnnotationPresent(Id.class) )
{
identifierGetter = method;
identifierGetter.setAccessible(true);
}
}
if (identifierGetter==null)
{
for ( Field field: getBeanClass().getDeclaredFields() )
{
if ( field.isAnnotationPresent(Id.class) )
{
identifierField = field;
identifierField.setAccessible(true);
}
}
}
}
}
Alternatly you could modify Reflections.java :
line 16
try
{
+ if( !method.isAccessible() )
+ method.setAccessible() )
return method.invoke( target, args );
line 45
try
{
+ if( !field.isAccessible() )
+ field.setAccessible() )
return field.get( target );
line 59
try
{
+ if( !field.isAccessible() )
+ field.setAccessible() )
field.set( target, value );
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:52 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1295) Entity component doesnt ensure that the the identifier field is accessible.
[ http://jira.jboss.com/jira/browse/JBSEAM-1295?page=all ]
Gavin King closed JBSEAM-1295.
------------------------------
Fix Version/s: 1.3.0.BETA1
Resolution: Done
Assignee: Gavin King
Thanks
Entity component doesnt ensure that the the identifier field is
accessible.
---------------------------------------------------------------------------
Key: JBSEAM-1295
URL: http://jira.jboss.com/jira/browse/JBSEAM-1295
Project: JBoss Seam
Issue Type: Bug
Affects Versions: 1.2.1.GA, 1.2.0.GA
Reporter: Chris Rudd
Assigned To: Gavin King
Fix For: 1.3.0.BETA1
The Entity component uses reflection to get the identifier of that @Entity it represents.
If the identifier is a private/protected @Id annotated field Entity.getIdentifier will
fail with an IllegalAccessException.
The code should be updated to call setAccessible(true) for each member / method that
could be private/protected that will be accessed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6908
days inactive
6912
days old
6 comments
3 participants
participants (3)
-
Chris Rudd (JIRA) -
Gavin King (JIRA)
-
Pete Muir (JIRA)