[
https://jira.jboss.org/jira/browse/JBSEAM-3014?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3014:
-----------------------------------
Gena, I tried applied your patches, but the entire testsuite is now failing due to missing
jaxen to create a MockServletContext.If you can sort this out, I can apply your changes,
Some constructive feedback for you on your patches (for which we are very grateful!):
* Try to follow coding conventions
* braces go on new lines
* variable names shouldn't be shortened, even if Jacob does ;-)
* Use 3 space indent
* Use Seam LogProvider not JDK logging
* Don't include whitespace changes/correction of line breaks in patches
* Don't swallow exceptions
Email / PDF rendering ignores custom taglibs defined with
facelets.LIBRARIES in web.xml
---------------------------------------------------------------------------------------
Key: JBSEAM-3014
URL:
https://jira.jboss.org/jira/browse/JBSEAM-3014
Project: Seam
Issue Type: Bug
Components: Mail, PDF
Affects Versions: 2.0.2.GA, 2.1.0.A1
Environment: 2.1.0.A1, Facelets shipped with Seam-gen, trinidad latest
Reporter: Gena Batalski
Assignee: Pete Muir
Attachments: FaceletCompiler.diff, FaceletCompiler.java, JBSEAM-3014.patch,
MockServletContext.diff, MockServletContext.java
Original Estimate: 0 minutes
Remaining Estimate: 0 minutes
During the rendering of email/pdf occurs an exception, if the email or pdf uses custom
facelets taglibs defined with context parameter facelets.LIBRARIES .
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira