[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
2 a.m.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree is
rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:17 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12358601 ]
Pete Muir commented on JBSEAM-1151:
-----------------------------------
My thoughts are
1) It works for ui:include so we should use that as the start (IncludeHandler extends
TagHandler and not ComponentHandler, whose apply method is probably causing the problem)
2) That really whats needed, is that wikitext like
/Something/
[<=myPlugin]
*Something*
leads to a a facelets template
<wiki:formattedText value="/Something/" />
<ui:include src="/plugins/myPlugin.xhtml" />
<wiki:formattedText value="*something*" />
so that this all occurs inline
SO,
1) Split the wikitext into substrings of plugins and everything else
2) If it is everything else, programtically create a UIWikiFormattedText
3) If it is a plugin do the relevant include
I'm going to try this later
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:05 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12358619 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
Btw, another challenge we need to solve is multiple plugin includes on one page. I can see
some plugins where this would be necessary, right now can't include the same Facelet
twice because 1. the identifiers would be duplicates at the same level and 2. the
NamingContainers inside it would be duplicates. I'm not proficient enough with JSF to
actually know if this is possible.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:02 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12358917 ]
Pete Muir commented on JBSEAM-1151:
-----------------------------------
AFAICS the only problem with ids/multiple plugins is that explicit id's are being
used. The plugins need to render themselves rather than being rendered by the parent
UIWikiFormattedText
I think that the only reason for not having it render itself (and hence giving it an id)
is that it needs to render a style?
Yes, each plugin should go in a Naming Container probably.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:01 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12358956 ]
Pete Muir commented on JBSEAM-1151:
-----------------------------------
I've made a commit that should fix all of the above. It parses the wikitext and
creates UIWikiFormattedText components for non-plugins and does a facelet's include
for plugins (and also adds in a UIStyle component to render the css inline). I created a
UIPlugin component that should be the root component of a plugin (all it does for now is
extend UINamingContainer to keep your ids unique so you can include the same plugin
multiple times). This seems to work for the comment plugin (though it might have broken
the interactive preview...). I think it might have broken the layout stuff as well.
Discuss further on IM...
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359008 ]
Pete Muir commented on JBSEAM-1151:
-----------------------------------
Also, need to wire across attributes from TagHandler to each created UIWikiFormattedText.
Do plugins specify their own attributes for any incorporated wiki:formattedText tags? Or
do they inherit?
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:54 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359371 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
Trying your modifications now, I can see two issues immediately:
- Rendering of /10.html is broken and Firefox now complains about invalid XHTML, looks
like there is a </div> that is in the source of the page (the <div> is
wrapping the [<=feedTeasers] plugin) that is not closed or closed too late. I don't
see it closed after the plugin is rendered, so we definitely have a problem with nesting
stuff.
- Rendering of /11.html works but once I submit the comment plugin form with no values I
get:
08:45:21,793 ERROR [STDERR] java.lang.ClassNotFoundException: No ClassLoaders found for:
org.jboss.seam.security.SecurityFunctions
08:45:21,794 ERROR [STDERR] at
org.jboss.mx.loading.LoadMgr3.beginLoadTask(LoadMgr3.java:212)
08:45:21,794 ERROR [STDERR] at
org.jboss.mx.loading.RepositoryClassLoader.loadClassImpl(RepositoryClassLoader.java:514)
08:45:21,794 ERROR [STDERR] at
org.jboss.mx.loading.RepositoryClassLoader.loadClass(RepositoryClassLoader.java:408)
08:45:21,794 ERROR [STDERR] at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
08:45:21,794 ERROR [STDERR] at
java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
08:45:21,794 ERROR [STDERR] at java.lang.Class.forName0(Native Method)
08:45:21,794 ERROR [STDERR] at java.lang.Class.forName(Class.java:164)
08:45:21,794 ERROR [STDERR] at
org.apache.el.lang.FunctionMapperImpl$Function.getMethod(FunctionMapperImpl.java:147)
08:45:21,794 ERROR [STDERR] at
org.apache.el.lang.FunctionMapperImpl.resolveFunction(FunctionMapperImpl.java:53)
08:45:21,794 ERROR [STDERR] at
org.apache.el.parser.AstFunction.getValue(AstFunction.java:71)
08:45:21,794 ERROR [STDERR] at
org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:186)
08:45:21,794 ERROR [STDERR] at
com.sun.facelets.el.TagValueExpression.getValue(TagValueExpression.java:71)
08:45:21,794 ERROR [STDERR] at
javax.faces.component.UIComponentBase.isRendered(UIComponentBase.java:384)
08:45:21,795 ERROR [STDERR] at
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:981)
08:45:21,795 ERROR [STDERR] at
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:989)
08:45:21,795 ERROR [STDERR] at
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:989)
08:45:21,795 ERROR [STDERR] at
javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:989)
08:45:21,795 ERROR [STDERR] at
javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:494)
08:45:21,795 ERROR [STDERR] at
org.ajax4jsf.framework.ajax.AjaxViewRoot.access$001(AjaxViewRoot.java:53)
08:45:21,795 ERROR [STDERR] at
org.ajax4jsf.framework.ajax.AjaxViewRoot$1.invokeRoot(AjaxViewRoot.java:254)
08:45:21,795 ERROR [STDERR] at
org.ajax4jsf.framework.ajax.JsfOneOneInvoker.invokeOnRegionOrRoot(JsfOneOneInvoker.java:54)
08:45:21,795 ERROR [STDERR] at
org.ajax4jsf.framework.ajax.AjaxContext.invokeOnRegionOrRoot(AjaxContext.java:176)
08:45:21,795 ERROR [STDERR] at
org.ajax4jsf.framework.ajax.AjaxViewRoot.processDecodes(AjaxViewRoot.java:267)
08:45:21,795 ERROR [STDERR] at
com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:101)
08:45:21,795 ERROR [STDERR] at
com.sun.faces.lifecycle.LifecycleImpl.phase(LifecycleImpl.java:248)
08:45:21,795 ERROR [STDERR] at
com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:117)
08:45:21,795 ERROR [STDERR] at
javax.faces.webapp.FacesServlet.service(FacesServlet.java:244)
This comes from
Caused by: javax.el.ELException: /docDisplay.xhtml @37,79
rendered="#{s:hasPermission('Node', 'create',
currentDirectory)}": Function 's:hasPermission' not found
at com.sun.facelets.el.TagValueExpression.getValue(TagValueExpression.java:76)
at javax.faces.component.UIComponentBase.isRendered(UIComponentBase.java:384)
... 54 more
Which renders fine without the postback.
I don't understand your last question about attributes.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:08 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359373 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
First issue:
In wiki text source: <div
style="width:300px;float:left;margin-right:10px;">[<=feedTeasers]</div
Rendered:
<div style="width:300px;float:left;margin-right:10px;" <div id="feedTeasers" class="" <table class="datatable rightBorder leftBorder
topBorder bottomBorder" border="0" cellpadding="0"
cellspacing="0" <thead <tr
<th class="regularHeader alignLeft" scope="col">Site news
feed:</th </tr </thead
<tbody
<tr class="rowOdd"
<td class="teaserColumn"
<div class="teaserAuthorDate" <span
class="teaserDate">09. Apr 2007, 11:45</span><span
id="j_id132:0:j_id138"> (<span
class="teaserAuthor">Regular
Member</span>)</span </div
<div class="teaserTitle"><a
href="http://www.lacewiki.org/wiki/22.lace">This is Blog Entry
Seven</a
</div This is a
regular blog entry with some text that we need to fill up the layout. Lets just repeat it
a few times: This is a regular blog entry with some text that we need
to fill up the layout. This
i<a href="http://www.lacewiki.org/wiki/22.lace" ...</a></td </tr
<tr class="rowEven" <td
class="teaserColumn"
<div class="teaserAuthorDate" <span
class="teaserDate">09. Apr 2007, 10:45</span><span
id="j_id132:1:j_id138"> (<span
class="teaserAuthor">Regular
Member</span>)</span
</div
<div class="teaserTitle"><a
href="http://www.lacewiki.org/wiki/21.lace">Entry Six</a </div
Blog Entry Nr.6
</td </tr </tbody
</table </div
Note the > at the end.
> Embedded plugin Facelets drop values during postback
> ----------------------------------------------------
> Key: JBSEAM-1151
> URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
> Project: JBoss Seam
> Issue Type: Bug
> Components: Wiki
> Reporter: Christian Bauer
> Assigned To: Pete Muir
> Priority: Blocker
> Pete, as discussed on IM and posted here so we can
coordinate what needs to be done:
> The wiki includes Facelets manually into the facelet tree when a plugin is
encountered during page rendering. This is done in two phases, through a ComponentHandler
when the facelet tree is build and through a custom component that renders the HTML for
the tree manually. This seems to work fine visually, and the view tree looks OK.
> However, if such an included facelet contains a form, on postback of this form the
tree is rebuild during RENDER RESPONSE and any invalid component from the earlier
VALIDATIONS phase is lost. So we never see entered invalid values in the form again. This
can be tested with the "user comment" form on the wiki.
> The interesting thing here is that it works perfectly fine for the plugin settings
forms, you can see those if you edit a document, and enable the preview and plugin
settings checkboxes. These forms are much more complicated than the "user
comment" form, so I haven't touched them to find out why it works in that case.
The trivial "user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:10 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359374 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
The [<=lastModifiedDocuments] plugin is also wrapped in a <div> and also has the
> at the end instead of </div>.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:51 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359385 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
OK, so the issue is that the separate UIWikiFormattedText components don't work. There
is no guarantee that a [<=plugin] is in the wiki source without any dependency on outer
wiki tags. E.g.:
"A Plugin: <div>[<=plugin]</div>"
doesn't work because you get three components in the tree:
<UIWikiFormattedText value="A Plugin: <div>"/>
<UIPlugin/>
<UIWikiFormattedText value="</div>"/>
The last UIWikiFormattedText can't render "</div>" properly because
the wiki text parser mangles the closing </div> if there is no opening <div>
before. This might be solved with a different HTML passthrough parsing approach but
I'm not sure that this is the way to go. What about plugins that are not divs, e.g. a
plugin that is rendered really inline as a <span>:
"This is a *[<=pluginRenderedAsSpan]* with a bold span around it."
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:07 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359386 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
Wiki text:
This is a *[<=testPlugin]*.
Plugin source:
<s:span id="testPlugin"
xmlns="http://www.w3.org/1999/xhtml"
xmlns:s="http://jboss.com/products/seam/taglib">
Hello World!
</s:span>
Rendered:
Foo
</p>
<p>
This is a <b></p>
<span id="testPlugin">
Hello World!</span><p>
<b>.
</p>
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:16 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359388 ]
Christian Bauer commented on JBSEAM-1151:
-----------------------------------------
All in all I think we need to roll this back to the original approach with a single
UIWikiFormattedText and delegated rendering of the children. We really need to find out
why the preferences editing form worked (you'd get invalid components in RENDER
RESPONSE) and why the component tree was discarded for the simpler forms.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:08 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=comments#action_12359632 ]
Pete Muir commented on JBSEAM-1151:
-----------------------------------
Christian, I've committed another version of the Handler. The handler now creates a
component tree for the plugin, and puts a placeholder in the wikitext. When the
UIWikiFormattedText does it's encodeBegin, when it encounters a plugin, it will use
the placeholder to look up the client id of the plugin and render it. This appears to be
working for all the the welcome page and the blog page. A couple of notes - 1) I
haven't got it to autowire attributes, these have to be wired in the setAttributes
method of the handler. 2) I've used a4j's style component for rendering the
styles for the plugins - this causes a <link src="" /> tag to be added to
the head for each plugin that needs a stylesheet - it is resolving EL inside the CSS - but
not for the EVENT or PAGE scope - if you want this, we would need to write out a
<style> rather than a link.
The latest version of jboss-el fixes the function problem.
Can you give it a test?
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:54 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=all ]
Christian Bauer resolved JBSEAM-1151.
-------------------------------------
Resolution: Done
That works great, thanks Peter. Funny how this solution with the interleaved rendering by
position was the same approach as my very first attempt weeks ago that failed :)
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:02 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1151) Embedded plugin Facelets drop values during postback
[ http://jira.jboss.com/jira/browse/JBSEAM-1151?page=all ]
Pete Muir closed JBSEAM-1151.
-----------------------------
FYI, the reason it worked this time was due to NOT using a Facelets ComponentHandler
(which gets applied to all components by default) but instead the custom one that mixes up
ComponentHandler and IncludeHandler. ComponentHandler has all sorts of weird stuff about
cleaning up the tree.
Embedded plugin Facelets drop values during postback
----------------------------------------------------
Key: JBSEAM-1151
URL: http://jira.jboss.com/jira/browse/JBSEAM-1151
Project: JBoss Seam
Issue Type: Bug
Components: Wiki
Reporter: Christian Bauer
Assigned To: Pete Muir
Priority: Blocker
Pete, as discussed on IM and posted here so we can coordinate what needs to be done:
The wiki includes Facelets manually into the facelet tree when a plugin is encountered
during page rendering. This is done in two phases, through a ComponentHandler when the
facelet tree is build and through a custom component that renders the HTML for the tree
manually. This seems to work fine visually, and the view tree looks OK.
However, if such an included facelet contains a form, on postback of this form the tree
is rebuild during RENDER RESPONSE and any invalid component from the earlier VALIDATIONS
phase is lost. So we never see entered invalid values in the form again. This can be
tested with the "user comment" form on the wiki.
The interesting thing here is that it works perfectly fine for the plugin settings forms,
you can see those if you edit a document, and enable the preview and plugin settings
checkboxes. These forms are much more complicated than the "user comment" form,
so I haven't touched them to find out why it works in that case. The trivial
"user comment" form should be easier to debug...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6928
days inactive
6940
days old
14 comments
2 participants
participants (2)
-
Christian Bauer (JIRA) -
Pete Muir (JIRA)