11:31 a.m.
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Fix For: 2.0.0.CR1
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools 4.0
GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:32 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Ning Zhao updated JBSEAM-1635:
------------------------------
Attachment: DroolsHandler.java
The changed I made in the DroolsHandler.java. It is working.
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Ning Zhao updated JBSEAM-1635:
------------------------------
Attachment: RuleBase.java
Changes I made in the RuleBase.java. It works and solved the problems described in this
thread:
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=113140
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Ning Zhao updated JBSEAM-1635:
------------------------------
Attachment: RuleBasedIdentity.java
Changes made in the RuleBasedIdentity.java. It is working.
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:51 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Shane Bryzak reassigned JBSEAM-1635:
------------------------------------
Assignee: Shane Bryzak
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Shane Bryzak
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=comments#action_12368546 ]
Ning Zhao commented on JBSEAM-1635:
-----------------------------------
Tha janino compiler causes all kinds of problems when the rule file gets reasonably
complex (the drools example(number guess) comes with Seam is too simple to expose
janino's problems). With janino, when compiling rules, I got
java.lang.StackOverFlowError, the $ symbols are not allowed for variable name ($ is very
common in rule files), and it only supports java source code level up to 1.4. So whenever
there is java 5 syntax in the functions in a .drl file, janino gets confused and the rules
do not get compiled. All these problems were away when I further modified the code in
org.jboss.seam.drools.RuleBase.java like below:
PackageBuilderConfiguration conf = new PackageBuilderConfiguration();
conf.setCompiler(PackageBuilderConfiguration.ECLIPSE); // not janino anymore!!!
conf.setJavaLanguageLevel("1.6"); // can be set to "1.5" if you wish
PackageBuilder builder = new PackageBuilder(conf);
So I strongly recommend not to use janino compiler in Seam. There is another benefit that
the janino.jar does not need to be included if we do not use it.
Regards,
Ellen
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Shane Bryzak
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:12 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=comments#action_12369037 ]
Ning Zhao commented on JBSEAM-1635:
-----------------------------------
the PackageBuilderConfiguration class was refactored yesterday. Now it will read a
configuration property file. The example from the drools svn is like this:
drools.dialect.default = java
drools.dialect.java = org.drools.rule.builder.dialect.java.JavaDialectConfiguration
drools.dialect.java.compiler = ECLIPSE
drools.dialect.mvel = org.drools.rule.builder.dialect.mvel.MVELDialectConfiguration
drools.dialect.mvel.strict = true
drools.accumulate.function.average =
org.drools.base.accumulators.AverageAccumulateFunction
drools.accumulate.function.max = org.drools.base.accumulators.MaxAccumulateFunction
drools.accumulate.function.min = org.drools.base.accumulators.MinAccumulateFunction
drools.accumulate.function.count = org.drools.base.accumulators.CountAccumulateFunction
drools.accumulate.function.sum = org.drools.base.accumulators.SumAccumulateFunction
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Shane Bryzak
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:14 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=comments#action_12369038 ]
Ning Zhao commented on JBSEAM-1635:
-----------------------------------
drools' GlobleResolver interface was changed so that now WorkingMemory can also
setGloble(string, obj).
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Shane Bryzak
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:24 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=comments#action_12369039 ]
Ning Zhao commented on JBSEAM-1635:
-----------------------------------
I saw the RuleBasedSecurity in the org.jboss.seam.security package was changed to use a
stateful session. Although in fact it works much like a workingMemory but I think the
security rules are quite a global rules, thus using WorkingMemory might be better. In my
own project I hook drools like this in the SFSB conversation beans:
@In(create = true)
private RuleBase recipeTagRules;
...
private void addHealthyTags() {
StatelessSession tagsSls = this.recipeTagRules
.newStatelessSession();
tagsSls.setGlobal("recipeManager", this);
tagsSls.execute(this.recipeNutrients);
}
or use StatefulSession where appropriate.
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Shane Bryzak
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Norman Richards reassigned JBSEAM-1635:
---------------------------------------
Assignee: Norman Richards (was: Shane Bryzak)
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Norman Richards
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:35 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1635) Migrating to Drools 4.0.0 MR3
[ http://jira.jboss.com/jira/browse/JBSEAM-1635?page=all ]
Norman Richards closed JBSEAM-1635.
-----------------------------------
Resolution: Done
I've upgraded drools. There was one tricky problem: this version of drools added
something called shadow facts. This is implemented by a proxy. The problem with the
proxy is that is incompatible with the javassist proxies used in Seam due to the use of
final methods by javassist proxies. (also a problem with cglib proxies) Shadow proxies
can be disabled in drools, but this results in drools giving wrong answers when facts
change.
I've had to duplicate the javassist ProxyFactory in Seam, modified to not generate any
final methods. This should not affect anything else. In theory, it could slightly
decrease performance my limiting optimization possibilities. It also could also introduce
javassist version dependencies should the underlying javassist jar change drastically.
The only other option would appear to be never asserting any proxied Seam components into
drools, so it seems like the best choice if we want support future versions of drools.
Migrating to Drools 4.0.0 MR3
-----------------------------
Key: JBSEAM-1635
URL: http://jira.jboss.com/jira/browse/JBSEAM-1635
Project: JBoss Seam
Issue Type: Feature Request
Components: Drools
Affects Versions: 2.0.0.BETA1
Environment: OS: all. JBoss AS 4.2.0 GA. Seam CVS 2007-07-10, Drools SVN
2007-07-10
Reporter: Ning Zhao
Assigned To: Norman Richards
Fix For: 2.0.0.CR1
Attachments: DroolsHandler.java, RuleBase.java, RuleBasedIdentity.java
Drools API has been changed since 4.0.0M3. Please see:
http://wiki.jboss.org/wiki/Wiki.jsp?page=4.0.0.MR3ReleaseNotes
Corresponding changes in the Seam codebase and Seam reference should be made if Drools
4.0 GA is to be used in the future Seam.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6836
days inactive
6843
days old
10 comments
3 participants
participants (3)
-
Ning Zhao (JIRA) -
Norman Richards (JIRA)
-
Shane Bryzak (JIRA)