7:54 a.m.
Tiago Peruzzo created JBSEAM-5045:
-------------------------------------
Summary: Ajax error not calling ExceptionFilter
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the JSF
and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}" value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:54 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo updated JBSEAM-5045:
----------------------------------
Attachment: patch.zip
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:17 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Marek Novotny commented on JBSEAM-5045:
---------------------------------------
thanks for the patch, I will look at it
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:47 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Marek Novotny reassigned JBSEAM-5045:
-------------------------------------
Assignee: Marek Novotny
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:03 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Work on JBSEAM-5045 started by Marek Novotny.
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:03 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Marek Novotny updated JBSEAM-5045:
----------------------------------
Fix Version/s: 2.3.1.CR1
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:59 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Work on JBSEAM-5045 stopped by Marek Novotny.
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:20 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Marek Novotny resolved JBSEAM-5045.
-----------------------------------
Resolution: Done
I have to re-write usage of proprietary Mojarra HtmlResponseWriter, but all other is very
similar to attached patch.
Thank you!
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:29 a.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo commented on JBSEAM-5045:
---------------------------------------
Marek, thank you for having accepted my bug and my suggested solution, I hope to continue
helping the Seam team.
I would like you to take a look at my comment on another issue:
https://issues.jboss.org/browse/JBSEAM-5052
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:32 p.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo commented on JBSEAM-5045:
---------------------------------------
Marek, now tested this fix but did not work for me, I'm using Mojarra 2.1.14
I noticed that now the ResponseWrite being used is MockResponseWrite, but it does not
implement various methods like startDocument, writeAttribute and startDocument ... so
content of the response is always empty.
I found two solutions, the first would be to implement these methods in the class
MockResponseWrite but would much work and the other would modify the redirect method and
generate the xml there without using any ResponseWrite.
I have attached the patch of the second option, if you want I can do the patch the first
option too.
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 p.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo reopened JBSEAM-5045:
-----------------------------------
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: MockExternalContext.java, patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:34 p.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo updated JBSEAM-5045:
----------------------------------
Attachment: MockExternalContext.java
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: MockExternalContext.java, patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:38 p.m.
[
https://issues.jboss.org/browse/JBSEAM-5045?page=com.atlassian.jira.plugi...
]
Tiago Peruzzo updated JBSEAM-5045:
----------------------------------
Attachment: MockExternalContext.java
Ajax error not calling ExceptionFilter
--------------------------------------
Key: JBSEAM-5045
URL: https://issues.jboss.org/browse/JBSEAM-5045
Project: Seam 2
Issue Type: Bug
Affects Versions: 2.3.0.Final
Reporter: Tiago Peruzzo
Assignee: Marek Novotny
Fix For: 2.3.1.CR1
Attachments: MockExternalContext.java, MockExternalContext.java, patch.zip
Now that JSF2 now has support for Ajax errors Ajax requests are being processed by the
JSF and not being thrown exceptions to the Seam ExceptionFilter capture.
{code:xml}
<exception log="true" log-level="fatal">
<end-conversation before-redirect="true" root="true"/>
<redirect view-id="/error.xhtml">
<message severity="fatal">Unexpected error, please try
again.</message>
</redirect>
</exception>
{code}
{code:xml}
<h:form>
<h:commandButton action="#{xxxx.xxxxx}"
value="Submit"/>
<h:commandButton action="#{xxxx.xxxxx}" value="Ajax
Submit">
<f:ajax />
</h:commandButton>
</h:form>
{code}
I even did a patch that still support the redirection to the error pages in AJAX
requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
4405
days inactive
4470
days old
12 comments
2 participants
participants (2)
-
Marek Novotny (JIRA) -
Tiago Peruzzo (JIRA)