4:48 a.m.
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: http://jira.jboss.com/jira/browse/JBSEAM-2854
Project: JBoss Seam
Issue Type: Feature Request
Components: BPM, Core, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:49 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2854) Provide a way to nest pageflows
[ http://jira.jboss.com/jira/browse/JBSEAM-2854?page=comments#action_12407287 ]
Guillaume Jeudy commented on JBSEAM-2854:
-----------------------------------------
I would add in order to be consistent with existing seam nested conversation support, if
the parent pageflow ends then all nested pageflows should end as well. Anyways all options
should be considered.
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: http://jira.jboss.com/jira/browse/JBSEAM-2854
Project: JBoss Seam
Issue Type: Feature Request
Components: Core, BPM, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:27 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2854) Provide a way to nest pageflows
[ http://jira.jboss.com/jira/browse/JBSEAM-2854?page=comments#action_12407387 ]
Marcell Barbacena commented on JBSEAM-2854:
-------------------------------------------
Agreed.
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
nested: page2>page3;
parent: page3->endpage1;
nested: no more!
and
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
nested: page2>page3;
nested: page3->endpage1;
parent: page3->endpage1;
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: http://jira.jboss.com/jira/browse/JBSEAM-2854
Project: JBoss Seam
Issue Type: Feature Request
Components: BPM, Core, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:57 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2854) Provide a way to nest pageflows
[ http://jira.jboss.com/jira/browse/JBSEAM-2854?page=comments#action_12416356 ]
Przemyslaw Jaskierski commented on JBSEAM-2854:
-----------------------------------------------
Implementing this could actually help with broken back button support in subprocesses.
Details here:
http://www.seamframework.org/Community/BackButtonFromSubprocessBackenable...
Without these two issues resolved making complex and reusable sub-pageflows is almost
impossible.
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: http://jira.jboss.com/jira/browse/JBSEAM-2854
Project: Seam
Issue Type: Feature Request
Components: BPM, Core, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:55 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2854) Provide a way to nest pageflows
[
https://jira.jboss.org/jira/browse/JBSEAM-2854?page=com.atlassian.jira.pl...
]
Eddie Lewis commented on JBSEAM-2854:
-------------------------------------
The issue is that pageflows are initiated at the beginning of a conversation.
When conversations are started - the @Begin annotation is checked to see if a
"pageflow" attribute is specified.
If a nested conversation is started and no pageflow attribute is specified, then the
processInstance variable in the PageFlow class is null (and the subflow stops working).
End the nested conversation and the parent conversations processInstance variable will
become valid and the pageflow will begin again.
Look at org.jboss.seam.core.ConversationInterceptor (2.0.1.GA)
private void beginConversationIfNecessary(Method method, Object result) {
.......
beginConversation( nested, getProcessDefinitionName(method) );
.......
}
private String getProcessDefinitionName(Method method) {
if ( method.isAnnotationPresent(Begin.class) )
{
return method.getAnnotation(Begin.class).pageflow();
}
.........
//TODO: let them pass a pageflow name as a request parameter
return ""; <------ will return "" in this case
}
private void beginConversation(boolean nested, String pageflowName)
{
if ( !Manager.instance().isLongRunningOrNestedConversation() )
{
Manager.instance().beginConversation( );
beginNavigation(pageflowName); // pageflowName is empty
}
else if (nested)
{
Manager.instance().beginNestedConversation();
beginNavigation(pageflowName); // pageflowName is empty
}
}
private void beginNavigation(String pageflowName)
{
if ( !pageflowName.equals("") )
{
Pageflow.instance().begin(pageflowName); // pageflowName is empty
}
}
In the nested conversation - Pageflow.instance().begin is never called and the
processInstance variable in the PageFlow class ends up null.
The issue is the subflow (or the whole pageflow) that is contained within the parent
conversation has not been passed to the nested conversation with a pointer of where to
start the pageflow.
Just added this comment so that people have an idea as to why nested conversations can
break pageflows.
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: https://jira.jboss.org/jira/browse/JBSEAM-2854
Project: Seam
Issue Type: Feature Request
Components: BPM, Core, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:59 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-2854) Provide a way to nest pageflows
[
https://jira.jboss.org/jira/browse/JBSEAM-2854?page=com.atlassian.jira.pl...
]
Eddie Lewis commented on JBSEAM-2854:
-------------------------------------
Quick update
I tried propagating the pageflow from the parent to the nested conversation
ConversationInterceptor.java
private void beginConversation(boolean nested, String pageflowName) {
if (!Manager.instance().isLongRunningOrNestedConversation()) {
Manager.instance().beginConversation();
beginNavigation(pageflowName);
} else if (nested) {
// get pageflow from the current conversation
Pageflow ppf = (Pageflow) Component.getInstance(Pageflow.class,
ScopeType.CONVERSATION);
// create the nested conversation
Manager.instance().beginNestedConversation();
// if starting a new conversation and a pageflow attribute was specified then use it
if (!pageflowName.equals("")) {
beginNavigation(pageflowName);
} else {
// set the pageflow from the parent into the current context - will remove on end
conversation
if (ppf != null) {
Contexts.getConversationContext().set(Component.getComponentName(Pageflow.class),
ppf);
}
}
}
}
This worked and the pageflow continued successfully within the context of the nested
conversation
Just could not get the pageflow to continue from the parent when the nested conversation
was destroyed
in the method endConversation - added
Pageflow ppf = (Pageflow) Component.getInstance(Pageflow.class,
ScopeType.CONVERSATION);
Contexts.getConversationContext().set(Component.getComponentName(Pageflow.class),
null);
Manager.instance().endConversation(beforeRedirect);
if(ppf!=null) {
Contexts.getConversationContext().set(Component.getComponentName(Pageflow.class),
ppf);
}
also tried getting the parent conversation from the ConversationEntries instance and then
calling a redirect() or select() but still no luck.
Provide a way to nest pageflows
-------------------------------
Key: JBSEAM-2854
URL: https://jira.jboss.org/jira/browse/JBSEAM-2854
Project: Seam
Issue Type: Feature Request
Components: BPM, Core, JSF Controls
Affects Versions: 2.0.1.GA
Environment: All
Reporter: Marcell Barbacena
The current behaviour of pageflow subprocess tag is to include the pageflow definition in
the the current flow, meaning that the parent pageflow is paused until the included
pageflow ends.
However, sometimes it is desired that the parent pageflow do not "pause" and
that the included gain its own flow.
The semantics of this nested pageflow is:
- when starts: provided a nested conversation from the parent pageflow.
- when ends: go back do the state before the nesting. If the parent pageflow is not
associated in any way to the nested, its flow goes without interfering with the nested.
E.g.:
Parent directed graph: startpage1->page1; page1->page2; page1->nested;
nested->page2; page2->page3; page3->endpage1;
Nested graph: startpage2->page5; page5->page6; page6->endpage2
Then we can have:
parent: startpage1->page1;
parent: page1->nested;
nested: startpage2->page5;
nested: page5->page6;
parent: page1->page2;
parent: page2>page3;
nested: page6->endpage2
nested:endpage2->page2;
parent: page3->endpage1;
nested: page2>page3;
nested: page3->endpage1;
See that the nested pageflow gains his own flow, i.e. independent of the parent.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5495
days inactive
5930
days old
5 comments
4 participants
participants (4)
-
Eddie Lewis (JIRA) -
Guillaume Jeudy (JIRA)
-
Marcell Barbacena (JIRA)
-
Przemyslaw Jaskierski (JIRA)