6:49 a.m.
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException, IllegalAccessException
{
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:15 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=all ]
Gavin King reassigned JBSEAM-1584:
----------------------------------
Assignee: Michael Youngstrom
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:21 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=comments#action_12367341 ]
Michael Youngstrom commented on JBSEAM-1584:
--------------------------------------------
Just so I'm clear you probably know that if your spring bean is a Seam component Seam
should properly inject the @Logger right?
But you're probably wanting Seam logger functionality in your singletons. Is that
correct?
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:46 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=comments#action_12367344 ]
Magnus Heino commented on JBSEAM-1584:
--------------------------------------
No, I didn't know that.
I now understand the difference between:
1. inject a Spring bean using an EL expression
and
2. make the Spring bean a Seam component
So I shouldn't need this postprocessor for 2, but I need it for 1?
Why would I not want to make my spring bean a seam component? Are there other side
effects?
Using 1 I guess the bean actually used from seam is the spring bean. What happens if I add
<seam:component/>? Is this bean no longer the same in spring context and seam
context?
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:16 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=comments#action_12367350 ]
Michael Youngstrom commented on JBSEAM-1584:
--------------------------------------------
What happens if I add <seam:component/>? Is this bean no longer
the same in spring context and seam context?
The bean will be the same in spring and seam. Except now it will be a spring bean and
seam bean at the same time. :)
Then @Logger should work fine.
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:42 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=comments#action_12367584 ]
Michael Youngstrom commented on JBSEAM-1584:
--------------------------------------------
With the fix of JBSEAM-1583 @Logger should work fine if you use <seam:component/> or
<seam:component intercept="false"/> if you don't want seam to create a
proxy. Is that good enough? Or do you want a SeamLoggerPostProcessor?
Mike
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:20 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Resolved: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=all ]
Michael Youngstrom resolved JBSEAM-1584.
----------------------------------------
Resolution: Rejected
I think I would prefer not to add a LoggerPostProcessor for now. If you have a spring
bean that you want to have Seam functionality then I think you should just use
<seam:component/> that is really what it is there for.
If you'd like to debate further otherwise feel free to reopen the issue.
Mike
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:12 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-1584) @Logger and Spring beans
[ http://jira.jboss.com/jira/browse/JBSEAM-1584?page=all ]
Pete Muir closed JBSEAM-1584.
-----------------------------
@Logger and Spring beans
------------------------
Key: JBSEAM-1584
URL: http://jira.jboss.com/jira/browse/JBSEAM-1584
Project: JBoss Seam
Issue Type: Feature Request
Components: Spring
Affects Versions: 2.0.0.BETA1
Reporter: Magnus Heino
Assigned To: Michael Youngstrom
It would be nice if spring beans could be scanned for @Logger and injected with Log
instances just like seam components.
Using the code below, you can add this to applicationContext.xml...
<bean class="org.jboss.seam.ioc.spring.LoggerPostProcessor" />
...to have all spring beans scanned for @Logger and have a Log instance injected, just
like seam components. Then you can access the same context and log functionallity in your
spring beans as in your seam components.
I guess the seam spring namespace could be extended with <seam:logger/> to make it
even more simple to use.
package org.jboss.seam.ioc.spring;
import java.lang.reflect.Field;
import org.jboss.seam.annotations.Logger;
import org.jboss.seam.log.Logging;
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.config.BeanPostProcessor;
import org.springframework.util.ReflectionUtils;
import org.springframework.util.StringUtils;
import org.springframework.util.ReflectionUtils.FieldCallback;
public class LoggerPostProcessor implements BeanPostProcessor {
public Object postProcessAfterInitialization(Object bean, String beanName) throws
BeansException {
return bean;
}
public Object postProcessBeforeInitialization(final Object bean, final String beanName)
throws BeansException {
ReflectionUtils.doWithFields(bean.getClass(), new FieldCallback() {
public void doWith(Field field) throws IllegalArgumentException,
IllegalAccessException {
if (field.isAnnotationPresent(Logger.class)) {
String category = field.getAnnotation(Logger.class).value();
if(!StringUtils.hasText(category)) {
category = bean.getClass().getName();
}
ReflectionUtils.makeAccessible(field);
field.set(bean, Logging.getLog(category));
}
}
});
return bean;
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6049
days inactive
6308
days old
7 comments
4 participants
participants (4)
-
Gavin King (JIRA) -
Magnus Heino (JIRA)
-
Michael Youngstrom (JIRA)
-
Pete Muir (JIRA)