8:55 a.m.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Priority: Minor
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:57 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Stephan Bublava updated JBSEAM-623:
-----------------------------------
Attachment: selectdate-localization-patch.txt
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Priority: Minor
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12349129 ]
Stephan Bublava commented on JBSEAM-623:
----------------------------------------
The changes had only limited testing and should be reviewed, especially the "first
day of the week" changes (if you want them at all).
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Priority: Minor
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Gavin King updated JBSEAM-623:
------------------------------
Fix Version/s: 1.1.1.GA
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:23 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Gavin King reassigned JBSEAM-623:
---------------------------------
Assignee: Norman Richards
Thanks! You're doing some great patches Stephan.
Norman, can you review and commit this, please?
Thanks
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:22 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Norman Richards closed JBSEAM-623.
----------------------------------
Resolution: Done
Done - thanks for the changes!
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:42 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12349955 ]
Ronald van Kuijk commented on JBSEAM-623:
-----------------------------------------
I can accept that the dateformats between Javascript and JSF are not automatically in
sync, but we need a way to show them in the same format. In NL the user types dd-MM-yyyy,
while the selectdate shows MM/dd/yyyy. The converter with a pattern on it, does not accept
both, so they need to be in sync. I've seen that the js file has two variables that
can be used to configure this... the separator and format. I made a patch to
SelectDate.java, the selectDate.js and the .tld and faces-config file. I did not change
the selectDateTag.java file since it did not seem neccesary.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:46 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Reopened: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Ronald van Kuijk reopened JBSEAM-623:
-------------------------------------
Reopening, otherwise adding attachments does not seem possible
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:52 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Ronald van Kuijk updated JBSEAM-623:
------------------------------------
Attachment: adding-local-to-selectdate-display.txt
- ymd, mdy, dmy are supportet for the format
- . / and - tested for separators
Would be better if we can deduce this from the local, which I will look at later
The patch is rather big, even though I changed little. Lots of deletes and inserts of hole
blocks... sorry. Tried several options but always comes out similar to this.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:02 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Kasper Sørensen updated JBSEAM-623:
------------------------------------
Attachment: selectDate-dateFormat-patch.txt
Oh I wasn't under the impression that anybody else was working on this so I went ahead
and made another solution.
My solution includes revisions of both the javascript and the SelectItem component.
I've added a "dateFormat"-parameter to the SelectDate component which is
able to take the same date-patterns as the convertDateTime - as far as I know. I've
tested with various seperators and formats on both Firefox and IE and it works like a
charm.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350429 ]
Gavin King commented on JBSEAM-623:
-----------------------------------
Thanks Kasper .... but, I would prefer if you processed these things using new JIRA
issues, instead of re-opening old ones. It really screws up our change tracking to reopen
issues.
Norman, could you please review this stuff, thanks.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350430 ]
Norman Richards commented on JBSEAM-623:
----------------------------------------
thanks guys! I'll take a look at these and see if we can get these improvements in!
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:06 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350431 ]
Gavin King commented on JBSEAM-623:
-----------------------------------
Actually I mean to address that comment to Ronald.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:10 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Stephan Bublava updated JBSEAM-623:
-----------------------------------
Attachment: selectdate-localization-patch-2.txt
Here's a followup to my first patch, which supports localized date formats, button
names and fixes one minor error in the first one.
It seems that Ronald has also been working on this problem (even on the same day :), so
we'll probably need to merge the two patches somehow.
Changes:
1) SelectDate.java attempts to determine the correct date format (day, month, year order)
and separator by using the date converter attached to the "for" component and
passes the values to displayDatePicker().
2) The labels for the two buttons ("Close", "This Month"), which are
hidden by default, can now be localized by adding messages with these keys:
- org.jboss.seam.ui.SelectDate.close
- org.jboss.seam.ui.SelectDate.thisMonth
3) The date parser in selectDate.js did not handle two-digit years correctly and always
used 19xx in that case. The new logic should match SimpleDateFormat.java (to avoid
inconsistencies).
4) In my first patch I added markup to allow highlighting of weekends (Saturyday, Sunday).
The new version only highlights Sundays (if desired), but we can aslo remove this feature
again.
Thanks,
Stephan
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:16 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350441 ]
Kasper Sørensen commented on JBSEAM-623:
-----------------------------------------
Actually I did open a new issue, but I will go close it now - so just keep posting here!
:-)
Regarding the patches - I've briefly looked at Ronalds patch and both solutions look
to have interesting features. A merge would be nice, I think.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:19 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350563 ]
Ronald van Kuijk commented on JBSEAM-623:
-----------------------------------------
@Gavin: Ok, I shall, in the future, not reopen issues. It is very common within the
companies I work for, so I did it automatically. Sorry. Otoh, wasn't this issue closed
to quick? Or at least the remaining issues should have been put in as new feature
requests.... (just my €0.016)
@Stephan: I had to work on it, since I had to release something today and the (internal)
customer did not accept dates in the mdy with / format and instead of hardcoding it I
thought: "lets contribute".
btw, Isn't it possible to ask the short format for the local within Java and use that
as the default format (unless a dateconverter is specified) I did not look at it
yesterday since I had to little time.
Besides that, I was thinking of adding some shortcuts since it is almost impossible to use
this selectDate to select a birthday (try selecting 02-12-1971 (dmy) you keep
clicking...... any thoughts? otoh, the datepicker from icefaces is even worse... all that
ajax to select a date..... yuck.... They definately have to improve that component.
@Kasper. A specifying a real dateFormat instead of my two separate fields is better I
think. I just needed a quick but configurable solution. If I would have had the time,
I'd build a real format.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:57 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350645 ]
Stephan Bublava commented on JBSEAM-623:
----------------------------------------
@Stephan: I had to work on it, since I had to release
something today and the (internal) customer did not accept
dates in the mdy with / format and instead of hardcoding it
I thought: "lets contribute".
It's great, that you did. It's just funny, that three patches for this problem
were contributed on the same day.
btw, Isn't it possible to ask the short format for the local
within Java and use that as the default format (unless a
dateconverter is specified) I did not look at it yesterday
since I had to little time.
Yes, that should work, but assuming that the date isn't stored as string in your
model, a converter will be required anyway.
Besides that, I was thinking of adding some shortcuts
since it is almost impossible to use this selectDate to
select a birthday (try selecting 02-12-1971 (dmy) you
keep clicking...... any thoughts?
We could add another two buttons to step forward / backward an entire year (should be
rather straightforward), but for your example (more than 30 years delta) the only
realistic solution I see, is to type in the date.
otoh, the datepicker from icefaces is even worse... all
that ajax to select a date..... yuck.... They definately
have to improve that component.
I agree. The best calendar I've seen so far is from the Yahoo UI library
(http://developer.yahoo.com/yui/), but wrapping it into a JSF component will be a bit of a
challenge...
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:11 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350698 ]
Ronald van Kuijk commented on JBSEAM-623:
-----------------------------------------
Stephan...... it's SO EASY getting a JSF version of this component:
http://jsfcentral.com/listings/A10940;jsessionid=8C2BC7301290F207F801FBFB...
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:57 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350757 ]
Gavin King commented on JBSEAM-623:
-----------------------------------
"btw, Isn't it possible to ask the short format for the local within Java and use
that as the default format (unless a dateconverter is specified) I did not look at it
yesterday since I had to little time."
Seam has a locale built-in component which should always be used to determine the default
locale.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:32 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350768 ]
Ronald van Kuijk commented on JBSEAM-623:
-----------------------------------------
I did not mean to look up the locale itself, that should indeed be used to determine the
locale. What I meant was getting the dateformat used wirth it. If that is available in a
'handy' format, that should be used
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:37 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=comments#action_12350990 ]
Ronald van Kuijk commented on JBSEAM-623:
-----------------------------------------
my version has a side effect that the formatting is lost once there is an error .e.g. if I
enter 14-14-2007 manually (same format for the datepicker) there is an error that this
cannot be converted to a date. After this I can only enter a date with slashes instead of
dashes. Might be a problem for the other versions as well.
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.1.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:17 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Gavin King updated JBSEAM-623:
------------------------------
Fix Version/s: 1.1.5.GA
(was: 1.1.1.GA)
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.5.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:49 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-623) <s:selectDate> localization
[ http://jira.jboss.com/jira/browse/JBSEAM-623?page=all ]
Norman Richards closed JBSEAM-623.
----------------------------------
Resolution: Done
<s:selectDate> localization
---------------------------
Key: JBSEAM-623
URL: http://jira.jboss.com/jira/browse/JBSEAM-623
Project: JBoss Seam
Issue Type: Patch
Components: JSF
Affects Versions: 1.1.0.GA
Reporter: Stephan Bublava
Assigned To: Norman Richards
Priority: Minor
Fix For: 1.1.5.GA
Attachments: adding-local-to-selectdate-display.txt,
selectDate-dateFormat-patch.txt, selectdate-localization-patch-2.txt,
selectdate-localization-patch.txt
Currently <s:selectDate> is not locale-aware. This affects day names, month names,
buttons as well as the date string written to the text field via JavaScript.
selectdate-localization-patch.txt is a first step to improve this.
Changes include:
- Weekends use a distinct CSS style and can be highlighted if desired. (I've changed
the booking example to demonstrate this).
- The first day of the week is no longer harcoded to Sunday, but calculated according to
the current locale settings (e.g. Monday for German).
- Day and month names are localised as well.
Open issues:
- Weekends are hardcoded to Saturday and Sunday. I have no idea how determine this info
using Calendar, &c. APIs.
- Date formats are not kept in sync between JSF and JavaScript, which always uses
MM/DD/YYYY, regardless of the locale.
- Button names ("close", "this month") are still hardcoded.
- It might be more flexible, to translate day / month names with the application
ResourceBundle instead of using DateFormatSymbols.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7009
days inactive
7051
days old
22 comments
5 participants
participants (5)
-
Gavin King (JIRA) -
Kasper Sørensen (JIRA)
-
Norman Richards (JIRA)
-
Ronald van Kuijk (JIRA)
-
Stephan Bublava (JIRA)