5 p.m.
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package patterns
to determine which classes to pass to the JavassistInstrumentor (either via ant,maven, or
javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:30 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-4001) Wicket Instrumentation Annotation
[
https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.pl...
]
Clint Popetz reassigned JBSEAM-4001:
------------------------------------
Assignee: Clint Popetz
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Assignee: Clint Popetz
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package
patterns to determine which classes to pass to the JavassistInstrumentor (either via
ant,maven, or javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:42 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4001) Wicket Instrumentation Annotation
[
https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.pl...
]
Clint Popetz commented on JBSEAM-4001:
--------------------------------------
By the way, this annotation can't work at runtime, only at build time. In order to
instrument at runtime, we have to keep the classes in question from being loaded by the
normal webapp classloader, which we can't do unless they live in their own directory.
As far as not re-instrumented classes that have already been instrumented, that's
already fixed: https://jira.jboss.org/jira/browse/JBSEAM-3979
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Assignee: Clint Popetz
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package
patterns to determine which classes to pass to the JavassistInstrumentor (either via
ant,maven, or javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:31 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-4001) Wicket Instrumentation Annotation
[
https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.pl...
]
Clint Popetz closed JBSEAM-4001.
--------------------------------
Fix Version/s: 2.1.2.CR1
Resolution: Done
Committed r10147.
There is now a "SeamWicketComponent" annotation. Any class annotated with this,
as well as its non-static inner classes, will be instrumented, controlled in the following
way:
(a) The ant task now takes an optional "useAnnotations" attribute, which
defaults to false for backwards compatibility. You still have to pass it a set of
classes, but you can now pass the entire set of built classes and set this attribute, and
then annotate the classes you want instrumented.
(b) The runtime -javaagent approach still needs a set of packages to examine, for
efficiency, but it will only instrument classes in these packages which are annotated if
the system property -Dorg.jboss.seam.wicket.scanAnnotations=true is set.
(c) The WEB-INF/wicket approach does not respect the annotation, as it is assumed that if
you are able to select which classes go in WEB-INF/wicket, you'll select the right
ones.
(d) The maven plugin will be updated shortly to be configured for the annotation.
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Assignee: Clint Popetz
Fix For: 2.1.2.CR1
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package
patterns to determine which classes to pass to the JavassistInstrumentor (either via
ant,maven, or javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:34 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4001) Wicket Instrumentation Annotation
[
https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.pl...
]
Paul Mooney commented on JBSEAM-4001:
-------------------------------------
The maven plugin doesn't seem to have target/classes (the classesDirectory) in its
classpath when it runs. Because of this, if there are any custom TYPE targeted annotations
on any of the classes that fit the includes patterns while 'scanAnnotations' is
true, the 'JavassistInstrumentor' throws a ClassNotFoundException while making a
call to CtClass.getAnnotations().
I recommend replacing all calls to 'getAnnotations()' in
'JavassistInstrumentor' with 'getAvailableAnnotations()', which will
safely ignore anything that is not in the seam-instrument-wicket plugin's classpath.
Should this be a new JIRA issue?
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Assignee: Clint Popetz
Fix For: 2.1.2.CR1
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package
patterns to determine which classes to pass to the JavassistInstrumentor (either via
ant,maven, or javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:34 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-4001) Wicket Instrumentation Annotation
[
https://jira.jboss.org/jira/browse/JBSEAM-4001?page=com.atlassian.jira.pl...
]
Clint Popetz commented on JBSEAM-4001:
--------------------------------------
Yes please.
Wicket Instrumentation Annotation
---------------------------------
Key: JBSEAM-4001
URL: https://jira.jboss.org/jira/browse/JBSEAM-4001
Project: Seam
Issue Type: Feature Request
Components: Wicket
Reporter: Paul Mooney
Assignee: Clint Popetz
Fix For: 2.1.2.CR1
Instrument wicket classes which are annotated with a seam annotation (something like
@WicketComponent), as well as all of their non-static nested classes (including
anonymous).
This would be an alternative to the current approach of using filesets or package
patterns to determine which classes to pass to the JavassistInstrumentor (either via
ant,maven, or javaagent).
As well, if possible, this may be an alternative to placing wicket classes in
WEB-INF/wicket at runtime. In this case some configuration might be needed to
enable/disable runtime instrumentation in order to avoid attempts to re-instrument classes
which have already been instrumented at buildtime.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5580
days inactive
5593
days old
5 comments
2 participants
participants (2)
-
Clint Popetz (JIRA) -
Paul Mooney (JIRA)