[jbossseam-issues] [JBoss JIRA] Created: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
9:15 a.m.
ConcurrentModificationException on flush of ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:19 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Sanne Grinovero updated JBSEAM-3188:
------------------------------------
Attachment: JBSEAM-3188.patch
This patch avoids the ConcurrentModificationException,
but someone with a better understanding of Seam should say if
you should actually patch other code instead
to not make modifications at all.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:18 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3188:
-----------------------------------
Please attach an example which allows us to reproduce.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:21 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Sanne Grinovero commented on JBSEAM-3188:
-----------------------------------------
Hi Pete, nice to see you commenting on this.
You're absolutely right about an example, but this is hard to isolate from the complex
code, as it doesn't reveal itself in simple situations.
When using the "patch" we made we don't get the exception, so this should be
a proof of the fact that
somehow the flush method is doing some potential modification of the "additions"
HashMap.
This didn't happen in version 2.0.2 and previous.
I'll see if we manage to isolate the situation, but that seems unlikely.
Either Seam shouldn't make changes of the map in this block, or make a copy of it as
in the attached code.
What are your thoughts?
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:12 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Pete Muir commented on JBSEAM-3188:
-----------------------------------
Sure, it suggests there is a problem. However we cannot just randomly alter code in Seam
without understanding the issue therefore we need a way of reproducing.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:34 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Commented: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Jacob Orshalick commented on JBSEAM-3188:
-----------------------------------------
In converting one of the book examples to Seam 2.1 Michael and I ran into this as well.
It seems to stem from the passivate(attribute) call added by : JBSEAM-3078
From testing, it seems that as a side-effect of the call added to
passivate Wrapper instances, an invocation of: PersistenceContexts.instance() occurs in
the PassivatedEntity.passivateEntity(Object) method. If the PersistenceContexts instance
does not yet exist in the ConversationContext, an instance is created and added to the
ConversationContext.additions attribute resulting in the ConcurrentModificationException
(as in the outer loop we are iterating the additions Entry Set).
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:40 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Jacob Orshalick updated JBSEAM-3188:
------------------------------------
Attachment: JBSEAM-3188-example.zip
The attached example demonstrates the issue. A workaround in the example is to invoke:
PersistenceContexts.instance() in the: ManagerAction.sayHello() method to make it
available in the conversation context.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188-example.zip, JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:56 p.m.
New subject: [jbossseam-issues] [JBoss JIRA] Updated: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Jacob Orshalick updated JBSEAM-3188:
------------------------------------
Attachment: JBSEAM-3188-alternative.patch
This alternative patch avoids creation of a new HashSet instance. Kind of a hack though
as it creates a dependency between ServerConversationContext and PersistenceContexts by
ensuring the instance is available in the context. Other ideas?
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188-alternative.patch, JBSEAM-3188-example.zip,
JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:41 a.m.
New subject: [jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://jira.jboss.org/jira/browse/JBSEAM-3188?page=com.atlassian.jira.pl...
]
Jacob Orshalick closed JBSEAM-3188.
-----------------------------------
Resolution: Duplicate Issue
Fixed by Shane in trunk.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://jira.jboss.org/jira/browse/JBSEAM-3188
Project: Seam
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Attachments: JBSEAM-3188-alternative.patch, JBSEAM-3188-example.zip,
JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:53 a.m.
New subject: [JBoss JIRA] Commented: (JBSEAM-3188) ConcurrentModificationException on flush of ServerConversationContext
[
https://issues.jboss.org/browse/JBSEAM-3188?page=com.atlassian.jira.plugi...
]
Amar Panigrahy commented on JBSEAM-3188:
----------------------------------------
Hi everybody,
Can you all please let me know how do i integrate this patch into my code.
I am also getting ConcurrentModificationException in ServerConversationContext.flush().
I am gettihng this problem in live project, Have you all created any jar file with some
modification in origial Jar file.
If then , please share that jar file with me, Its very urgent or let me know which steps i
need to perform to resolve this issue.
I also updated my Jboss-seam.jar file to 2.1.2.But still this exception exist.
ConcurrentModificationException on flush of
ServerConversationContext
---------------------------------------------------------------------
Key: JBSEAM-3188
URL: https://issues.jboss.org/browse/JBSEAM-3188
Project: Seam 2
Issue Type: Bug
Components: Core
Affects Versions: 2.0.3.CR1
Environment: 2.0.3.CR1, JBoss 4.2.2, JDK 5
Reporter: Sanne Grinovero
Labels: patch
Attachments: JBSEAM-3188-alternative.patch, JBSEAM-3188-example.zip,
JBSEAM-3188.patch
As confirmed by other people on the forum at
http://seamframework.org/Community/ConcurrentModificationExceptionAfterPr...
It is possible for ServerConversationContext to iterate on an EntrySet which is modified
in the iteration block.
I couldn't understand exactly in which scenarios it happens, but it's easy to
patch the code
to iterate on a copy instead (I'll attach the patch).
I can't say if it's correct to make a copy, or if you should actually avoid the
changes.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4834
days inactive
5993
days old
9 comments
4 participants
participants (4)
-
Amar Panigrahy (JIRA) -
Jacob Orshalick (JIRA)
-
Pete Muir (JIRA)
-
Sanne Grinovero (JIRA)