[JBoss JIRA] (TEIID-3912) Centralize type handling for odata4
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-3912?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-3912:
-------------------------------------
No LitralParser not needed, I used that before I wrote the parseLiteral method.
>I don't think we need a separate module, just let the translator depend upon the Teiid odata module.
This is what I wanted to avoid. The Olingo libraries give the clean separation. I do not mind we write another small module for the common code.
> Centralize type handling for odata4
> -----------------------------------
>
> Key: TEIID-3912
> URL: https://issues.jboss.org/browse/TEIID-3912
> Project: Teiid
> Issue Type: Quality Risk
> Components: OData
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 9.0
>
>
> There is similar type handling logic in both the server odata4 and translator odata4 modules. This should be combined to remove duplication.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (TEIID-3912) Centralize type handling for odata4
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3912?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-3912:
---------------------------------------
> I think I did not wanted to create a Olingo common project module in the code base thus the extra class.
I don't think we need a separate module, just let the translator depend upon the Teiid odata module.
> If they are same, I would have take another look.
Yes the module.xml files are identical and in the kit there are no jars in the client common module.
> Centralize type handling for odata4
> -----------------------------------
>
> Key: TEIID-3912
> URL: https://issues.jboss.org/browse/TEIID-3912
> Project: Teiid
> Issue Type: Quality Risk
> Components: OData
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 9.0
>
>
> There is similar type handling logic in both the server odata4 and translator odata4 modules. This should be combined to remove duplication.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (TEIID-3912) Centralize type handling for odata4
by Ramesh Reddy (JIRA)
[ https://issues.jboss.org/browse/TEIID-3912?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-3912:
-------------------------------------
I think I did not wanted to create a Olingo common project module in the code base thus the extra class. "Client common" and "common" should be little different not same. Olingo has same named classes in the client as well as in server libraries which makes confusing to work. If they are same, I would have take another look.
> Centralize type handling for odata4
> -----------------------------------
>
> Key: TEIID-3912
> URL: https://issues.jboss.org/browse/TEIID-3912
> Project: Teiid
> Issue Type: Quality Risk
> Components: OData
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 9.0
>
>
> There is similar type handling logic in both the server odata4 and translator odata4 modules. This should be combined to remove duplication.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (TEIID-3912) Centralize type handling for odata4
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-3912?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-3912:
---------------------------------------
What is the benefit in the separation?
> Also I think the client has different dependency structure on the Olingo
The translator has a org/apache/olingo/client/common module that is identical to the server org/apache/olingo/common module - it even in the module.xml declares itself as the org.apache.olingo.common module. It seems like the duplicate module in the translator could be removed.
Beyond that the odata client and server modules are different, but that would remain even if translator referenced the server odata module.
> Centralize type handling for odata4
> -----------------------------------
>
> Key: TEIID-3912
> URL: https://issues.jboss.org/browse/TEIID-3912
> Project: Teiid
> Issue Type: Quality Risk
> Components: OData
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Fix For: 9.0
>
>
> There is similar type handling logic in both the server odata4 and translator odata4 modules. This should be combined to remove duplication.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (TEIID-3912) Centralize type handling for odata4
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-3912:
-------------------------------------
Summary: Centralize type handling for odata4
Key: TEIID-3912
URL: https://issues.jboss.org/browse/TEIID-3912
Project: Teiid
Issue Type: Quality Risk
Components: OData
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Fix For: 9.0
There is similar type handling logic in both the server odata4 and translator odata4 modules. This should be combined to remove duplication.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months