[JBoss JIRA] (TEIID-5118) Osisoft Translator - NPE when using ORDER BY
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/TEIID-5118?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on TEIID-5118:
------------------------------------------------
Van Halbert <vhalbert(a)redhat.com> changed the Status of [bug 1505739|https://bugzilla.redhat.com/show_bug.cgi?id=1505739] from MODIFIED to ON_QA
> Osisoft Translator - NPE when using ORDER BY
> --------------------------------------------
>
> Key: TEIID-5118
> URL: https://issues.jboss.org/browse/TEIID-5118
> Project: Teiid
> Issue Type: Bug
> Components: JDBC Connector
> Affects Versions: 8.12.x-6.4
> Reporter: Andrej Šmigala
> Assignee: Ramesh Reddy
> Priority: Critical
> Labels: CR2
> Fix For: 10.0, 8.12.x-6.4
>
> Attachments: osisoft-pi-vdb.xml
>
>
> Any query with an ORDER BY clause run against Osisoft PI datasource fails with a NullPointerException
> Stack trace:
> {noformat}
> 10:17:09,235 ERROR [org.teiid.CONNECTOR] (Worker3_QueryProcessorQueue17) Connector worker process failed for atomic-request=mcBkcBzOiieD.5.0.5: java.lang.NullPointerException
> at org.teiid.translator.jdbc.pi.PISQLConversionVisitor.visit(PISQLConversionVisitor.java:157) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.language.ColumnReference.acceptVisitor(ColumnReference.java:72) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.AbstractLanguageVisitor.visitNode(AbstractLanguageVisitor.java:51) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.SQLStringVisitor.append(SQLStringVisitor.java:91) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.translator.jdbc.SQLConversionVisitor.append(SQLConversionVisitor.java:130) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.language.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:737) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.SortSpecification.acceptVisitor(SortSpecification.java:53) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.AbstractLanguageVisitor.visitNode(AbstractLanguageVisitor.java:51) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.SQLStringVisitor.append(SQLStringVisitor.java:91) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.translator.jdbc.SQLConversionVisitor.append(SQLConversionVisitor.java:130) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.language.visitor.SQLStringVisitor.append(SQLStringVisitor.java:102) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:733) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.OrderBy.acceptVisitor(OrderBy.java:45) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.AbstractLanguageVisitor.visitNode(AbstractLanguageVisitor.java:51) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.SQLStringVisitor.append(SQLStringVisitor.java:91) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.translator.jdbc.SQLConversionVisitor.append(SQLConversionVisitor.java:130) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.language.visitor.SQLStringVisitor.visit(SQLStringVisitor.java:790) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.Select.acceptVisitor(Select.java:110) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.AbstractLanguageVisitor.visitNode(AbstractLanguageVisitor.java:51) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.language.visitor.SQLStringVisitor.append(SQLStringVisitor.java:91) [teiid-api-8.12.11.6_4-redhat-64-6.jar:8.12.11.6_4-redhat-64-6]
> at org.teiid.translator.jdbc.SQLConversionVisitor.append(SQLConversionVisitor.java:130) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.translator.jdbc.TranslatedCommand.translateCommand(TranslatedCommand.java:76) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.translator.jdbc.JDBCBaseExecution.translateCommand(JDBCBaseExecution.java:120) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.translator.jdbc.JDBCQueryExecution.execute(JDBCQueryExecution.java:114) [translator-jdbc-8.12.11.6_4.jar:8.12.11.6_4]
> at org.teiid.dqp.internal.datamgr.ConnectorWorkItem.execute(ConnectorWorkItem.java:363)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [rt.jar:1.8.0_141]
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) [rt.jar:1.8.0_141]
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [rt.jar:1.8.0_141]
> at java.lang.reflect.Method.invoke(Method.java:498) [rt.jar:1.8.0_141]
> at org.teiid.dqp.internal.datamgr.ConnectorManager$1.invoke(ConnectorManager.java:211)
> at com.sun.proxy.$Proxy79.execute(Unknown Source)
> at org.teiid.dqp.internal.process.DataTierTupleSource.getResults(DataTierTupleSource.java:306)
> at org.teiid.dqp.internal.process.DataTierTupleSource$1.call(DataTierTupleSource.java:112)
> at org.teiid.dqp.internal.process.DataTierTupleSource$1.call(DataTierTupleSource.java:108)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266) [rt.jar:1.8.0_141]
> at org.teiid.dqp.internal.process.FutureWork.run(FutureWork.java:65)
> at org.teiid.dqp.internal.process.DQPWorkContext.runInContext(DQPWorkContext.java:280)
> at org.teiid.dqp.internal.process.ThreadReuseExecutor$RunnableWrapper.run(ThreadReuseExecutor.java:119)
> at org.teiid.dqp.internal.process.ThreadReuseExecutor$3.run(ThreadReuseExecutor.java:210)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [rt.jar:1.8.0_141]
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [rt.jar:1.8.0_141]
> at java.lang.Thread.run(Thread.java:748) [rt.jar:1.8.0_141]
> {noformat}
> I tried remote debugging the server process and it appears that when running query such as
> {code:sql}
> SELECT FloatNum FROM BQT1.SmallA ORDER BY FloatNum ASC
> {code}
> the PISQLConversionVisitor.visit(ColumnReference obj) is called twice, the first time the ColumnReference object has value "g_0.FloatNum" and all fields set, the second time the object has only name set to "c_2" and nothing else (table, metadata object etc).
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5176) Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-5176?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5176.
-----------------------------------
Resolution: Done
Updated the script reader to modify function names as well. This isolates the change to only the pg transport.
> Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
> ------------------------------------------------------------------------------
>
> Key: TEIID-5176
> URL: https://issues.jboss.org/browse/TEIID-5176
> Project: Teiid
> Issue Type: Quality Risk
> Components: ODBC
> Reporter: Debbie Steigner
> Assignee: Steven Hawkins
> Fix For: 10.1, 10.0.2
>
>
> Customer is using tableau which converts to a SQL statement that includes nested concat function calls like [1]. The Postgresql ODBC driver appears to interpret those {fn CONCAT()} calls and converts to a "textcat()" function, which then results in a parsing error from Teiid since we don't support a textcat() function.
> [1] {fn CONCAT({fn CONCAT("TripSourceHotelBooking"."HotelCity", ', ')}, "TripSourceHotelBooking"."HotelCountry")} AS "Calculation_984036526439337984",
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5162) Google Spreadsheet translator after update unaffected columns are set to null
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/TEIID-5162?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on TEIID-5162:
------------------------------------------------
Van Halbert <vhalbert(a)redhat.com> changed the Status of [bug 1515136|https://bugzilla.redhat.com/show_bug.cgi?id=1515136] from MODIFIED to ON_QA
> Google Spreadsheet translator after update unaffected columns are set to null
> -----------------------------------------------------------------------------
>
> Key: TEIID-5162
> URL: https://issues.jboss.org/browse/TEIID-5162
> Project: Teiid
> Issue Type: Bug
> Components: Misc. Connectors
> Affects Versions: 8.12.x-6.4
> Reporter: Jan Stastny
> Assignee: Steven Hawkins
> Priority: Blocker
>
> There is loss of data when performing update on Google Spreadsheet.
> Initial data:
> {code:sql}
> INSERT INTO SmallA_Direct (IntKey, StringKey, IntNum, StringNum) VALUES (1, '1', 1, '1'), (2, '2', 2, '2'), (3, '3', 3, '3'), (4, '4', 4, '4'), (5, '5', 5, '5')
> {code}
> Then a {code}SELECT * FROM SmallA_Direct{code} results in:
> |1|1|1|1|
> |2|2|2|2|
> |3|3|3|3|
> |4|4|4|4|
> |5|5|5|5|
> Following update:
> {code:sql}
> UPDATE SmallA_Direct SET IntNum = NULL WHERE IntNum >= 3
> {code}
> Results in following data returned by {code}SELECT * FROM SmallA_Direct{code}:
> |1|<null>|1|<null>|
> |2|<null>|2|<null>|
> |3|3.0|<null>|3.0|
> |4|4.0|<null>|4.0|
> |5|5.0|<null>|5.0|
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5137) SystemAdmin.usage column dependency issue
by RH Bugzilla Integration (JIRA)
[ https://issues.jboss.org/browse/TEIID-5137?page=com.atlassian.jira.plugin... ]
RH Bugzilla Integration commented on TEIID-5137:
------------------------------------------------
Van Halbert <vhalbert(a)redhat.com> changed the Status of [bug 1500505|https://bugzilla.redhat.com/show_bug.cgi?id=1500505] from MODIFIED to ON_QA
> SystemAdmin.usage column dependency issue
> -----------------------------------------
>
> Key: TEIID-5137
> URL: https://issues.jboss.org/browse/TEIID-5137
> Project: Teiid
> Issue Type: Bug
> Components: Server
> Affects Versions: 8.12.x-6.4
> Reporter: Van Halbert
> Assignee: Steven Hawkins
> Fix For: 8.12.x-6.4, 9.3.5, 10.1, 10.0.1
>
>
> For "object_type" == "Column", the field "Name" should be the name of the table.
> Here it is the same value of "ElementName" fields (ie column name).
> {code}
> {
> "VDBName" => "Financials",
> "UID" => "tid:252cb13c7440-0c0428eb-0000000d",
> "object_type" => "Column",
> "SchemaName" => "ACCOUNTHOLDINGS",
> "Name" => "PRODUCTID",
> "ElementName" => "PRODUCTID",
> "Uses_UID" => "tid:694b1432214b-cbf6d637-0000000d",
> "Uses_object_type" => "Column",
> "Uses_SchemaName" => "EU_Customers_EDL",
> "Uses_Name" => "ACCOUNTHOLDINGS",
> "Uses_ElementName" => "PRODUCTID"
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5177) Enforce stricter naming in SQL/DDL
by Steven Hawkins (JIRA)
Steven Hawkins created TEIID-5177:
-------------------------------------
Summary: Enforce stricter naming in SQL/DDL
Key: TEIID-5177
URL: https://issues.jboss.org/browse/TEIID-5177
Project: Teiid
Issue Type: Bug
Components: Query Engine
Reporter: Steven Hawkins
Assignee: Steven Hawkins
Multi-part identifiers in Teiid SQL have lax handling due to an early design decision to allow Teiid queries to mimic any naming/quoting used in a native query. The side effects of this is that '.' is not allowed in a column nor schema name, that quoting is effectively ignored - for example using a multi-part identifier in a DDL create does not scope to that schema:
create view "foo"."bar" ...
creates "foo.bar" in the current schema rather than bar in the foo schema.
We should at least introduce flags for strict handling and make sure ddl is compatible as possible.
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5176) Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-5176?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5176:
----------------------------------
Issue Type: Quality Risk (was: Bug)
Component/s: ODBC
Fix Version/s: 10.1
10.0.2
> Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
> ------------------------------------------------------------------------------
>
> Key: TEIID-5176
> URL: https://issues.jboss.org/browse/TEIID-5176
> Project: Teiid
> Issue Type: Quality Risk
> Components: ODBC
> Reporter: Debbie Steigner
> Assignee: Steven Hawkins
> Fix For: 10.1, 10.0.2
>
>
> Customer is using tableau which converts to a SQL statement that includes nested concat function calls like [1]. The Postgresql ODBC driver appears to interpret those {fn CONCAT()} calls and converts to a "textcat()" function, which then results in a parsing error from Teiid since we don't support a textcat() function.
> [1] {fn CONCAT({fn CONCAT("TripSourceHotelBooking"."HotelCity", ', ')}, "TripSourceHotelBooking"."HotelCountry")} AS "Calculation_984036526439337984",
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months
[JBoss JIRA] (TEIID-5176) Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
by Steven Hawkins (JIRA)
[ https://issues.jboss.org/browse/TEIID-5176?page=com.atlassian.jira.plugin... ]
Work on TEIID-5176 started by Steven Hawkins.
---------------------------------------------
> Postgresql ODBC driver converts {fn CONCAT()} calls to a "textcat()" function
> ------------------------------------------------------------------------------
>
> Key: TEIID-5176
> URL: https://issues.jboss.org/browse/TEIID-5176
> Project: Teiid
> Issue Type: Quality Risk
> Components: ODBC
> Reporter: Debbie Steigner
> Assignee: Steven Hawkins
> Fix For: 10.1, 10.0.2
>
>
> Customer is using tableau which converts to a SQL statement that includes nested concat function calls like [1]. The Postgresql ODBC driver appears to interpret those {fn CONCAT()} calls and converts to a "textcat()" function, which then results in a parsing error from Teiid since we don't support a textcat() function.
> [1] {fn CONCAT({fn CONCAT("TripSourceHotelBooking"."HotelCity", ', ')}, "TripSourceHotelBooking"."HotelCountry")} AS "Calculation_984036526439337984",
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 3 months