[JBoss JIRA] (TEIID-5563) Separate the Teiid WildFly distribution into their own repo or module
by Ramesh Reddy (Jira)
[ https://issues.jboss.org/browse/TEIID-5563?page=com.atlassian.jira.plugin... ]
Ramesh Reddy commented on TEIID-5563:
-------------------------------------
[~van.halbert] Another option is to leave the current repo as is to begin with and follow this way to create your clone https://stackoverflow.com/questions/16052477/delete-fork-dependency-of-a-... then edit the clone that way we can keep all the version history directory structures etc. We need to keep version history if possible at all.
> Separate the Teiid WildFly distribution into their own repo or module
> ---------------------------------------------------------------------
>
> Key: TEIID-5563
> URL: https://issues.jboss.org/browse/TEIID-5563
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits, Integration Tests
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
>
> With the different types of distributions now being built based on Teiid like
> * WildFly
> * Thorntail
> * SpringBoot
> * Embedded
> Having main `github.com/teiid` repo contain artifacts for WildFly distribution poses an unnecessary dependency burden on other distributions. For example, the resource adapters are mainly for use with WildFly and Thorntail V2. They can still be applicable to embedded and SpringBoot as either non-managed connection factories, or require the user to provide appropriate management / pooling. When they are pulled into environments like SpringBoot they will bring several wildfly dependencies / and JEE constructs that are unnecessary - specifically the dependencies jboss-jaxws-api (teiid-api), javax.activation (teiid-core), jboss-transaction-api (teiid-api), and jboss-connector-api (teiid-api).
> This proposal is to separate "teiid" core modules along with all translators into one repository and move all the resource adapters along with any feature-packs and module building into a sperate repository like "teiid-wildfly". With the goal of providing similar connectivity in SpringBoot using as much common logic from SpringBoot (Spring Data in particular) and even Fuse as possible.
> Basically, when finished, the core Teiid modules only provide Maven artifacts along with their clean pom.xml with for direct and maybe transitive dependencies. None of the WildFly based modules support will be here. At worst this may introduce duplicate dependencies into the WildFly environment as we will need to manage all core / translator dependencies independently from those provided by WildFly. Where possible the teiid-api / core modules will need to use the generic javax dependency - or even remove the dependency if possible.
> The "teiid-wildfly" module on the other hand, will exactly preserve what is in the current repo as far feature packs and module building and overall WildFly distribution building.
> A follow-on task we can task we can look into is, converting the main teiid then to use basepom rather than the jboss-parent pom. However, the recommendation is this should be done after, not simultaneously.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5566:
----------------------------------
Attachment: (was: missing_dep_plan.txt)
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
>
> This query:
> Edit: <I was asked to remove the query text from the top level description>
> The query is between three different databases chained together with joins (see plans).
> does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5566:
----------------------------------
Attachment: (was: missing_dep_inner_plan.txt)
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
>
> This query:
> Edit: <I was asked to remove the query text from the top level description>
> The query is between three different databases chained together with joins (see plans).
> does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5566:
----------------------------------
Attachment: (was: missing_dep_inner_debugplan.txt)
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
> Attachments: missing_dep_inner_plan.txt, missing_dep_plan.txt
>
>
> This query:
> Edit: <I was asked to remove the query text from the top level description>
> The query is between three different databases chained together with joins (see plans).
> does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Steven Hawkins updated TEIID-5566:
----------------------------------
Attachment: (was: missing_dep_debugplan.txt)
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
> Attachments: missing_dep_inner_plan.txt, missing_dep_plan.txt
>
>
> This query:
> Edit: <I was asked to remove the query text from the top level description>
> The query is between three different databases chained together with joins (see plans).
> does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5563) Separate the Teiid WildFly distribution into their own repo or module
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5563?page=com.atlassian.jira.plugin... ]
Steven Hawkins commented on TEIID-5563:
---------------------------------------
[~rhn-engineering-vhalbert] start with this as a module before moving to a different repo.
> Separate the Teiid WildFly distribution into their own repo or module
> ---------------------------------------------------------------------
>
> Key: TEIID-5563
> URL: https://issues.jboss.org/browse/TEIID-5563
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits, Integration Tests
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
>
> With the different types of distributions now being built based on Teiid like
> * WildFly
> * Thorntail
> * SpringBoot
> * Embedded
> Having main `github.com/teiid` repo contain artifacts for WildFly distribution poses an unnecessary dependency burden on other distributions. For example, the resource adapters are mainly for use with WildFly and Thorntail V2. They can still be applicable to embedded and SpringBoot as either non-managed connection factories, or require the user to provide appropriate management / pooling. When they are pulled into environments like SpringBoot they will bring several wildfly dependencies / and JEE constructs that are unnecessary - specifically the dependencies jboss-jaxws-api (teiid-api), javax.activation (teiid-core), jboss-transaction-api (teiid-api), and jboss-connector-api (teiid-api).
> This proposal is to separate "teiid" core modules along with all translators into one repository and move all the resource adapters along with any feature-packs and module building into a sperate repository like "teiid-wildfly". With the goal of providing similar connectivity in SpringBoot using as much common logic from SpringBoot (Spring Data in particular) and even Fuse as possible.
> Basically, when finished, the core Teiid modules only provide Maven artifacts along with their clean pom.xml with for direct and maybe transitive dependencies. None of the WildFly based modules support will be here. At worst this may introduce duplicate dependencies into the WildFly environment as we will need to manage all core / translator dependencies independently from those provided by WildFly. Where possible the teiid-api / core modules will need to use the generic javax dependency - or even remove the dependency if possible.
> The "teiid-wildfly" module on the other hand, will exactly preserve what is in the current repo as far feature packs and module building and overall WildFly distribution building.
> A follow-on task we can task we can look into is, converting the main teiid then to use basepom rather than the jboss-parent pom. However, the recommendation is this should be done after, not simultaneously.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Mike Higgins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Mike Higgins updated TEIID-5566:
--------------------------------
Description:
This query:
Edit: <I was asked to remove the query text from the top level description>
The query is between three different databases chained together with joins (see plans).
does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
was:
This query:
SELECT MEDS_OWNER.COMPOUND."COMPOUND_SEQ_ID", MEDS_OWNER.COMPOUND."COMPOUND_NUMBER", MEDS_OWNER.PARENT_EQUIV_V."COMPOUND_PARENT",
SCR_BATCH_INFO."PARENT_ID", SCR_BATCH_INFO."BATCH_NUMBER", SCR_EVT."COMPOUND_NUMBER", SCR_EVT."BATCH_TRACKING_ID",
SCR_PRJ."PGRD_THRPC_AREA_CHAR_TYPE", SCR_PRJ."PGRD_PROJ_SHORT_DESC", SCR_EVT."PGRD_PROJECT_CODE",
SCR_SITE."RSCH_SITE_SHORT_DESC", SCR_EVT."RSCH_SITE_CODE", SCR_EVT."CMPD_BATCH_EVENT_CODE",
SCR_EVT."CMPD_BTCH_SCR_EVENT_TS", SCR_SCREEN_INFO."SCR_PRTCL_SHORT_DESC", SCR_SCREEN_INFO."SCR_PRTCL_SHORT_NAME",
SCR_EVT."CMPD_BTCH_SCR_EVT_KEY"
FROM meds_owner.compound
LEFT OUTER JOIN meds_owner.parent AllParentCompounds ON (MEDS_OWNER.COMPOUND."PARENT_SEQ_ID" = AllParentCompounds."PARENT_SEQ_ID") LEFT OUTER JOIN meds_owner.parent_equiv_v
ON (AllParentCompounds."PARENT_SEQ_ID_EQV" = MEDS_OWNER.PARENT_EQUIV_V."PARENT_SEQ_ID")
LEFT OUTER /* inner join works */ JOIN (rifdm4.dmf_cet_cmpd_btch_scr_events SCR_EVT LEFT OUTER JOIN rifdwn_wp.dwn_pgrd_projects_v SCR_PRJ
ON (SCR_EVT."PGRD_PROJECT_CODE" = SCR_PRJ."PGRD_PROJECT_CODE")
LEFT OUTER JOIN rifods.ods_research_sites SCR_SITE ON (SCR_EVT."RSCH_SITE_CODE" = SCR_SITE."RSCH_SITE_CODE")
LEFT OUTER JOIN rifdwh.dw_screen_protocols SCR_SCREEN_INFO ON (SCR_EVT."SCREEN_PROTOCOL_ID" = SCR_SCREEN_INFO."SCR_PRTCL_ID"))
ON (((MEDS_OWNER.COMPOUND."COMPOUND_NUMBER" = SCR_EVT."COMPOUND_NUMBER")
AND (SCR_EVT."CMPD_BATCH_EVENT_CODE"
IN ('EXPSTART', 'EXPEND', 'EXPPUB')))
AND ((SCR_EVT."CBTCH_EVENT_SRC_DEL_IND" = 'N')
AND ((SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPSTART')
OR (SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPEND')
OR (SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPPUB'))))
LEFT OUTER JOIN rifdm1.cpm_compound_batch SCR_BATCH_INFO ON (SCR_EVT."BATCH_TRACKING_ID" = SCR_BATCH_INFO."BATCH_TRACKING_NO")
WHERE MEDS_OWNER.COMPOUND."COMPOUND_SEQ_ID" IN (21475535)
option makedep SCR_EVT, SCR_BATCH_INFO
does not create a dependent join on the SCR_EVT table. If you change the join to SCR_EVT to inner, it does.
Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
> Attachments: missing_dep_debugplan.txt, missing_dep_inner_debugplan.txt, missing_dep_inner_plan.txt, missing_dep_plan.txt
>
>
> This query:
> Edit: <I was asked to remove the query text from the top level description>
> The query is between three different databases chained together with joins (see plans).
> does not create a dependent join on the middle table. If you change the join to the middle table to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5563) Separate the Teiid WildFly distribution into their own repo or module
by Van Halbert (Jira)
[ https://issues.jboss.org/browse/TEIID-5563?page=com.atlassian.jira.plugin... ]
Work on TEIID-5563 started by Van Halbert.
------------------------------------------
> Separate the Teiid WildFly distribution into their own repo or module
> ---------------------------------------------------------------------
>
> Key: TEIID-5563
> URL: https://issues.jboss.org/browse/TEIID-5563
> Project: Teiid
> Issue Type: Task
> Components: Build/Kits, Integration Tests
> Affects Versions: 12.x
> Reporter: Van Halbert
> Assignee: Van Halbert
> Priority: Major
>
> With the different types of distributions now being built based on Teiid like
> * WildFly
> * Thorntail
> * SpringBoot
> * Embedded
> Having main `github.com/teiid` repo contain artifacts for WildFly distribution poses an unnecessary dependency burden on other distributions. For example, the resource adapters are mainly for use with WildFly and Thorntail V2. They can still be applicable to embedded and SpringBoot as either non-managed connection factories, or require the user to provide appropriate management / pooling. When they are pulled into environments like SpringBoot they will bring several wildfly dependencies / and JEE constructs that are unnecessary - specifically the dependencies jboss-jaxws-api (teiid-api), javax.activation (teiid-core), jboss-transaction-api (teiid-api), and jboss-connector-api (teiid-api).
> This proposal is to separate "teiid" core modules along with all translators into one repository and move all the resource adapters along with any feature-packs and module building into a sperate repository like "teiid-wildfly". With the goal of providing similar connectivity in SpringBoot using as much common logic from SpringBoot (Spring Data in particular) and even Fuse as possible.
> Basically, when finished, the core Teiid modules only provide Maven artifacts along with their clean pom.xml with for direct and maybe transitive dependencies. None of the WildFly based modules support will be here. At worst this may introduce duplicate dependencies into the WildFly environment as we will need to manage all core / translator dependencies independently from those provided by WildFly. Where possible the teiid-api / core modules will need to use the generic javax dependency - or even remove the dependency if possible.
> The "teiid-wildfly" module on the other hand, will exactly preserve what is in the current repo as far feature packs and module building and overall WildFly distribution building.
> A follow-on task we can task we can look into is, converting the main teiid then to use basepom rather than the jboss-parent pom. However, the recommendation is this should be done after, not simultaneously.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months
[JBoss JIRA] (TEIID-5566) Outer join prevents dependent join creation
by Steven Hawkins (Jira)
[ https://issues.jboss.org/browse/TEIID-5566?page=com.atlassian.jira.plugin... ]
Steven Hawkins resolved TEIID-5566.
-----------------------------------
Fix Version/s: 11.1.2
12.0
11.2.2
Resolution: Done
Updated the logic in rule plan outer joins to promote hints that would otherwise not be honored. See the workaround using the preserve hint for unpatched versions.
> Outer join prevents dependent join creation
> -------------------------------------------
>
> Key: TEIID-5566
> URL: https://issues.jboss.org/browse/TEIID-5566
> Project: Teiid
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: 11.0.1
> Reporter: Mike Higgins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 11.1.2, 12.0, 11.2.2
>
> Attachments: missing_dep_debugplan.txt, missing_dep_inner_debugplan.txt, missing_dep_inner_plan.txt, missing_dep_plan.txt
>
>
> This query:
> SELECT MEDS_OWNER.COMPOUND."COMPOUND_SEQ_ID", MEDS_OWNER.COMPOUND."COMPOUND_NUMBER", MEDS_OWNER.PARENT_EQUIV_V."COMPOUND_PARENT",
> SCR_BATCH_INFO."PARENT_ID", SCR_BATCH_INFO."BATCH_NUMBER", SCR_EVT."COMPOUND_NUMBER", SCR_EVT."BATCH_TRACKING_ID",
> SCR_PRJ."PGRD_THRPC_AREA_CHAR_TYPE", SCR_PRJ."PGRD_PROJ_SHORT_DESC", SCR_EVT."PGRD_PROJECT_CODE",
> SCR_SITE."RSCH_SITE_SHORT_DESC", SCR_EVT."RSCH_SITE_CODE", SCR_EVT."CMPD_BATCH_EVENT_CODE",
> SCR_EVT."CMPD_BTCH_SCR_EVENT_TS", SCR_SCREEN_INFO."SCR_PRTCL_SHORT_DESC", SCR_SCREEN_INFO."SCR_PRTCL_SHORT_NAME",
> SCR_EVT."CMPD_BTCH_SCR_EVT_KEY"
> FROM meds_owner.compound
> LEFT OUTER JOIN meds_owner.parent AllParentCompounds ON (MEDS_OWNER.COMPOUND."PARENT_SEQ_ID" = AllParentCompounds."PARENT_SEQ_ID") LEFT OUTER JOIN meds_owner.parent_equiv_v
> ON (AllParentCompounds."PARENT_SEQ_ID_EQV" = MEDS_OWNER.PARENT_EQUIV_V."PARENT_SEQ_ID")
> LEFT OUTER /* inner join works */ JOIN (rifdm4.dmf_cet_cmpd_btch_scr_events SCR_EVT LEFT OUTER JOIN rifdwn_wp.dwn_pgrd_projects_v SCR_PRJ
> ON (SCR_EVT."PGRD_PROJECT_CODE" = SCR_PRJ."PGRD_PROJECT_CODE")
> LEFT OUTER JOIN rifods.ods_research_sites SCR_SITE ON (SCR_EVT."RSCH_SITE_CODE" = SCR_SITE."RSCH_SITE_CODE")
> LEFT OUTER JOIN rifdwh.dw_screen_protocols SCR_SCREEN_INFO ON (SCR_EVT."SCREEN_PROTOCOL_ID" = SCR_SCREEN_INFO."SCR_PRTCL_ID"))
> ON (((MEDS_OWNER.COMPOUND."COMPOUND_NUMBER" = SCR_EVT."COMPOUND_NUMBER")
> AND (SCR_EVT."CMPD_BATCH_EVENT_CODE"
> IN ('EXPSTART', 'EXPEND', 'EXPPUB')))
> AND ((SCR_EVT."CBTCH_EVENT_SRC_DEL_IND" = 'N')
> AND ((SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPSTART')
> OR (SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPEND')
> OR (SCR_EVT."CMPD_BATCH_EVENT_CODE" = 'EXPPUB'))))
> LEFT OUTER JOIN rifdm1.cpm_compound_batch SCR_BATCH_INFO ON (SCR_EVT."BATCH_TRACKING_ID" = SCR_BATCH_INFO."BATCH_TRACKING_NO")
> WHERE MEDS_OWNER.COMPOUND."COMPOUND_SEQ_ID" IN (21475535)
> option makedep SCR_EVT, SCR_BATCH_INFO
> does not create a dependent join on the SCR_EVT table. If you change the join to SCR_EVT to inner, it does.
> Plans and debug plans for both cases are attached. As a note, an older version of Teiid that we are also using (9.3.4) always creates the dependent join. 11.0.1 and 10.2.3 do not create the dependent join if the table is outer joined.
--
This message was sent by Atlassian Jira
(v7.12.1#712002)
7 years, 4 months