[JBoss JIRA] (TEIID-5895) Review/create common mongodb logic
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5895?page=com.atlassian.jira.plugi... ]
Steven Hawkins resolved TEIID-5895.
-----------------------------------
Resolution: Done
It looks like TEIID-5611 did all that is needed as there is no more common logic to capture in the connection impl - and no need at this time to switch to something other than the deprecated DB. When that happens we can revisit if a common base is needed.
> Review/create common mongodb logic
> ----------------------------------
>
> Key: TEIID-5895
> URL: https://issues.redhat.com/browse/TEIID-5895
> Project: Teiid
> Issue Type: Quality Risk
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
>
> Similar to the refactoring of infinispan connectivity, the logic should be shared between teiid and teiid spring boot. As well as a review of similar potential issues with the join filtering and TEIID-5876
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5895) Review/create common mongodb logic
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5895?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5895:
----------------------------------
Original Estimate: 4 hours
Remaining Estimate: 4 hours
> Review/create common mongodb logic
> ----------------------------------
>
> Key: TEIID-5895
> URL: https://issues.redhat.com/browse/TEIID-5895
> Project: Teiid
> Issue Type: Quality Risk
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> Similar to the refactoring of infinispan connectivity, the logic should be shared between teiid and teiid spring boot. As well as a review of similar potential issues with the join filtering and TEIID-5876
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5895) Review/create common mongodb logic
by Ramesh Reddy (Jira)
[ https://issues.redhat.com/browse/TEIID-5895?page=com.atlassian.jira.plugi... ]
Ramesh Reddy commented on TEIID-5895:
-------------------------------------
> if an fk is created, it will allow a join to be pushed down, which is not expected
I did not understand why it should not be pushed, is the query using `fqn` to build query so this is verbose?
> Review/create common mongodb logic
> ----------------------------------
>
> Key: TEIID-5895
> URL: https://issues.redhat.com/browse/TEIID-5895
> Project: Teiid
> Issue Type: Quality Risk
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
>
> Similar to the refactoring of infinispan connectivity, the logic should be shared between teiid and teiid spring boot. As well as a review of similar potential issues with the join filtering and TEIID-5876
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5913) Assist with productization of the documentation
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5913?focusedWorklogId=12450514&pag... ]
Steven Hawkins logged work on TEIID-5913:
-----------------------------------------
Author: Steven Hawkins
Created on: 13/Mar/20 12:05 PM
Start Date: 13/Mar/20 12:05 PM
Worklog Time Spent: 1 hour
Issue Time Tracking
-------------------
Time Spent: 2 days, 1 hour, 30 minutes (was: 2 days, 30 minutes)
Worklog Id: (was: 12450514)
> Assist with productization of the documentation
> -----------------------------------------------
>
> Key: TEIID-5913
> URL: https://issues.redhat.com/browse/TEIID-5913
> Project: Teiid
> Issue Type: Task
> Components: Documentation
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.x
>
> Original Estimate: 1 day, 2 hours
> Time Spent: 2 days, 1 hour, 30 minutes
> Remaining Estimate: 0 minutes
>
> Assist the documentation team in merging changes and keeping the community docs building.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5650) MongoDB: The DB interface is deprecated
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5650?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5650:
---------------------------------------
It appears that there is no schedule set for the removal of the method based upon their source code, so this is not a priority.
> MongoDB: The DB interface is deprecated
> ---------------------------------------
>
> Key: TEIID-5650
> URL: https://issues.redhat.com/browse/TEIID-5650
> Project: Teiid
> Issue Type: Task
> Components: Misc. Connectors
> Affects Versions: 12.0
> Reporter: Ramesh Reddy
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 13.x
>
>
> The interface that presents the connection to the MongoDB `MongoDBConnection` uses interface `DB` from Mongo driver is deprecated and slated to removed in future versions of the Mongo Driver Java client. This needs to be updated to `MongoDatabase` interface.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5876) MongoDB import name conflict issues
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5876?page=com.atlassian.jira.plugi... ]
Steven Hawkins reopened TEIID-5876:
-----------------------------------
So that would be a breaking change from existing functionality, so it would need to be enabled by a property. That will create tables like:
parent_embedded...
> MongoDB import name conflict issues
> -----------------------------------
>
> Key: TEIID-5876
> URL: https://issues.redhat.com/browse/TEIID-5876
> Project: Teiid
> Issue Type: Bug
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
> Original Estimate: 4 hours
> Time Spent: 2 hours
> Remaining Estimate: 2 hours
>
> There are two issues with the import logic and naming:
> 1. There's an assumption that any table in the schema was created by the mongodb import. In general this is not true as other imports or ddl may have already run.
> 2. If a child construct has a field name that matches an existing table, the two entities will get intertwined in the metadata, which is invalid.
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5895) Review/create common mongodb logic
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5895?page=com.atlassian.jira.plugi... ]
Steven Hawkins updated TEIID-5895:
----------------------------------
Summary: Review/create common mongodb logic (was: Create common mongodb logic)
> Review/create common mongodb logic
> ----------------------------------
>
> Key: TEIID-5895
> URL: https://issues.redhat.com/browse/TEIID-5895
> Project: Teiid
> Issue Type: Quality Risk
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
>
> Similar to the refactoring of infinispan connectivity, the logic should be shared between teiid and teiid spring boot. As well as a review of similar potential issues with the join filtering and TEIID-5876
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years
[JBoss JIRA] (TEIID-5895) Create common mongodb logic
by Steven Hawkins (Jira)
[ https://issues.redhat.com/browse/TEIID-5895?page=com.atlassian.jira.plugi... ]
Steven Hawkins commented on TEIID-5895:
---------------------------------------
It appears that the join logic is quite specialized to the embedded doc case, so the only issue I see with the mongo join logic is around DBRef construct. The issues are:
* the lookup is based upon name name, which does not account for conflicts - TEIID-5876
* it does not account for exclusions or other reasons why a collection may not be present and create a dangling fk - which is already present in the metadata tests
* if an fk is created, it will allow a join to be pushed down, which is not expected
based upon the above issues, I'll simply remove the creation of the fk.
> Create common mongodb logic
> ---------------------------
>
> Key: TEIID-5895
> URL: https://issues.redhat.com/browse/TEIID-5895
> Project: Teiid
> Issue Type: Quality Risk
> Components: Misc. Connectors
> Reporter: Steven Hawkins
> Assignee: Steven Hawkins
> Priority: Major
> Fix For: 14.0
>
>
> Similar to the refactoring of infinispan connectivity, the logic should be shared between teiid and teiid spring boot. As well as a review of similar potential issues with the join filtering and TEIID-5876
--
This message was sent by Atlassian Jira
(v7.13.8#713008)
6 years