Re: [weld-dev] TCK on Policy Tests

I agree, this slipped through due to a late change in the spec in this area. Can we get a JIRA issue filed? Thanks Gurkan :-) On 7 Jan 2010, at 10:10, Jozef Hartinger wrote: > On 01/06/2010 08:14 PM, Gurkan Erdogdu wrote: >> Hi; >> >> I am currently testing >> org.jboss.jsr299.tck.tests.policy.PolicyAvailabilityTest. My questions >> are on the following test methods >> >> - testProducerPoliciesOnClass >> >> Sheep is produced by "EnabledSheepProducer" class that is defined in >> beans.xml and "NotEnabledSheepProducer" class that is not defined in >> beans.xml. So the first assertion in the test is correct >> 1) assert getBeans(Sheep.class, new AnnotationLiteral<Wild>(){}).size() >> == 2; >> >> But how the second assertion is correct? >> 2) assert getBeans(Sheep.class, new AnnotationLiteral<Tame>(){}).size() >> == 2; >> NotEnabledSheepProducer is not defined in beans.xml. So producer field >> and method that is contained in this class are disabled. > > I agree. The producers are declared on a disabled bean thus they should > be disabled. This is how the test was originally written but was > modified later because of https://jira.jboss.org/jira/browse/WELD-277 > >> >> - testProducerPoliciesOnMethodAndField >> CatProducer class defines producer field and method that are annotated >> with @Alternative. According to the spec section 5.1.1 "the alternative >> is a producer method, field or resource, and the bean class that >> declares the method or field is listed in beans.xml". CatProducer class >> is not defined in beans.xml so those producer beans must be disabled and >> must not be used in resolutions. >> >> So the following assertions must be false, because CatProducer class is >> not defined in beans.xml >> assert getBeans(Cat.class, new AnnotationLiteral<Wild>(){}).size() == 2; > These producers are not alternatives nor are they declared on > alternative bean so I think the assertion is OK. > >> assert getBeans(Cat.class, new AnnotationLiteral<Tame>(){}).size() == 2; > Right, this should resolve to 0 beans IMHO. >> >> WDYT? >> >> Thanks; >> >> --Gurkan >> >> ------------------------------------------------------------------------ >> Yahoo! Türkiye açıldı! >> Haber, Ekonomi, Videolar, Oyunlar hepsi Yahoo! Türkiye'de! >> www.yahoo.com.tr <http://tr.yahoo.com/> >> >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev > _______________________________________________ > weld-dev mailing list > weld-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev