No worries about Weld 2 releases, I've already informed the team of the
situation regarding that branch, but I thought it was no trouble to submit
a PR anyway.
Regarding your question about verification, my understanding of where
things are is that we shifted to looking for a more general solution to
make liberty more resilient as we promptly uncovered a different upstream
component that had a stream without a closing statement. Tom Bitonti will
be taking the lead on that.
From: Matej Novotny <manovotn(a)redhat.com>
To: Benjamin Confino <BENJAMIC(a)uk.ibm.com>
Cc: weld-dev(a)lists.jboss.org, Thomas Bitonti <bitonti(a)us.ibm.com>
Date: 09/12/2019 10:12
Subject: [EXTERNAL] Re: [weld-dev] Pull Request to close
weld.properties file sooner
thanks for the PR. We're totally missing the stream closing statement
I take it you verified that this fixes the problem in Liberty?
Otherwise, master branch (Weld 3.1) is totally where these PRs should go.
As for 3.0, we do not plan any releases there, we are going forward with
just 3.1 branch.
So I don't really see much value in merging it there.
Last but not least, Weld 2 is not actively developed anymore and doesn't
have a set release schedule.
Therefore, we can merge it there, but with no promises on release dates.
I've created a tracking JIRA for this -
----- Original Message -----
From: "Benjamin Confino" <BENJAMIC(a)uk.ibm.com>
Cc: "Thomas Bitonti" <bitonti(a)us.ibm.com>
Sent: Saturday, December 7, 2019 12:34:17 PM
Subject: [weld-dev] Pull Request to close weld.properties file sooner
We encountered a bug in liberty which we think is caused by the
weld.properties file remaining open for longer than liberty expects
be held open. To resolve this I have submitted a trio of small pull
that will close the InputStream in a finally block after
read. You can find them at:
> I hope these PRs meet with your approval.
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> weld-dev mailing list
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU