Re: [aerogear-dev] [cordova] Push Plugin : externalise Push config

+1 that would be very useful We should consider allowing both approaches, in-code and in separated config file.

On Thu, Oct 9, 2014 at 9:17 AM, Sebastien Blanc <scm.blanc(a)gmail.com&gt; wrote: > Cool ! > Here we go then https://issues.jboss.org/browse/AGCORDOVA-34 > > > > On Thu, Oct 9, 2014 at 9:13 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; > wrote: > >> >> Like it. >> >> On 9 Oct,2014, at 8:56 , Sebastien Blanc <scm.blanc(a)gmail.com&gt; wrote: >> >> Hi all, >> I was thinking of that : as we are adding more and more support for Push >> Networks (iOS, Android, Microsoft, firefoxOS, Amazon), the configuration >> list is getting longer and longer in the code. What about creating a >> separate json file containing this config that the plugin could consume ? >> >> like, pushconfig.json : >> >> { >> pushServerURL: "https://javaoneups-sblanc.rhcloud.com/ag-push/", >> android: { >> senderID: "313664704978", >> variantID: "39d64fb1-6c82-4638-9d02-3fbbbad5ba28", >> variantSecret: "d2e4e60a-e3d9-4db7-acee-0d18abc953a4" >> }, >> ios : { >> .... >> }, >> simplePush : { >> ... >> }, >> microsoft : { >> ... >> }, >> amazon : { >> ... >> } >> } >> >> That should not be mandatory as we could still use the "inline" style. >> >> wdyt ? >> >> Sebi >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev