On 07/23/2013 05:17 AM, Matthias Wessendorf wrote:
Hello,
I have a few question on the 'push' branch:
1) going over the MessageHandler interface ([1]), am I right that the
"onError()" and "onDeleteMessage()" methods are only relevant for the
"device to cloud" case ?
Not exactly. These are handlers for status
messages from GCM.
onDeleteMessage is sent to the client when a notification has been
removed from the server. This can be because they notifications are
being batched for instance.
See the GcmBroadcastReceiver sample code for details:
https://developer.android.com/google/gcm/gs.html
And the
javadocs:https://developer.android.com/reference/com/google/android/gms/g...
As far as the error message handler goes, the docs aren't explicit, but
I think I misread it and you are correct. It is a callback for when an
error on the server happens receiving a message from the client.
2) I know it's early work, but I was wondering if we should (later)
rename the 'AGPushMessageReceiver' class ([2]).
+1 to a rename.
Not sure on a better name, but the AG prefix seems a little odd :)
Perhaps:
* PushMessageReceiver
* AeroGearPushMessageReceiver
* GCMMessageReceiver (since this is really "only" GCM based push
messaging)
* AeroGearGCMMessageReceiver
I like this one.
If folks agree on a later rename, I'd create a JIRA to track this ;-)