Re: [aerogear-dev] Formatting versus code fixes

Lucas Holmquist <mailto:lholmqui@redhat.com> September 12, 2013 9:44 AM On Sep 12, 2013, at 8:38 AM, Bruno Oliveira <bruno(a)abstractj.org&gt; wrote: > Guys, just run mvn java-formatter:formatbefore commit, we have it > enabled at POM parent as far as I know. yup, as long as we are doing it every time we do a PR. but when it's on a mature code base that hasn't had it before and mixed with other changes, then things get hairy >> Lucas Holmquist <mailto:lholmqui@redhat.com> >> September 12, 2013 9:31 AM >> +1 >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> Daniel Bevenius <mailto:daniel.bevenius@gmail.com> >> September 12, 2013 4:13 AM >> #agreed >> >> >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> Matthias Wessendorf <mailto:matzew@apache.org> >> September 12, 2013 4:00 AM >> Hi, >> >> it's nice when we like to format code, however mixing that with actual >> fixes, makes it VERY hard to review the real change.... >> >> Please let's not mix these things; It's IMO annoying going over 100 >> files, when the real fix involves just 2 or 3 files.... >> >> -M >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- > abstractj > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev Lucas Holmquist <mailto:lholmqui@redhat.com> September 12, 2013 9:31 AM +1 _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev Daniel Bevenius <mailto:daniel.bevenius@gmail.com> September 12, 2013 4:13 AM #agreed _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev Matthias Wessendorf <mailto:matzew@apache.org> September 12, 2013 4:00 AM Hi, it's nice when we like to format code, however mixing that with actual fixes, makes it VERY hard to review the real change.... Please let's not mix these things; It's IMO annoying going over 100 files, when the real fix involves just 2 or 3 files.... -M -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev