see earlier discussion: we just use query, hence no need for such a param ;-)
On Wed, Jan 23, 2013 at 4:53 PM, Summers Pittman <supittma(a)redhat.com> wrote:
On 01/23/2013 06:23 AM, Matthias Wessendorf wrote:
> Hi,
>
> reading the [spec]:
> ```
> pagingLocation: String, indicate whether paging information is sent as
> query parameters (default), or on the request header.
> ```
> 1)
> I think we need one more config setting, to say under what specific
> header the server is expecting the "query information".
I thought this was the point of the ParameterProvider.
> Like:
> httpRequest.addHeader("My-Awful-Query", someValue);
> // where the "My-Awful-Query" is replaced by the actual header key
>
> 2)
> Name suggestions:
> -queryHeaderIdentifier
> -queryHeaderName
> -queryHeader
>
> 3)
> Perhaps a minor thing... but I think I don't like the 'pagingLocation'
> name... if you just read that name, it is NOT (for me) clear
> that this drives if the query strings is sent as a)header value or
> b)appended as http query.
Yeah that is annoying, while I was implementing stuff I had to keep
checking what that meant. We could make it a boolean
"sendPagingAsHeader" and if it is false sent them as a query. (Not a
great idea but it may be a better direction)
>
> Any thoughts?
>
> -Matthias
>
> [spec]
https://github.com/aerogear/aerogear.org/blob/client_paging_spec/docs/spe...
>
_______________________________________________
aerogear-dev mailing list
aerogear-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/aerogear-dev